milvus/internal/core/src/segcore/ChunkedSegmentSealedImpl.h
sthuang 238bd30f42
fix: [StorageV2] end to end minor issues for sync, stats, and load (#42948)
Fix issues in end-to-end tests: 
1. **Split column groups based on schema**, rather than estimating by
average chunk row size. **Ensure column group consistency within a
segment**, to avoid errors caused by loading multiple column group
chunks simultaneously.
2. **Use sorted segmentId** when generating the stats binlog path, to
ensure consistent and correct file path resolution.
3. **Determine field IDs as follows**:
For multi-column column groups, retrieve the field ID list from
metadata.
For single-column column groups, use the column group ID directly as the
field ID.

related: #39173 
fix: #42862

---------

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2025-06-27 14:44:42 +08:00

484 lines
14 KiB
C++

// Copyright (C) 2019-2020 Zilliz. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software distributed under the License
// is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
// or implied. See the License for the specific language governing permissions and limitations under the License
#pragma once
#include <tbb/concurrent_priority_queue.h>
#include <tbb/concurrent_vector.h>
#include <memory>
#include <string>
#include <unordered_map>
#include <utility>
#include <vector>
#include "ConcurrentVector.h"
#include "DeletedRecord.h"
#include "SealedIndexingRecord.h"
#include "SegmentSealed.h"
#include "common/EasyAssert.h"
#include "common/Schema.h"
#include "google/protobuf/message_lite.h"
#include "mmap/Types.h"
#include "common/Types.h"
#include "common/IndexMeta.h"
#include "cachinglayer/CacheSlot.h"
#include "cachinglayer/CacheSlot.h"
#include "segcore/IndexConfigGenerator.h"
#include "segcore/SegcoreConfig.h"
namespace milvus::segcore {
namespace storagev1translator {
class InsertRecordTranslator;
}
using namespace milvus::cachinglayer;
class ChunkedSegmentSealedImpl : public SegmentSealed {
public:
explicit ChunkedSegmentSealedImpl(SchemaPtr schema,
IndexMetaPtr index_meta,
const SegcoreConfig& segcore_config,
int64_t segment_id,
bool TEST_skip_index_for_retrieve = false,
bool is_sorted_by_pk = false);
~ChunkedSegmentSealedImpl() override;
void
LoadIndex(const LoadIndexInfo& info) override;
void
LoadFieldData(const LoadFieldDataInfo& info) override;
void
LoadDeletedRecord(const LoadDeletedRecordInfo& info) override;
void
LoadSegmentMeta(
const milvus::proto::segcore::LoadSegmentMeta& segment_meta) override;
void
DropIndex(const FieldId field_id) override;
void
DropFieldData(const FieldId field_id) override;
bool
HasIndex(FieldId field_id) const override;
bool
HasFieldData(FieldId field_id) const override;
bool
Contain(const PkType& pk) const override {
return insert_record_.contain(pk);
}
void
AddFieldDataInfoForSealed(
const LoadFieldDataInfo& field_data_info) override;
int64_t
get_segment_id() const override {
return id_;
}
bool
HasRawData(int64_t field_id) const override;
DataType
GetFieldDataType(FieldId fieldId) const override;
void
RemoveFieldFile(const FieldId field_id) override;
void
CreateTextIndex(FieldId field_id) override;
void
LoadTextIndex(FieldId field_id,
std::unique_ptr<index::TextMatchIndex> index) override;
void
LoadJsonKeyIndex(
FieldId field_id,
std::unique_ptr<index::JsonKeyStatsInvertedIndex> index) override {
std::unique_lock lck(mutex_);
const auto& field_meta = schema_->operator[](field_id);
json_key_indexes_[field_id] = std::move(index);
}
index::JsonKeyStatsInvertedIndex*
GetJsonKeyIndex(FieldId field_id) const override {
std::shared_lock lck(mutex_);
auto iter = json_key_indexes_.find(field_id);
if (iter == json_key_indexes_.end()) {
return nullptr;
}
return iter->second.get();
}
// TODO(tiered storage 1): should return a PinWrapper
void
BulkGetJsonData(FieldId field_id,
std::function<void(milvus::Json, size_t, bool)> fn,
const int64_t* offsets,
int64_t count) const override {
auto column = fields_.at(field_id);
column->BulkRawJsonAt(fn, offsets, count);
}
void
Reopen(SchemaPtr sch) override;
void
LazyCheckSchema(SchemaPtr sch) override;
void
FinishLoad() override;
public:
size_t
GetMemoryUsageInBytes() const override {
return stats_.mem_size.load() + deleted_record_.mem_size();
}
InsertRecord<true>&
get_insert_record() override {
return insert_record_;
}
int64_t
get_row_count() const override;
int64_t
get_deleted_count() const override;
const Schema&
get_schema() const override;
std::vector<SegOffset>
search_pk(const PkType& pk, Timestamp timestamp) const override;
template <typename Condition>
std::vector<SegOffset>
search_sorted_pk(const PkType& pk, Condition condition) const;
std::unique_ptr<DataArray>
get_vector(FieldId field_id,
const int64_t* ids,
int64_t count) const override;
bool
is_nullable(FieldId field_id) const override {
auto& field_meta = schema_->operator[](field_id);
return field_meta.is_nullable();
};
bool
is_chunked() const override {
return true;
}
public:
int64_t
num_chunk_index(FieldId field_id) const override;
// count of chunk that has raw data
int64_t
num_chunk_data(FieldId field_id) const override;
int64_t
num_chunk(FieldId field_id) const override;
// return size_per_chunk for each chunk, renaming against confusion
int64_t
size_per_chunk() const override;
int64_t
chunk_size(FieldId field_id, int64_t chunk_id) const override;
std::pair<int64_t, int64_t>
get_chunk_by_offset(FieldId field_id, int64_t offset) const override;
int64_t
num_rows_until_chunk(FieldId field_id, int64_t chunk_id) const override;
std::string
debug() const override;
SegcoreError
Delete(int64_t size,
const IdArray* pks,
const Timestamp* timestamps) override;
std::pair<std::vector<OffsetMap::OffsetType>, bool>
find_first(int64_t limit, const BitsetType& bitset) const override;
// Calculate: output[i] = Vec[seg_offset[i]]
// where Vec is determined from field_offset
std::unique_ptr<DataArray>
bulk_subscript(FieldId field_id,
const int64_t* seg_offsets,
int64_t count) const override;
std::unique_ptr<DataArray>
bulk_subscript(
FieldId field_id,
const int64_t* seg_offsets,
int64_t count,
const std::vector<std::string>& dynamic_field_names) const override;
bool
is_mmap_field(FieldId id) const override;
void
ClearData() override;
bool
is_field_exist(FieldId field_id) const override {
return schema_->get_fields().find(field_id) !=
schema_->get_fields().end();
}
protected:
// blob and row_count
PinWrapper<SpanBase>
chunk_data_impl(FieldId field_id, int64_t chunk_id) const override;
PinWrapper<std::pair<std::vector<std::string_view>, FixedVector<bool>>>
chunk_string_view_impl(
FieldId field_id,
int64_t chunk_id,
std::optional<std::pair<int64_t, int64_t>> offset_len) const override;
PinWrapper<std::pair<std::vector<ArrayView>, FixedVector<bool>>>
chunk_array_view_impl(
FieldId field_id,
int64_t chunk_id,
std::optional<std::pair<int64_t, int64_t>> offset_len) const override;
PinWrapper<std::pair<std::vector<std::string_view>, FixedVector<bool>>>
chunk_view_by_offsets(FieldId field_id,
int64_t chunk_id,
const FixedVector<int32_t>& offsets) const override;
PinWrapper<const index::IndexBase*>
chunk_index_impl(FieldId field_id, int64_t chunk_id) const override;
// Calculate: output[i] = Vec[seg_offset[i]],
// where Vec is determined from field_offset
void
bulk_subscript(SystemFieldType system_type,
const int64_t* seg_offsets,
int64_t count,
void* output) const override;
void
check_search(const query::Plan* plan) const override;
int64_t
get_active_count(Timestamp ts) const override;
const ConcurrentVector<Timestamp>&
get_timestamps() const override {
return insert_record_.timestamps_;
}
private:
void
load_system_field_internal(FieldId field_id, FieldDataInfo& data);
template <typename S, typename T = S>
static void
bulk_subscript_impl(const void* src_raw,
const int64_t* seg_offsets,
int64_t count,
T* dst_raw);
template <typename S, typename T = S>
static void
bulk_subscript_impl(ChunkedColumnInterface* field,
const int64_t* seg_offsets,
int64_t count,
T* dst_raw);
template <typename S>
static void
bulk_subscript_ptr_impl(
ChunkedColumnInterface* field,
const int64_t* seg_offsets,
int64_t count,
google::protobuf::RepeatedPtrField<std::string>* dst_raw);
template <typename T>
static void
bulk_subscript_array_impl(ChunkedColumnInterface* column,
const int64_t* seg_offsets,
int64_t count,
google::protobuf::RepeatedPtrField<T>* dst);
template <typename T>
static void
bulk_subscript_vector_array_impl(
const ChunkedColumnInterface* column,
const int64_t* seg_offsets,
int64_t count,
google::protobuf::RepeatedPtrField<T>* dst);
static void
bulk_subscript_impl(int64_t element_sizeof,
ChunkedColumnInterface* field,
const int64_t* seg_offsets,
int64_t count,
void* dst_raw);
std::unique_ptr<DataArray>
fill_with_empty(FieldId field_id, int64_t count) const;
std::unique_ptr<DataArray>
get_raw_data(FieldId field_id,
const FieldMeta& field_meta,
const int64_t* seg_offsets,
int64_t count) const;
void
update_row_count(int64_t row_count) {
num_rows_ = row_count;
deleted_record_.set_sealed_row_count(row_count);
}
void
mask_with_timestamps(BitsetTypeView& bitset_chunk,
Timestamp timestamp,
Timestamp collection_ttl) const override;
void
vector_search(SearchInfo& search_info,
const void* query_data,
int64_t query_count,
Timestamp timestamp,
const BitsetView& bitset,
SearchResult& output) const override;
void
mask_with_delete(BitsetTypeView& bitset,
int64_t ins_barrier,
Timestamp timestamp) const override;
bool
is_system_field_ready() const {
return system_ready_count_ == 1;
}
std::pair<std::unique_ptr<IdArray>, std::vector<SegOffset>>
search_ids(const IdArray& id_array, Timestamp timestamp) const override;
void
LoadVecIndex(const LoadIndexInfo& info);
void
LoadScalarIndex(const LoadIndexInfo& info);
bool
generate_interim_index(const FieldId field_id, int64_t num_rows);
void
fill_empty_field(const FieldMeta& field_meta);
void
init_timestamp_index(const std::vector<Timestamp>& timestamps,
size_t num_rows);
void
load_field_data_internal(const LoadFieldDataInfo& load_info);
void
load_column_group_data_internal(const LoadFieldDataInfo& load_info);
void
load_field_data_common(
FieldId field_id,
const std::shared_ptr<ChunkedColumnInterface>& column,
size_t num_rows,
DataType data_type,
bool enable_mmap,
bool is_proxy_column);
private:
// InsertRecord needs to pin pk column.
friend class storagev1translator::InsertRecordTranslator;
// mmap descriptor, used in chunk cache
storage::MmapChunkDescriptorPtr mmap_descriptor_ = nullptr;
// segment loading state
BitsetType field_data_ready_bitset_;
BitsetType index_ready_bitset_;
BitsetType binlog_index_bitset_;
std::atomic<int> system_ready_count_ = 0;
// when index is ready (index_ready_bitset_/binlog_index_bitset_ is set to true), must also set index_has_raw_data_
// to indicate whether the loaded index has raw data.
std::unordered_map<FieldId, bool> index_has_raw_data_;
// TODO: generate index for scalar
std::optional<int64_t> num_rows_;
// scalar field index
std::unordered_map<FieldId, index::CacheIndexBasePtr> scalar_indexings_;
// vector field index
SealedIndexingRecord vector_indexings_;
// inserted fields data and row_ids, timestamps
InsertRecord<true> insert_record_;
// deleted pks
mutable DeletedRecord<true> deleted_record_;
LoadFieldDataInfo field_data_info_;
SchemaPtr schema_;
int64_t id_;
mutable std::unordered_map<FieldId, std::shared_ptr<ChunkedColumnInterface>>
fields_;
std::unordered_set<FieldId> mmap_fields_;
// only useful in binlog
IndexMetaPtr col_index_meta_;
SegcoreConfig segcore_config_;
std::unordered_map<FieldId, std::unique_ptr<VecIndexConfig>>
vec_binlog_config_;
SegmentStats stats_{};
// for sparse vector unit test only! Once a type of sparse index that
// doesn't has raw data is added, this should be removed.
bool TEST_skip_index_for_retrieve_ = false;
// whether the segment is sorted by the pk
// 1. will skip index loading for primary key field
bool is_sorted_by_pk_ = false;
// used for json expr optimization
std::unordered_map<FieldId,
std::unique_ptr<index::JsonKeyStatsInvertedIndex>>
json_key_indexes_;
};
inline SegmentSealedUPtr
CreateSealedSegment(
SchemaPtr schema,
IndexMetaPtr index_meta = empty_index_meta,
int64_t segment_id = 0,
const SegcoreConfig& segcore_config = SegcoreConfig::default_config(),
bool TEST_skip_index_for_retrieve = false,
bool is_sorted_by_pk = false) {
return std::make_unique<ChunkedSegmentSealedImpl>(
schema,
index_meta,
segcore_config,
segment_id,
TEST_skip_index_for_retrieve,
is_sorted_by_pk);
}
} // namespace milvus::segcore