mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-06 17:18:35 +08:00
20411e5218
1. Fix replicator cannot stop if error occurs on replicate stream RPC. 2. Simplify replicate stream client. 3. Enhance replicate config validator: 1. Compare the incoming replicate config, cluster attributes must not be changed. 2. Cluster URI must be unique. 3. Remove the check of pchannel prefix. issue: https://github.com/milvus-io/milvus/issues/44123 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com> Co-authored-by: chyezh <chyezh@outlook.com>
92 lines
3.2 KiB
Go
92 lines
3.2 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package replicatemanager
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
mock "github.com/stretchr/testify/mock"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus/internal/cdc/cluster"
|
|
"github.com/milvus-io/milvus/internal/cdc/resource"
|
|
"github.com/milvus-io/milvus/internal/metastore/kv/streamingcoord"
|
|
"github.com/milvus-io/milvus/pkg/v2/proto/streamingpb"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/paramtable"
|
|
)
|
|
|
|
func TestReplicateManager_CreateReplicator(t *testing.T) {
|
|
paramtable.Get().Save(paramtable.Get().CommonCfg.ClusterPrefix.Key, "test-source")
|
|
defer paramtable.Get().Reset(paramtable.Get().CommonCfg.ClusterPrefix.Key)
|
|
|
|
mockMilvusClient := cluster.NewMockMilvusClient(t)
|
|
mockMilvusClient.EXPECT().GetReplicateInfo(mock.Anything, mock.Anything).
|
|
Return(nil, assert.AnError).Maybe()
|
|
mockMilvusClient.EXPECT().Close(mock.Anything).Return(nil).Maybe()
|
|
|
|
mockClusterClient := cluster.NewMockClusterClient(t)
|
|
mockClusterClient.EXPECT().CreateMilvusClient(mock.Anything, mock.Anything).
|
|
Return(mockMilvusClient, nil).Maybe()
|
|
resource.InitForTest(t,
|
|
resource.OptClusterClient(mockClusterClient),
|
|
)
|
|
|
|
manager := NewReplicateManager()
|
|
|
|
// Test creating first replicator
|
|
replicateInfo := &streamingpb.ReplicatePChannelMeta{
|
|
SourceChannelName: "test-source-channel-1",
|
|
TargetChannelName: "test-target-channel-1",
|
|
TargetCluster: &commonpb.MilvusCluster{
|
|
ClusterId: "test-cluster-1",
|
|
},
|
|
}
|
|
|
|
manager.CreateReplicator(replicateInfo)
|
|
|
|
// Verify replicator was created
|
|
assert.Equal(t, 1, len(manager.replicators))
|
|
key := streamingcoord.BuildReplicatePChannelMetaKey(replicateInfo)
|
|
replicator, exists := manager.replicators[key]
|
|
assert.True(t, exists)
|
|
assert.NotNil(t, replicator)
|
|
|
|
// Test creating second replicator
|
|
replicateInfo2 := &streamingpb.ReplicatePChannelMeta{
|
|
SourceChannelName: "test-source-channel-2",
|
|
TargetChannelName: "test-target-channel-2",
|
|
TargetCluster: &commonpb.MilvusCluster{
|
|
ClusterId: "test-cluster-2",
|
|
},
|
|
}
|
|
|
|
manager.CreateReplicator(replicateInfo2)
|
|
|
|
// Verify second replicator was created
|
|
assert.Equal(t, 2, len(manager.replicators))
|
|
key2 := streamingcoord.BuildReplicatePChannelMetaKey(replicateInfo2)
|
|
replicator2, exists := manager.replicators[key2]
|
|
assert.True(t, exists)
|
|
assert.NotNil(t, replicator2)
|
|
|
|
// Verify first replicator still exists
|
|
replicator1, exists := manager.replicators[key]
|
|
assert.True(t, exists)
|
|
assert.NotNil(t, replicator1)
|
|
}
|