mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-07 09:38:39 +08:00
19e5e9f910
issue: #43897 - Return LastConfirmedMessageID when wal append operation. - Add resource-key-based locker for broadcast-ack operation to protect the coord state when executing ddl. - Resource-key-based locker is held until the broadcast operation is acked. - ResourceKey support shared and exclusive lock. - Add FastAck execute ack right away after the broadcast done to speed up ddl. - Ack callback will support broadcast message result now. - Add tombstone for broadcaster to avoid to repeatedly commit DDL and ABA issue. --------- Signed-off-by: chyezh <chyezh@outlook.com>
56 lines
2.1 KiB
Go
56 lines
2.1 KiB
Go
package registry
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
"google.golang.org/protobuf/proto"
|
|
|
|
"github.com/milvus-io/milvus/pkg/v2/streaming/util/message"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/syncutil"
|
|
)
|
|
|
|
// MessageAckCallback is the callback function for the message type.
|
|
type (
|
|
MessageAckCallback[H proto.Message, B proto.Message] = func(ctx context.Context, result message.BroadcastResult[H, B]) error
|
|
messageInnerAckCallback = func(ctx context.Context, msg message.BroadcastMutableMessage, result map[string]*message.AppendResult) error
|
|
)
|
|
|
|
// messageAckCallbacks is the map of message type to the callback function.
|
|
var messageAckCallbacks map[message.MessageTypeWithVersion]*syncutil.Future[messageInnerAckCallback]
|
|
|
|
// registerMessageAckCallback registers the callback function for the message type.
|
|
func registerMessageAckCallback[H proto.Message, B proto.Message](callback MessageAckCallback[H, B]) {
|
|
typ := message.MustGetMessageTypeWithVersion[H, B]()
|
|
future, ok := messageAckCallbacks[typ]
|
|
if !ok {
|
|
panic(fmt.Sprintf("the future of message callback for type %s is not registered", typ))
|
|
}
|
|
if future.Ready() {
|
|
// only for test, the register callback should be called once and only once
|
|
return
|
|
}
|
|
future.Set(func(ctx context.Context, msgs message.BroadcastMutableMessage, result map[string]*message.AppendResult) error {
|
|
return callback(ctx, message.BroadcastResult[H, B]{
|
|
Message: message.MustAsSpecializedBroadcastMessage[H, B](msgs),
|
|
Results: result,
|
|
})
|
|
})
|
|
}
|
|
|
|
// CallMessageAckCallback calls the callback function for the message type.
|
|
func CallMessageAckCallback(ctx context.Context, msg message.BroadcastMutableMessage, result map[string]*message.AppendResult) error {
|
|
version := msg.MessageTypeWithVersion()
|
|
callbackFuture, ok := messageAckCallbacks[version]
|
|
if !ok {
|
|
// No callback need tobe called, return nil
|
|
return nil
|
|
}
|
|
callback, err := callbackFuture.GetWithContext(ctx)
|
|
if err != nil {
|
|
return errors.Wrap(err, "when waiting callback registered")
|
|
}
|
|
return callback(ctx, msg, result)
|
|
}
|