mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-06 17:18:35 +08:00
19e5e9f910
issue: #43897 - Return LastConfirmedMessageID when wal append operation. - Add resource-key-based locker for broadcast-ack operation to protect the coord state when executing ddl. - Resource-key-based locker is held until the broadcast operation is acked. - ResourceKey support shared and exclusive lock. - Add FastAck execute ack right away after the broadcast done to speed up ddl. - Ack callback will support broadcast message result now. - Add tombstone for broadcaster to avoid to repeatedly commit DDL and ABA issue. --------- Signed-off-by: chyezh <chyezh@outlook.com>
584 lines
20 KiB
Go
584 lines
20 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rootcoord
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
|
|
"github.com/milvus-io/milvus/internal/coordinator/snmanager"
|
|
"github.com/milvus-io/milvus/internal/distributed/streaming"
|
|
"github.com/milvus-io/milvus/internal/metastore/model"
|
|
"github.com/milvus-io/milvus/internal/mocks"
|
|
"github.com/milvus-io/milvus/internal/mocks/distributed/mock_streaming"
|
|
"github.com/milvus-io/milvus/internal/mocks/streamingcoord/server/mock_balancer"
|
|
mockrootcoord "github.com/milvus-io/milvus/internal/rootcoord/mocks"
|
|
"github.com/milvus-io/milvus/internal/streamingcoord/server/balancer"
|
|
"github.com/milvus-io/milvus/internal/streamingcoord/server/balancer/balance"
|
|
mocktso "github.com/milvus-io/milvus/internal/tso/mocks"
|
|
"github.com/milvus-io/milvus/internal/util/streamingutil"
|
|
"github.com/milvus-io/milvus/pkg/v2/common"
|
|
"github.com/milvus-io/milvus/pkg/v2/proto/querypb"
|
|
"github.com/milvus-io/milvus/pkg/v2/streaming/util/types"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/merr"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/syncutil"
|
|
)
|
|
|
|
func TestGarbageCollectorCtx_ReDropCollection(t *testing.T) {
|
|
oldValue := confirmGCInterval
|
|
defer func() {
|
|
confirmGCInterval = oldValue
|
|
}()
|
|
confirmGCInterval = 0
|
|
t.Run("failed to release collection", func(t *testing.T) {
|
|
broker := newMockBroker()
|
|
broker.ReleaseCollectionFunc = func(ctx context.Context, collectionID UniqueID) error {
|
|
return errors.New("error mock ReleaseCollection")
|
|
}
|
|
ticker := newTickerWithMockNormalStream()
|
|
core := newTestCore(withBroker(broker), withTtSynchronizer(ticker), withValidProxyManager())
|
|
gc := newBgGarbageCollector(core)
|
|
gc.ReDropCollection(&model.Collection{}, 1000)
|
|
})
|
|
|
|
t.Run("failed to DropCollectionIndex", func(t *testing.T) {
|
|
broker := newMockBroker()
|
|
releaseCollectionCalled := false
|
|
releaseCollectionChan := make(chan struct{}, 1)
|
|
broker.ReleaseCollectionFunc = func(ctx context.Context, collectionID UniqueID) error {
|
|
releaseCollectionCalled = true
|
|
releaseCollectionChan <- struct{}{}
|
|
return nil
|
|
}
|
|
broker.DropCollectionIndexFunc = func(ctx context.Context, collID UniqueID, partIDs []UniqueID) error {
|
|
return errors.New("error mock DropCollectionIndex")
|
|
}
|
|
ticker := newTickerWithMockNormalStream()
|
|
core := newTestCore(withBroker(broker), withTtSynchronizer(ticker), withValidProxyManager())
|
|
gc := newBgGarbageCollector(core)
|
|
core.garbageCollector = gc
|
|
gc.ReDropCollection(&model.Collection{}, 1000)
|
|
<-releaseCollectionChan
|
|
assert.True(t, releaseCollectionCalled)
|
|
})
|
|
|
|
t.Run("failed to GcCollectionData", func(t *testing.T) {
|
|
broker := newMockBroker()
|
|
releaseCollectionCalled := false
|
|
releaseCollectionChan := make(chan struct{}, 1)
|
|
broker.ReleaseCollectionFunc = func(ctx context.Context, collectionID UniqueID) error {
|
|
releaseCollectionCalled = true
|
|
releaseCollectionChan <- struct{}{}
|
|
return nil
|
|
}
|
|
dropCollectionIndexCalled := false
|
|
dropCollectionIndexChan := make(chan struct{}, 1)
|
|
broker.DropCollectionIndexFunc = func(ctx context.Context, collID UniqueID, partIDs []UniqueID) error {
|
|
dropCollectionIndexCalled = true
|
|
dropCollectionIndexChan <- struct{}{}
|
|
return nil
|
|
}
|
|
ticker := newTickerWithMockFailStream() // failed to broadcast drop msg.
|
|
tsoAllocator := newMockTsoAllocator()
|
|
tsoAllocator.GenerateTSOF = func(count uint32) (uint64, error) {
|
|
return 100, nil
|
|
}
|
|
core := newTestCore(withBroker(broker), withTtSynchronizer(ticker), withTsoAllocator(tsoAllocator), withValidProxyManager())
|
|
core.ddlTsLockManager = newDdlTsLockManager(core.tsoAllocator)
|
|
gc := newBgGarbageCollector(core)
|
|
core.garbageCollector = gc
|
|
shardsNum := common.DefaultShardsNum
|
|
pchans := ticker.getDmlChannelNames(int(shardsNum))
|
|
gc.ReDropCollection(&model.Collection{PhysicalChannelNames: pchans}, 1000)
|
|
<-releaseCollectionChan
|
|
assert.True(t, releaseCollectionCalled)
|
|
<-dropCollectionIndexChan
|
|
assert.True(t, dropCollectionIndexCalled)
|
|
})
|
|
|
|
t.Run("failed to remove collection", func(t *testing.T) {
|
|
broker := newMockBroker()
|
|
releaseCollectionCalled := false
|
|
releaseCollectionChan := make(chan struct{}, 1)
|
|
broker.ReleaseCollectionFunc = func(ctx context.Context, collectionID UniqueID) error {
|
|
releaseCollectionCalled = true
|
|
releaseCollectionChan <- struct{}{}
|
|
return nil
|
|
}
|
|
gcConfirmCalled := false
|
|
gcConfirmChan := make(chan struct{})
|
|
broker.GCConfirmFunc = func(ctx context.Context, collectionID, partitionID UniqueID) bool {
|
|
gcConfirmCalled = true
|
|
close(gcConfirmChan)
|
|
return true
|
|
}
|
|
dropCollectionIndexCalled := false
|
|
dropCollectionIndexChan := make(chan struct{}, 1)
|
|
broker.DropCollectionIndexFunc = func(ctx context.Context, collID UniqueID, partIDs []UniqueID) error {
|
|
dropCollectionIndexCalled = true
|
|
dropCollectionIndexChan <- struct{}{}
|
|
return nil
|
|
}
|
|
|
|
dropMetaChan := make(chan struct{}, 1)
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("RemoveCollection",
|
|
mock.Anything, // context.Context
|
|
mock.AnythingOfType("int64"),
|
|
mock.AnythingOfType("uint64")).
|
|
Run(func(args mock.Arguments) {
|
|
dropMetaChan <- struct{}{}
|
|
}).
|
|
Return(errors.New("error mock RemoveCollection"))
|
|
ticker := newTickerWithMockNormalStream()
|
|
tsoAllocator := newMockTsoAllocator()
|
|
tsoAllocator.GenerateTSOF = func(count uint32) (uint64, error) {
|
|
return 100, nil
|
|
}
|
|
core := newTestCore(withBroker(broker),
|
|
withTtSynchronizer(ticker),
|
|
withTsoAllocator(tsoAllocator),
|
|
withValidProxyManager(),
|
|
withMeta(meta))
|
|
core.ddlTsLockManager = newDdlTsLockManager(core.tsoAllocator)
|
|
gc := newBgGarbageCollector(core)
|
|
core.garbageCollector = gc
|
|
gc.ReDropCollection(&model.Collection{}, 1000)
|
|
<-releaseCollectionChan
|
|
assert.True(t, releaseCollectionCalled)
|
|
<-dropCollectionIndexChan
|
|
assert.True(t, dropCollectionIndexCalled)
|
|
<-gcConfirmChan
|
|
assert.True(t, gcConfirmCalled)
|
|
<-dropMetaChan
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
broker := newMockBroker()
|
|
releaseCollectionCalled := false
|
|
releaseCollectionChan := make(chan struct{}, 1)
|
|
broker.ReleaseCollectionFunc = func(ctx context.Context, collectionID UniqueID) error {
|
|
releaseCollectionCalled = true
|
|
releaseCollectionChan <- struct{}{}
|
|
return nil
|
|
}
|
|
dropCollectionIndexCalled := false
|
|
dropCollectionIndexChan := make(chan struct{}, 1)
|
|
broker.DropCollectionIndexFunc = func(ctx context.Context, collID UniqueID, partIDs []UniqueID) error {
|
|
dropCollectionIndexCalled = true
|
|
dropCollectionIndexChan <- struct{}{}
|
|
return nil
|
|
}
|
|
gcConfirmCalled := false
|
|
gcConfirmChan := make(chan struct{})
|
|
broker.GCConfirmFunc = func(ctx context.Context, collectionID, partitionID UniqueID) bool {
|
|
gcConfirmCalled = true
|
|
close(gcConfirmChan)
|
|
return true
|
|
}
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
removeCollectionCalled := false
|
|
removeCollectionChan := make(chan struct{}, 1)
|
|
meta.On("RemoveCollection",
|
|
mock.Anything, // context.Context
|
|
mock.AnythingOfType("int64"),
|
|
mock.AnythingOfType("uint64")).
|
|
Return(func(ctx context.Context, collectionID int64, ts uint64) error {
|
|
removeCollectionCalled = true
|
|
removeCollectionChan <- struct{}{}
|
|
return nil
|
|
})
|
|
ticker := newTickerWithMockNormalStream()
|
|
tsoAllocator := newMockTsoAllocator()
|
|
tsoAllocator.GenerateTSOF = func(count uint32) (uint64, error) {
|
|
return 100, nil
|
|
}
|
|
core := newTestCore(withBroker(broker),
|
|
withTtSynchronizer(ticker),
|
|
withTsoAllocator(tsoAllocator),
|
|
withValidProxyManager(),
|
|
withMeta(meta))
|
|
core.ddlTsLockManager = newDdlTsLockManager(core.tsoAllocator)
|
|
gc := newBgGarbageCollector(core)
|
|
core.garbageCollector = gc
|
|
gc.ReDropCollection(&model.Collection{}, 1000)
|
|
<-releaseCollectionChan
|
|
assert.True(t, releaseCollectionCalled)
|
|
<-dropCollectionIndexChan
|
|
assert.True(t, dropCollectionIndexCalled)
|
|
<-removeCollectionChan
|
|
assert.True(t, removeCollectionCalled)
|
|
<-gcConfirmChan
|
|
assert.True(t, gcConfirmCalled)
|
|
})
|
|
}
|
|
|
|
func TestGarbageCollectorCtx_RemoveCreatingCollection(t *testing.T) {
|
|
t.Run("failed to UnwatchChannels", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
|
|
shardNum := 2
|
|
|
|
ticker := newRocksMqTtSynchronizer()
|
|
pchans := ticker.getDmlChannelNames(shardNum)
|
|
|
|
tsoAllocator := mocktso.NewAllocator(t)
|
|
tsoAllocator.
|
|
On("GenerateTSO", mock.AnythingOfType("uint32")).
|
|
Return(Timestamp(0), errors.New("error mock GenerateTSO"))
|
|
|
|
executed := make(chan struct{}, 1)
|
|
executor := newMockStepExecutor()
|
|
executor.AddStepsFunc = func(s *stepStack) {
|
|
s.Execute(context.Background())
|
|
executed <- struct{}{}
|
|
}
|
|
|
|
core := newTestCore(withTtSynchronizer(ticker), withTsoAllocator(tsoAllocator), withStepExecutor(executor))
|
|
gc := newBgGarbageCollector(core)
|
|
core.ddlTsLockManager = newDdlTsLockManager(tsoAllocator)
|
|
core.garbageCollector = gc
|
|
|
|
gc.RemoveCreatingCollection(&model.Collection{PhysicalChannelNames: pchans})
|
|
<-executed
|
|
})
|
|
|
|
t.Run("failed to RemoveCollection", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
|
|
shardNum := 2
|
|
|
|
ticker := newRocksMqTtSynchronizer()
|
|
pchans := ticker.getDmlChannelNames(shardNum)
|
|
|
|
tsoAllocator := mocktso.NewAllocator(t)
|
|
tsoAllocator.
|
|
On("GenerateTSO", mock.AnythingOfType("uint32")).
|
|
Return(Timestamp(100), nil)
|
|
|
|
for _, pchan := range pchans {
|
|
ticker.syncedTtHistogram.update(pchan, 101)
|
|
}
|
|
|
|
removeCollectionCalled := false
|
|
removeCollectionChan := make(chan struct{}, 1)
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("RemoveCollection",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(func(ctx context.Context, collectionID UniqueID, ts Timestamp) error {
|
|
removeCollectionCalled = true
|
|
removeCollectionChan <- struct{}{}
|
|
return errors.New("error mock RemoveCollection")
|
|
})
|
|
|
|
core := newTestCore(withTtSynchronizer(ticker), withMeta(meta), withTsoAllocator(tsoAllocator))
|
|
gc := newBgGarbageCollector(core)
|
|
core.ddlTsLockManager = newDdlTsLockManager(tsoAllocator)
|
|
core.garbageCollector = gc
|
|
|
|
gc.RemoveCreatingCollection(&model.Collection{PhysicalChannelNames: pchans})
|
|
<-removeCollectionChan
|
|
assert.True(t, removeCollectionCalled) // though it fail.
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
|
|
shardNum := 2
|
|
|
|
ticker := newRocksMqTtSynchronizer()
|
|
pchans := ticker.getDmlChannelNames(shardNum)
|
|
|
|
tsoAllocator := mocktso.NewAllocator(t)
|
|
tsoAllocator.
|
|
On("GenerateTSO", mock.AnythingOfType("uint32")).
|
|
Return(Timestamp(100), nil)
|
|
|
|
for _, pchan := range pchans {
|
|
ticker.syncedTtHistogram.update(pchan, 101)
|
|
}
|
|
|
|
removeCollectionCalled := false
|
|
removeCollectionChan := make(chan struct{}, 1)
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("RemoveCollection",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(func(ctx context.Context, collectionID UniqueID, ts Timestamp) error {
|
|
removeCollectionCalled = true
|
|
removeCollectionChan <- struct{}{}
|
|
return nil
|
|
})
|
|
|
|
core := newTestCore(withTtSynchronizer(ticker), withMeta(meta), withTsoAllocator(tsoAllocator))
|
|
gc := newBgGarbageCollector(core)
|
|
core.ddlTsLockManager = newDdlTsLockManager(tsoAllocator)
|
|
core.garbageCollector = gc
|
|
|
|
gc.RemoveCreatingCollection(&model.Collection{PhysicalChannelNames: pchans})
|
|
<-removeCollectionChan
|
|
assert.True(t, removeCollectionCalled)
|
|
})
|
|
}
|
|
|
|
func TestGarbageCollectorCtx_ReDropPartition(t *testing.T) {
|
|
oldValue := confirmGCInterval
|
|
defer func() {
|
|
confirmGCInterval = oldValue
|
|
}()
|
|
confirmGCInterval = 0
|
|
t.Run("failed to GcPartitionData", func(t *testing.T) {
|
|
ticker := newTickerWithMockFailStream() // failed to broadcast drop msg.
|
|
shardsNum := int(common.DefaultShardsNum)
|
|
pchans := ticker.getDmlChannelNames(shardsNum)
|
|
tsoAllocator := newMockTsoAllocator()
|
|
tsoAllocator.GenerateTSOF = func(count uint32) (uint64, error) {
|
|
return 100, nil
|
|
}
|
|
core := newTestCore(withTtSynchronizer(ticker), withTsoAllocator(tsoAllocator), withDropIndex())
|
|
core.ddlTsLockManager = newDdlTsLockManager(core.tsoAllocator)
|
|
gc := newBgGarbageCollector(core)
|
|
core.garbageCollector = gc
|
|
gc.ReDropPartition(0, pchans, nil, &model.Partition{}, 100000)
|
|
})
|
|
|
|
t.Run("failed to RemovePartition", func(t *testing.T) {
|
|
ticker := newTickerWithMockNormalStream()
|
|
shardsNum := int(common.DefaultShardsNum)
|
|
pchans := ticker.getDmlChannelNames(shardsNum)
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
removePartitionCalled := false
|
|
removePartitionChan := make(chan struct{}, 1)
|
|
meta.On("RemovePartition",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(func(ctx context.Context, dbID int64, collectionID int64, partitionID int64, ts uint64) error {
|
|
removePartitionCalled = true
|
|
removePartitionChan <- struct{}{}
|
|
return errors.New("error mock RemovePartition")
|
|
})
|
|
|
|
broker := newMockBroker()
|
|
gcConfirmCalled := false
|
|
gcConfirmChan := make(chan struct{})
|
|
broker.GCConfirmFunc = func(ctx context.Context, collectionID, partitionID UniqueID) bool {
|
|
gcConfirmCalled = true
|
|
close(gcConfirmChan)
|
|
return true
|
|
}
|
|
|
|
tsoAllocator := newMockTsoAllocator()
|
|
tsoAllocator.GenerateTSOF = func(count uint32) (uint64, error) {
|
|
return 100, nil
|
|
}
|
|
core := newTestCore(withMeta(meta), withTtSynchronizer(ticker), withTsoAllocator(tsoAllocator), withDropIndex(), withBroker(broker))
|
|
core.ddlTsLockManager = newDdlTsLockManager(core.tsoAllocator)
|
|
gc := newBgGarbageCollector(core)
|
|
core.garbageCollector = gc
|
|
gc.ReDropPartition(0, pchans, nil, &model.Partition{}, 100000)
|
|
<-gcConfirmChan
|
|
assert.True(t, gcConfirmCalled)
|
|
<-removePartitionChan
|
|
assert.True(t, removePartitionCalled)
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
ticker := newTickerWithMockNormalStream()
|
|
shardsNum := int(common.DefaultShardsNum)
|
|
pchans := ticker.getDmlChannelNames(shardsNum)
|
|
|
|
removePartitionCalled := false
|
|
removePartitionChan := make(chan struct{}, 1)
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("RemovePartition",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(func(ctx context.Context, dbID int64, collectionID int64, partitionID int64, ts uint64) error {
|
|
removePartitionCalled = true
|
|
removePartitionChan <- struct{}{}
|
|
return nil
|
|
})
|
|
|
|
broker := newMockBroker()
|
|
|
|
gcConfirmCalled := false
|
|
gcConfirmChan := make(chan struct{})
|
|
broker.GCConfirmFunc = func(ctx context.Context, collectionID, partitionID UniqueID) bool {
|
|
gcConfirmCalled = true
|
|
close(gcConfirmChan)
|
|
return true
|
|
}
|
|
|
|
tsoAllocator := newMockTsoAllocator()
|
|
tsoAllocator.GenerateTSOF = func(count uint32) (uint64, error) {
|
|
return 100, nil
|
|
}
|
|
core := newTestCore(withMeta(meta), withTtSynchronizer(ticker), withTsoAllocator(tsoAllocator), withDropIndex(), withBroker(broker))
|
|
core.ddlTsLockManager = newDdlTsLockManager(core.tsoAllocator)
|
|
gc := newBgGarbageCollector(core)
|
|
core.garbageCollector = gc
|
|
gc.ReDropPartition(0, pchans, nil, &model.Partition{}, 100000)
|
|
<-gcConfirmChan
|
|
assert.True(t, gcConfirmCalled)
|
|
<-removePartitionChan
|
|
assert.True(t, removePartitionCalled)
|
|
})
|
|
}
|
|
|
|
func TestGarbageCollector_RemoveCreatingPartition(t *testing.T) {
|
|
t.Run("test normal", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
|
|
ticker := newTickerWithMockNormalStream()
|
|
tsoAllocator := mocktso.NewAllocator(t)
|
|
|
|
signal := make(chan struct{}, 1)
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.EXPECT().RemovePartition(mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything).
|
|
Return(nil).
|
|
Run(func(ctx context.Context, dbID, collectionID int64, partitionID int64, ts uint64) {
|
|
signal <- struct{}{}
|
|
})
|
|
|
|
qc := mocks.NewMixCoord(t)
|
|
qc.EXPECT().ReleasePartitions(mock.Anything, mock.Anything).Return(merr.Success(), nil)
|
|
|
|
core := newTestCore(withTtSynchronizer(ticker),
|
|
withMeta(meta),
|
|
withTsoAllocator(tsoAllocator),
|
|
withMixCoord(qc))
|
|
gc := newBgGarbageCollector(core)
|
|
core.ddlTsLockManager = newDdlTsLockManager(tsoAllocator)
|
|
core.garbageCollector = gc
|
|
core.broker = newServerBroker(core)
|
|
|
|
gc.RemoveCreatingPartition(0, &model.Partition{}, 0)
|
|
<-signal
|
|
})
|
|
|
|
t.Run("test ReleasePartitions failed", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
|
|
ticker := newTickerWithMockNormalStream()
|
|
tsoAllocator := mocktso.NewAllocator(t)
|
|
|
|
signal := make(chan struct{}, 1)
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
|
|
qc := mocks.NewMixCoord(t)
|
|
qc.EXPECT().ReleasePartitions(mock.Anything, mock.Anything).
|
|
Return(merr.Success(), errors.New("mock err")).
|
|
Run(func(ctx context.Context, req *querypb.ReleasePartitionsRequest) {
|
|
signal <- struct{}{}
|
|
})
|
|
|
|
core := newTestCore(withTtSynchronizer(ticker),
|
|
withMeta(meta),
|
|
withTsoAllocator(tsoAllocator),
|
|
withMixCoord(qc))
|
|
gc := newBgGarbageCollector(core)
|
|
core.ddlTsLockManager = newDdlTsLockManager(tsoAllocator)
|
|
core.garbageCollector = gc
|
|
core.broker = newServerBroker(core)
|
|
|
|
gc.RemoveCreatingPartition(0, &model.Partition{}, 0)
|
|
<-signal
|
|
})
|
|
|
|
t.Run("test RemovePartition failed", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
|
|
ticker := newTickerWithMockNormalStream()
|
|
tsoAllocator := mocktso.NewAllocator(t)
|
|
|
|
signal := make(chan struct{}, 1)
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.EXPECT().RemovePartition(mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything).
|
|
Return(errors.New("mock err")).
|
|
Run(func(ctx context.Context, dbID, collectionID int64, partitionID int64, ts uint64) {
|
|
signal <- struct{}{}
|
|
})
|
|
|
|
qc := mocks.NewMixCoord(t)
|
|
qc.EXPECT().ReleasePartitions(mock.Anything, mock.Anything).Return(merr.Success(), nil)
|
|
|
|
core := newTestCore(withTtSynchronizer(ticker),
|
|
withMeta(meta),
|
|
withTsoAllocator(tsoAllocator),
|
|
withMixCoord(qc))
|
|
gc := newBgGarbageCollector(core)
|
|
core.ddlTsLockManager = newDdlTsLockManager(tsoAllocator)
|
|
core.garbageCollector = gc
|
|
core.broker = newServerBroker(core)
|
|
|
|
gc.RemoveCreatingPartition(0, &model.Partition{}, 0)
|
|
<-signal
|
|
})
|
|
}
|
|
|
|
func TestGcPartitionData(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
|
|
streamingutil.SetStreamingServiceEnabled()
|
|
defer streamingutil.UnsetStreamingServiceEnabled()
|
|
|
|
snmanager.ResetStreamingNodeManager()
|
|
b := mock_balancer.NewMockBalancer(t)
|
|
b.EXPECT().WatchChannelAssignments(mock.Anything, mock.Anything).RunAndReturn(
|
|
func(ctx context.Context, cb balancer.WatchChannelAssignmentsCallback) error {
|
|
<-ctx.Done()
|
|
return ctx.Err()
|
|
})
|
|
b.EXPECT().RegisterStreamingEnabledNotifier(mock.Anything).Run(func(notifier *syncutil.AsyncTaskNotifier[struct{}]) {
|
|
notifier.Cancel()
|
|
})
|
|
balance.Register(b)
|
|
|
|
wal := mock_streaming.NewMockWALAccesser(t)
|
|
broadcast := mock_streaming.NewMockBroadcast(t)
|
|
broadcast.EXPECT().Append(mock.Anything, mock.Anything).Return(&types.BroadcastAppendResult{
|
|
BroadcastID: 0,
|
|
AppendResults: map[string]*types.AppendResult{
|
|
"ch-0": {},
|
|
},
|
|
}, nil)
|
|
wal.EXPECT().Broadcast().Return(broadcast)
|
|
streaming.SetWALForTest(wal)
|
|
|
|
tsoAllocator := mocktso.NewAllocator(t)
|
|
core := newTestCore()
|
|
gc := newBgGarbageCollector(core)
|
|
core.ddlTsLockManager = newDdlTsLockManager(tsoAllocator)
|
|
|
|
_, err := gc.GcPartitionData(context.Background(), nil, []string{"ch-0", "ch-1"}, &model.Partition{})
|
|
assert.NoError(t, err)
|
|
}
|