Zhen Ye 8e0ae6433d
fix: LastConfirmedMessageID may be wrong if high concurrent writing (#45873)
issue: #45872

Signed-off-by: chyezh <chyezh@outlook.com>
2025-11-27 12:01:07 +08:00

85 lines
2.2 KiB
Go

package ack
import (
"github.com/milvus-io/milvus/pkg/v2/streaming/util/message"
"github.com/milvus-io/milvus/pkg/v2/util/typeutil"
)
var _ typeutil.HeapInterface = (*ackersOrderByTimestamp)(nil)
// Acker records the timestamp and last confirmed message id that has not been acknowledged.
type Acker struct {
acknowledged bool // is acknowledged.
detail *AckDetail // info is available after acknowledged.
manager *AckManager // the manager of the acker.
}
// LastConfirmedMessageID returns the last confirmed message id.
func (ta *Acker) LastConfirmedMessageID() message.MessageID {
return ta.detail.LastConfirmedMessageID
}
// Timestamp returns the timestamp.
func (ta *Acker) Timestamp() uint64 {
return ta.detail.BeginTimestamp
}
// Ack marks the timestamp as acknowledged.
func (ta *Acker) Ack(opts ...AckOption) {
for _, opt := range opts {
opt(ta.detail)
}
ta.manager.ack(ta)
}
// ackDetail returns the ack info, only can be called after acknowledged.
func (ta *Acker) ackDetail() *AckDetail {
if !ta.acknowledged {
panic("unreachable: ackDetail can only be called after acknowledged")
}
return ta.detail
}
// ackersOrderByTimestamp is a heap underlying represent of timestampAck.
type ackersOrderByTimestamp struct {
ackers
}
// Less returns true if the element at index i is less than the element at index j.
func (h ackersOrderByTimestamp) Less(i, j int) bool {
return h.ackers[i].detail.BeginTimestamp < h.ackers[j].detail.BeginTimestamp
}
// ackers is a heap underlying represent of timestampAck.
type ackers []*Acker
// Len returns the length of the heap.
func (h ackers) Len() int {
return len(h)
}
// Swap swaps the elements at indexes i and j.
func (h ackers) Swap(i, j int) { h[i], h[j] = h[j], h[i] }
// Push pushes the last one at len.
func (h *ackers) Push(x interface{}) {
// Push and Pop use pointer receivers because they modify the slice's length,
// not just its contents.
*h = append(*h, x.(*Acker))
}
// Pop pop the last one at len.
func (h *ackers) Pop() interface{} {
old := *h
n := len(old)
x := old[n-1]
old[n-1] = nil // release the memory of underlying array.
*h = old[0 : n-1]
return x
}
// Peek returns the element at the top of the heap.
func (h *ackers) Peek() interface{} {
return (*h)[0]
}