mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-03 17:31:58 +08:00
837ac295fa
Iterators are long deprecated, but sort are still using it. This PR unifies stats task with the latest compaction common functions and remove the usage of iterators. 1. Rename `datanode/compaction` to `datanode/compactor` 2. Add `internal/compaction` and move some compaction commons into it. 3. Replace `DeltalogIterators` with `ComposeDeleteFromDeltalogs` 4. Remove `datanode/iterators` See also: #39242 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
79 lines
2.2 KiB
Go
79 lines
2.2 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package compaction
|
|
|
|
import (
|
|
"context"
|
|
sio "io"
|
|
|
|
"go.uber.org/zap"
|
|
|
|
"github.com/milvus-io/milvus/internal/flushcommon/io"
|
|
"github.com/milvus-io/milvus/internal/storage"
|
|
"github.com/milvus-io/milvus/pkg/v2/log"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/typeutil"
|
|
)
|
|
|
|
func ComposeDeleteFromDeltalogs(ctx context.Context, io io.BinlogIO, paths []string) (map[interface{}]typeutil.Timestamp, error) {
|
|
pk2Ts := make(map[interface{}]typeutil.Timestamp)
|
|
|
|
log := log.Ctx(ctx)
|
|
if len(paths) == 0 {
|
|
log.Debug("input deltalog paths is empty, skip")
|
|
return pk2Ts, nil
|
|
}
|
|
|
|
blobs := make([]*storage.Blob, 0)
|
|
binaries, err := io.Download(ctx, paths)
|
|
if err != nil {
|
|
log.Warn("compose delete wrong, fail to download deltalogs",
|
|
zap.Strings("path", paths),
|
|
zap.Error(err))
|
|
return nil, err
|
|
}
|
|
|
|
for i := range binaries {
|
|
blobs = append(blobs, &storage.Blob{Value: binaries[i]})
|
|
}
|
|
reader, err := storage.CreateDeltalogReader(blobs)
|
|
if err != nil {
|
|
log.Error("compose delete wrong, malformed delta file", zap.Error(err))
|
|
return nil, err
|
|
}
|
|
defer reader.Close()
|
|
|
|
for {
|
|
err := reader.Next()
|
|
if err != nil {
|
|
if err == sio.EOF {
|
|
break
|
|
}
|
|
log.Error("compose delete wrong, failed to read deltalogs", zap.Error(err))
|
|
return nil, err
|
|
}
|
|
|
|
dl := reader.Value()
|
|
if ts, ok := pk2Ts[dl.Pk.GetValue()]; ok && ts > dl.Ts {
|
|
continue
|
|
}
|
|
pk2Ts[dl.Pk.GetValue()] = dl.Ts
|
|
}
|
|
|
|
log.Info("compose delete end", zap.Int("delete entries counts", len(pk2Ts)))
|
|
return pk2Ts, nil
|
|
}
|