congqixia 1414065860
feat: query coord support segment reopen when manifest path changes (#46394)
Related to #46358

Add segment reopen mechanism in QueryCoord to handle segment data
updates when the manifest path changes. This enables QueryNode to reload
segment data without full segment reload, supporting storage v2
incremental updates.

Changes:
- Add ActionTypeReopen action type and LoadScope_Reopen in protobuf
- Track ManifestPath in segment distribution metadata
- Add CheckSegmentDataReady utility to verify segment data matches
target
- Extend getSealedSegmentDiff to detect segments needing reopen
- Create segment reopen tasks when manifest path differs from target
- Block target update until segment data is ready

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-12-17 22:15:16 +08:00

277 lines
11 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package utils
import (
"context"
"fmt"
"time"
"github.com/blang/semver/v4"
"go.uber.org/zap"
"github.com/milvus-io/milvus/internal/querycoordv2/meta"
"github.com/milvus-io/milvus/internal/querycoordv2/session"
"github.com/milvus-io/milvus/pkg/v2/log"
"github.com/milvus-io/milvus/pkg/v2/proto/querypb"
"github.com/milvus-io/milvus/pkg/v2/util/merr"
"github.com/milvus-io/milvus/pkg/v2/util/paramtable"
)
func CheckNodeAvailable(nodeID int64, info *session.NodeInfo) error {
if info == nil {
return merr.WrapErrNodeOffline(nodeID)
}
return nil
}
// In a replica, a shard is available, if and only if:
// 1. The leader is online
// 2. All QueryNodes in the distribution are online
// 3. The last heartbeat response time is within HeartbeatAvailableInterval for all QueryNodes(include leader) in the distribution
// 4. All segments of the shard in target should be in the distribution
func CheckDelegatorDataReady(nodeMgr *session.NodeManager, targetMgr meta.TargetManagerInterface, leader *meta.LeaderView, scope int32) error {
log := log.Ctx(context.TODO()).
WithRateGroup(fmt.Sprintf("util.CheckDelegatorDataReady-%d", leader.CollectionID), 1, 60).
With(zap.Int64("leaderID", leader.ID), zap.Int64("collectionID", leader.CollectionID))
// Check whether leader is online
info := nodeMgr.Get(leader.ID)
if info == nil {
err := merr.WrapErrNodeOffline(leader.ID)
log.Info("leader is not available", zap.Error(err))
return fmt.Errorf("leader not available: %w", err)
}
segmentDist := targetMgr.GetSealedSegmentsByChannel(context.TODO(), leader.CollectionID, leader.Channel, scope)
// Check whether segments are fully loaded
for segmentID := range segmentDist {
version, exist := leader.Segments[segmentID]
if !exist {
log.RatedInfo(10, "leader is not available due to lack of segment", zap.Int64("segmentID", segmentID))
return merr.WrapErrSegmentLack(segmentID)
}
// Check whether segment's worker node is online
info := nodeMgr.Get(version.GetNodeID())
if info == nil {
err := merr.WrapErrNodeOffline(leader.ID)
log.Info("leader is not available due to QueryNode unavailable",
zap.Int64("segmentID", segmentID),
zap.Error(err))
return err
}
}
return nil
}
func CheckSegmentDataReady(ctx context.Context, collectionID int64, distManager *meta.DistributionManager, targetMgr meta.TargetManagerInterface, scope int32) error {
log := log.Ctx(ctx).
WithRateGroup(fmt.Sprintf("util.CheckSegmentDataReady-%d", collectionID), 1, 60).
With(zap.Int64("collectionID", collectionID))
// Check whether segments are fully loaded
segmentDist := targetMgr.GetSealedSegmentsByCollection(ctx, collectionID, scope)
for segmentID, segmentInfo := range segmentDist {
segments := distManager.SegmentDistManager.GetByFilter(meta.WithCollectionID(collectionID), meta.WithSegmentID(segmentID))
if len(segments) == 0 {
log.RatedInfo(10, "segment is not available", zap.Int64("segmentID", segmentID))
return merr.WrapErrSegmentLack(segmentID)
}
for _, segment := range segments {
// Compare manifest path for now
// alternative is to compare version, but it's not recommended to add extra info in segmentinfo
// we may use data view version in the future
if segment.ManifestPath != segmentInfo.GetManifestPath() {
log.RatedInfo(10, "segment is not updated", zap.Int64("segmentID", segmentID))
return merr.WrapErrSegmentNotLoaded(segmentID)
}
}
}
return nil
}
func checkLoadStatus(ctx context.Context, m *meta.Meta, collectionID int64) error {
percentage := m.CollectionManager.CalculateLoadPercentage(ctx, collectionID)
if percentage < 0 {
err := merr.WrapErrCollectionNotLoaded(collectionID)
log.Ctx(ctx).Warn("failed to GetShardLeaders", zap.Error(err))
return err
}
collection := m.CollectionManager.GetCollection(ctx, collectionID)
if collection != nil && collection.GetStatus() == querypb.LoadStatus_Loaded {
// when collection is loaded, regard collection as readable, set percentage == 100
percentage = 100
}
if percentage < 100 {
err := merr.WrapErrCollectionNotFullyLoaded(collectionID)
msg := fmt.Sprintf("collection %v is not fully loaded", collectionID)
log.Ctx(ctx).Warn(msg)
return err
}
return nil
}
func GetShardLeadersWithChannels(
ctx context.Context,
m *meta.Meta,
dist *meta.DistributionManager,
nodeMgr *session.NodeManager,
collectionID int64,
channels map[string]*meta.DmChannel,
withUnserviceableShards bool,
) ([]*querypb.ShardLeadersList, error) {
ret := make([]*querypb.ShardLeadersList, 0)
replicas := m.ReplicaManager.GetByCollection(ctx, collectionID)
for _, channel := range channels {
log := log.Ctx(ctx).With(zap.String("channel", channel.GetChannelName()))
ids := make([]int64, 0, len(replicas))
addrs := make([]string, 0, len(replicas))
serviceable := make([]bool, 0, len(replicas))
for _, replica := range replicas {
leader := dist.ChannelDistManager.GetShardLeader(channel.GetChannelName(), replica)
if leader == nil || (!withUnserviceableShards && !leader.IsServiceable()) {
log.WithRateGroup("util.GetShardLeaders", 1, 60).
Warn("leader is not available in replica", zap.String("channel", channel.GetChannelName()), zap.Int64("replicaID", replica.GetID()))
continue
}
info := nodeMgr.Get(leader.Node)
if info != nil {
ids = append(ids, info.ID())
addrs = append(addrs, info.Addr())
serviceable = append(serviceable, leader.IsServiceable())
}
}
if len(ids) == 0 && !withUnserviceableShards {
err := merr.WrapErrChannelNotAvailable(channel.GetChannelName())
msg := fmt.Sprintf("channel %s is not available in any replica", channel.GetChannelName())
log.Warn(msg, zap.Error(err))
return nil, err
}
ret = append(ret, &querypb.ShardLeadersList{
ChannelName: channel.GetChannelName(),
NodeIds: ids,
NodeAddrs: addrs,
Serviceable: serviceable,
})
}
return ret, nil
}
func GetShardLeaders(ctx context.Context,
m *meta.Meta,
targetMgr meta.TargetManagerInterface,
dist *meta.DistributionManager,
nodeMgr *session.NodeManager,
collectionID int64,
withUnserviceableShards bool,
) ([]*querypb.ShardLeadersList, error) {
// skip check load status if withUnserviceableShards is true
if err := checkLoadStatus(ctx, m, collectionID); err != nil {
return nil, err
}
channels := targetMgr.GetDmChannelsByCollection(ctx, collectionID, meta.CurrentTarget)
if len(channels) == 0 {
msg := "loaded collection do not found any channel in target, may be in recovery"
err := merr.WrapErrCollectionOnRecovering(collectionID, msg)
log.Ctx(ctx).Warn("failed to get channels", zap.Error(err))
return nil, err
}
return GetShardLeadersWithChannels(ctx, m, dist, nodeMgr, collectionID, channels, withUnserviceableShards)
}
// CheckCollectionsQueryable check all channels are watched and all segments are loaded for this collection
func CheckCollectionsQueryable(ctx context.Context, m *meta.Meta, targetMgr meta.TargetManagerInterface, dist *meta.DistributionManager, nodeMgr *session.NodeManager) error {
maxInterval := paramtable.Get().QueryCoordCfg.UpdateCollectionLoadStatusInterval.GetAsDuration(time.Minute)
for _, coll := range m.GetAllCollections(ctx) {
err := checkCollectionQueryable(ctx, m, targetMgr, dist, nodeMgr, coll)
// the collection is not queryable, if meet following conditions:
// 1. Some segments are not loaded
// 2. Collection is not starting to release
// 3. The load percentage has not been updated in the last 5 minutes.
if err != nil && m.Exist(ctx, coll.CollectionID) && time.Since(coll.UpdatedAt) >= maxInterval {
log.Ctx(ctx).Warn("collection not querable",
zap.Int64("collectionID", coll.CollectionID),
zap.Time("lastUpdated", coll.UpdatedAt),
zap.Duration("maxInterval", maxInterval),
zap.Error(err))
return err
}
}
return nil
}
// checkCollectionQueryable check all channels are watched and all segments are loaded for this collection
func checkCollectionQueryable(ctx context.Context, m *meta.Meta, targetMgr meta.TargetManagerInterface, dist *meta.DistributionManager, nodeMgr *session.NodeManager, coll *meta.Collection) error {
collectionID := coll.GetCollectionID()
if err := checkLoadStatus(ctx, m, collectionID); err != nil {
return err
}
channels := targetMgr.GetDmChannelsByCollection(ctx, collectionID, meta.CurrentTarget)
if len(channels) == 0 {
msg := "loaded collection do not found any channel in target, may be in recovery"
err := merr.WrapErrCollectionOnRecovering(collectionID, msg)
log.Ctx(ctx).Warn("failed to get channels", zap.Error(err))
return err
}
shardList, err := GetShardLeadersWithChannels(ctx, m, dist, nodeMgr, collectionID, channels, false)
if err != nil {
return err
}
if len(channels) != len(shardList) {
return merr.WrapErrCollectionNotFullyLoaded(collectionID, "still have unwatched channels or loaded segments")
}
return nil
}
// GetChannelRWAndRONodesFor260 gets the RW and RO nodes of the channel.
func GetChannelRWAndRONodesFor260(replica *meta.Replica, nodeManager *session.NodeManager) ([]int64, []int64) {
rwNodes, roNodes := replica.GetRWSQNodes(), replica.GetROSQNodes()
if rwQueryNodesLessThan260 := filterNodeLessThan260(replica.GetRWNodes(), nodeManager); len(rwQueryNodesLessThan260) > 0 {
// Add rwNodes to roNodes to balance channels from querynode to streamingnode forcely.
roNodes = append(roNodes, rwQueryNodesLessThan260...)
log.Debug("find querynode need to balance channel to streamingnode", zap.Int64s("rwQueryNodesLessThan260", rwQueryNodesLessThan260))
}
roNodes = append(roNodes, replica.GetRONodes()...)
return rwNodes, roNodes
}
// filterNodeLessThan260 filter the query nodes that version is less than 2.6.0
func filterNodeLessThan260(nodes []int64, nodeManager *session.NodeManager) []int64 {
checker := semver.MustParseRange(">=2.6.0-dev")
filteredNodes := make([]int64, 0)
for _, nodeID := range nodes {
if session := nodeManager.Get(nodeID); session != nil && checker(session.Version()) {
continue
}
filteredNodes = append(filteredNodes, nodeID)
}
return filteredNodes
}