milvus/internal/datanode/flow_graph_time_tick_node.go
congqixia 9a80dc666b
fix: flushTs is never reset in channelMeta (#29244)
See also #29156
FlushTs need to to be reset to MaxUint64 after channel checkpoint is
after this timestamp. Otherwise, the segment will be shattered and flush
queue will be filled with tasks

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-16 14:00:38 +08:00

147 lines
4.4 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package datanode
import (
"fmt"
"math"
"reflect"
"time"
"go.uber.org/atomic"
"go.uber.org/zap"
"github.com/milvus-io/milvus-proto/go-api/v2/msgpb"
"github.com/milvus-io/milvus/internal/datanode/broker"
"github.com/milvus-io/milvus/internal/util/flowgraph"
"github.com/milvus-io/milvus/pkg/log"
"github.com/milvus-io/milvus/pkg/util/tsoutil"
)
// make sure ttNode implements flowgraph.Node
var _ flowgraph.Node = (*ttNode)(nil)
type ttNode struct {
BaseNode
vChannelName string
channel Channel
lastUpdateTime *atomic.Time
broker broker.Broker
cpUpdater *channelCheckpointUpdater
dropMode *atomic.Bool
}
// Name returns node name, implementing flowgraph.Node
func (ttn *ttNode) Name() string {
return fmt.Sprintf("ttNode-%s", ttn.vChannelName)
}
func (ttn *ttNode) IsValidInMsg(in []Msg) bool {
if !ttn.BaseNode.IsValidInMsg(in) {
return false
}
_, ok := in[0].(*flowGraphMsg)
if !ok {
log.Warn("type assertion failed for flowGraphMsg", zap.String("name", reflect.TypeOf(in[0]).Name()))
return false
}
return true
}
func (ttn *ttNode) Close() {
}
// Operate handles input messages, implementing flowgraph.Node
func (ttn *ttNode) Operate(in []Msg) []Msg {
fgMsg := in[0].(*flowGraphMsg)
if fgMsg.dropCollection {
ttn.dropMode.Store(true)
}
// skip updating checkpoint for drop collection
// even if its the close msg
if ttn.dropMode.Load() {
log.RatedInfo(1.0, "ttnode in dropMode", zap.String("channel", ttn.vChannelName))
return []Msg{}
}
curTs, _ := tsoutil.ParseTS(fgMsg.timeRange.timestampMax)
if fgMsg.IsCloseMsg() {
if len(fgMsg.endPositions) > 0 {
channelPos := ttn.channel.getChannelCheckpoint(fgMsg.endPositions[0])
log.Info("flowgraph is closing, force update channel CP",
zap.Time("cpTs", tsoutil.PhysicalTime(channelPos.GetTimestamp())),
zap.String("channel", channelPos.GetChannelName()))
ttn.updateChannelCP(channelPos, curTs)
}
return in
}
// Do not block and async updateCheckPoint
channelPos := ttn.channel.getChannelCheckpoint(fgMsg.endPositions[0])
nonBlockingNotify := func() {
ttn.updateChannelCP(channelPos, curTs)
}
if curTs.Sub(ttn.lastUpdateTime.Load()) >= updateChanCPInterval {
nonBlockingNotify()
return []Msg{}
}
if channelPos.GetTimestamp() >= ttn.channel.getFlushTs() {
nonBlockingNotify()
}
return []Msg{}
}
func (ttn *ttNode) updateChannelCP(channelPos *msgpb.MsgPosition, curTs time.Time) error {
callBack := func() error {
channelCPTs, _ := tsoutil.ParseTS(channelPos.GetTimestamp())
ttn.lastUpdateTime.Store(curTs)
log.Debug("UpdateChannelCheckpoint success",
zap.String("channel", ttn.vChannelName),
zap.Uint64("cpTs", channelPos.GetTimestamp()),
zap.Time("cpTime", channelCPTs))
// channelPos ts > flushTs means we could stop flush.
if channelPos.GetTimestamp() >= ttn.channel.getFlushTs() {
ttn.channel.setFlushTs(math.MaxUint64)
}
return nil
}
err := ttn.cpUpdater.updateChannelCP(channelPos, callBack)
return err
}
func newTTNode(config *nodeConfig, broker broker.Broker, cpUpdater *channelCheckpointUpdater) (*ttNode, error) {
baseNode := BaseNode{}
baseNode.SetMaxQueueLength(Params.DataNodeCfg.FlowGraphMaxQueueLength.GetAsInt32())
baseNode.SetMaxParallelism(Params.DataNodeCfg.FlowGraphMaxParallelism.GetAsInt32())
tt := &ttNode{
BaseNode: baseNode,
vChannelName: config.vChannelName,
channel: config.channel,
lastUpdateTime: atomic.NewTime(time.Time{}), // set to Zero to update channel checkpoint immediately after fg started
broker: broker,
cpUpdater: cpUpdater,
dropMode: atomic.NewBool(false),
}
return tt, nil
}