milvus/internal/querynodev2/segments/state/load_state_lock_test.go
chyezh 73adf2a5cc
fix: use stateful lock to avoid load and release on LocalSegment concurrently (#31606)
issue: #31605

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2024-04-08 17:09:16 +08:00

225 lines
4.8 KiB
Go

package state
import (
"testing"
"time"
"github.com/cockroachdb/errors"
"github.com/stretchr/testify/assert"
)
func TestLoadStateLoadData(t *testing.T) {
l := NewLoadStateLock(LoadStateOnlyMeta)
// Test Load Data, roll back
g, err := l.StartLoadData()
assert.NoError(t, err)
assert.NotNil(t, g)
assert.Equal(t, LoadStateDataLoading, l.state)
g.Done(errors.New("test"))
assert.Equal(t, LoadStateOnlyMeta, l.state)
// Test Load Data, success
g, err = l.StartLoadData()
assert.NoError(t, err)
assert.NotNil(t, g)
assert.Equal(t, LoadStateDataLoading, l.state)
g.Done(nil)
assert.Equal(t, LoadStateDataLoaded, l.state)
// nothing to do with loaded.
g, err = l.StartLoadData()
assert.NoError(t, err)
assert.Nil(t, g)
for _, s := range []loadStateEnum{
LoadStateDataLoading,
LoadStateDataReleasing,
LoadStateReleased,
} {
l.state = s
g, err = l.StartLoadData()
assert.Error(t, err)
assert.Nil(t, g)
}
}
func TestStartReleaseData(t *testing.T) {
l := NewLoadStateLock(LoadStateOnlyMeta)
// Test Release Data, nothing to do on only meta.
g := l.StartReleaseData()
assert.Nil(t, g)
assert.Equal(t, LoadStateOnlyMeta, l.state)
// roll back
// never roll back on current using.
l.state = LoadStateDataLoaded
g = l.StartReleaseData()
assert.Equal(t, LoadStateDataReleasing, l.state)
assert.NotNil(t, g)
g.Done(errors.New("test"))
assert.Equal(t, LoadStateDataLoaded, l.state)
// success
l.state = LoadStateDataLoaded
g = l.StartReleaseData()
assert.Equal(t, LoadStateDataReleasing, l.state)
assert.NotNil(t, g)
g.Done(nil)
assert.Equal(t, LoadStateOnlyMeta, l.state)
// nothing to do on released
l.state = LoadStateReleased
g = l.StartReleaseData()
assert.Nil(t, g)
// test blocking.
l.state = LoadStateOnlyMeta
g, err := l.StartLoadData()
assert.NoError(t, err)
ch := make(chan struct{})
go func() {
g := l.StartReleaseData()
assert.NotNil(t, g)
g.Done(nil)
close(ch)
}()
// should be blocked because on loading.
select {
case <-ch:
t.Errorf("should be blocked")
case <-time.After(500 * time.Millisecond):
}
// loaded finished.
g.Done(nil)
// release can be started.
select {
case <-ch:
case <-time.After(500 * time.Millisecond):
t.Errorf("should not be blocked")
}
assert.Equal(t, LoadStateOnlyMeta, l.state)
}
func TestStartReleaseAll(t *testing.T) {
l := NewLoadStateLock(LoadStateOnlyMeta)
// Test Release All, nothing to do on only meta.
g := l.StartReleaseAll()
assert.NotNil(t, g)
assert.Equal(t, LoadStateReleased, l.state)
g.Done(nil)
assert.Equal(t, LoadStateReleased, l.state)
// roll back
// never roll back on current using.
l.state = LoadStateDataLoaded
g = l.StartReleaseData()
assert.Equal(t, LoadStateDataReleasing, l.state)
assert.NotNil(t, g)
g.Done(errors.New("test"))
assert.Equal(t, LoadStateDataLoaded, l.state)
// success
l.state = LoadStateDataLoaded
g = l.StartReleaseAll()
assert.Equal(t, LoadStateReleased, l.state)
assert.NotNil(t, g)
g.Done(nil)
assert.Equal(t, LoadStateReleased, l.state)
// nothing to do on released
l.state = LoadStateReleased
g = l.StartReleaseAll()
assert.Nil(t, g)
// test blocking.
l.state = LoadStateOnlyMeta
g, err := l.StartLoadData()
assert.NoError(t, err)
ch := make(chan struct{})
go func() {
g := l.StartReleaseAll()
assert.NotNil(t, g)
g.Done(nil)
close(ch)
}()
// should be blocked because on loading.
select {
case <-ch:
t.Errorf("should be blocked")
case <-time.After(500 * time.Millisecond):
}
// loaded finished.
g.Done(nil)
// release can be started.
select {
case <-ch:
case <-time.After(500 * time.Millisecond):
t.Errorf("should not be blocked")
}
assert.Equal(t, LoadStateReleased, l.state)
}
func TestRLock(t *testing.T) {
l := NewLoadStateLock(LoadStateOnlyMeta)
assert.True(t, l.RLockIf(IsNotReleased))
l.RUnlock()
assert.False(t, l.RLockIf(IsDataLoaded))
l = NewLoadStateLock(LoadStateDataLoaded)
assert.True(t, l.RLockIf(IsNotReleased))
l.RUnlock()
assert.True(t, l.RLockIf(IsDataLoaded))
l.RUnlock()
l = NewLoadStateLock(LoadStateOnlyMeta)
l.StartReleaseAll().Done(nil)
assert.False(t, l.RLockIf(IsNotReleased))
assert.False(t, l.RLockIf(IsDataLoaded))
}
func TestPin(t *testing.T) {
l := NewLoadStateLock(LoadStateOnlyMeta)
assert.True(t, l.PinIfNotReleased())
l.Unpin()
l.StartReleaseAll().Done(nil)
assert.False(t, l.PinIfNotReleased())
l = NewLoadStateLock(LoadStateDataLoaded)
assert.True(t, l.PinIfNotReleased())
ch := make(chan struct{})
go func() {
l.StartReleaseAll().Done(nil)
close(ch)
}()
select {
case <-ch:
t.Errorf("should be blocked")
case <-time.After(500 * time.Millisecond):
}
// should be blocked until refcnt is zero.
assert.True(t, l.PinIfNotReleased())
l.Unpin()
select {
case <-ch:
t.Errorf("should be blocked")
case <-time.After(500 * time.Millisecond):
}
l.Unpin()
<-ch
assert.Panics(t, func() {
// too much unpin
l.Unpin()
})
}