mirror of
https://gitee.com/milvus-io/milvus.git
synced 2026-01-07 19:31:51 +08:00
bb913dd837
issue: #46500 - simplify the run_go_codecov.sh to make sure the set -e to protect any sub command failure. - remove all embed etcd in test to make full test can be run at local. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## PR Summary: Simplify Go Unit Tests by Removing Embedded etcd and Async Startup Scaffolding **Core Invariant:** This PR assumes that unit tests can be simplified by running without embedded etcd servers (delegating to environment-based or external etcd instances via `kvfactory.GetEtcdAndPath()` or `ETCD_ENDPOINTS`) and by removing goroutine-based async startup scaffolding in favor of synchronous component initialization. Tests remain functionally equivalent while becoming simpler to run and debug locally. **What is Removed or Simplified:** 1. **Embedded etcd test infrastructure deleted**: Removes `EmbedEtcdUtil` type and its public methods (SetupEtcd, TearDownEmbedEtcd) from `pkg/util/testutils/embed_etcd.go`, removes the `StartTestEmbedEtcdServer()` helper from `pkg/util/etcd/etcd_util.go`, and removes etcd embedding from test suites (e.g., `TaskSuite`, `EtcdSourceSuite`, `mixcoord/client_test.go`). Tests now either skip etcd-dependent tests (via `MILVUS_UT_WITHOUT_KAFKA=1` environment flag in `kafka_test.go`) or source etcd from external configuration (via `kvfactory.GetEtcdAndPath()` in `task_test.go`, or `ETCD_ENDPOINTS` environment variable in `etcd_source_test.go`). This eliminates the overhead of spinning up temporary etcd servers for unit tests. 2. **Async startup scaffolding replaced with synchronous initialization**: In `internal/proxy/proxy_test.go` and `proxy_rpc_test.go`, the `startGrpc()` method signature removes the `sync.WaitGroup` parameter; components are now created, prepared, and run synchronously in-place rather than in goroutines (e.g., `go testServer.startGrpc(ctx, &p)` becomes `testServer.startGrpc(ctx, &p)` running synchronously). Readiness checks (e.g., `waitForGrpcReady()`) remain in place to ensure startup safety without concurrency constructs. This simplifies control flow and reduces debugging complexity. 3. **Shell script orchestration unified with proper error handling**: In `scripts/run_go_codecov.sh` and `scripts/run_intergration_test.sh`, per-package inline test invocations are consolidated into a single `test_cmd()` function with unified `TEST_CMD_WITH_ARGS` array containing race, coverage, verbose, and other flags. The problematic `set -ex` is replaced with `set -e` alone (removing debug output noise while preserving strict error semantics), ensuring the scripts fail fast on any command failure. **Why No Regression:** - Test assertions and code paths remain unchanged; only deployment source of etcd (embedded → external) and startup orchestration (async → sync) change. - Readiness verification (e.g., `waitForGrpcReady()`) is retained, ensuring components are initialized before test execution. - Test flags (race detection, coverage, verbosity) are uniformly applied across all packages via unified `TEST_CMD_WITH_ARGS`, preserving test coverage and quality. - `set -e` alone is sufficient for strict failure detection without the `-x` flag's verbose output. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: chyezh <chyezh@outlook.com>
78 lines
2.2 KiB
Bash
Executable File
78 lines
2.2 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# Licensed to the LF AI & Data foundation under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
# run integration test
|
|
echo "Running integration test under ./tests/integration"
|
|
|
|
FILE_COVERAGE_INFO="it_coverage.txt"
|
|
BASEDIR=$(dirname "$0")
|
|
source $BASEDIR/setenv.sh
|
|
|
|
set -e
|
|
|
|
echo "mode: atomic" > ${FILE_COVERAGE_INFO}
|
|
echo "MILVUS_WORK_DIR: $MILVUS_WORK_DIR"
|
|
|
|
TEST_CMD=$@
|
|
if [ -z "$TEST_CMD" ]; then
|
|
TEST_CMD="go test"
|
|
fi
|
|
|
|
TEST_CMD_WITH_ARGS=(
|
|
$TEST_CMD
|
|
"-gcflags=all=-N -l"
|
|
-race
|
|
-tags dynamic,test
|
|
-v
|
|
-failfast
|
|
-count=1
|
|
-buildvcs=false
|
|
-coverpkg=./...
|
|
-coverprofile=profile.out
|
|
-covermode=atomic
|
|
-caseTimeout=20m
|
|
-timeout=60m
|
|
)
|
|
|
|
function test_cmd() {
|
|
mapfile -t PKGS < <(go list -tags dynamic,test ./...)
|
|
for pkg in "${PKGS[@]}"; do
|
|
echo -e "-----------------------------------\nRunning test cases at $pkg ..."
|
|
"${TEST_CMD_WITH_ARGS[@]}" "$pkg"
|
|
if [ -f profile.out ]; then
|
|
# Skip the per-profile header to keep a single global "mode:" line
|
|
# Skip the packages that are not covered by the test
|
|
sed '1{/^mode:/d}' profile.out | grep -vE '(planparserv2/generated|mocks)' >> "${FILE_COVERAGE_INFO}" || [ $? -eq 1 ]
|
|
rm profile.out
|
|
fi
|
|
echo -e "-----------------------------------\n"
|
|
done
|
|
}
|
|
|
|
beginTime=`date +%s`
|
|
printf "=== Running integration test ===\n\n"
|
|
|
|
for d in tests/integration; do
|
|
pushd "$d"
|
|
test_cmd
|
|
popd
|
|
done
|
|
|
|
endTime=`date +%s`
|
|
printf "=== Total time for go integration test: $(($endTime-$beginTime)) s==="
|