yihao.dai 142bd2fc05
enhance: Pooling for data tasks (#41256)
1. Add global scheduler for datacoord.
2. Define and implement new CreateTask, QueryTask, DropTask interfaces.
3. Refine Import, Compaction, Stats, Index task.

issue: https://github.com/milvus-io/milvus/issues/41123

Co-authored-by: Cai Zhang <cai.zhang@zilliz.com>
2025-05-20 21:06:24 +08:00

290 lines
8.1 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package grpcdatanodeclient
import (
"context"
"testing"
"github.com/cockroachdb/errors"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"google.golang.org/grpc"
"github.com/milvus-io/milvus/internal/mocks"
mock2 "github.com/milvus-io/milvus/internal/util/mock"
"github.com/milvus-io/milvus/pkg/v2/proto/internalpb"
"github.com/milvus-io/milvus/pkg/v2/proto/workerpb"
"github.com/milvus-io/milvus/pkg/v2/util/metricsinfo"
"github.com/milvus-io/milvus/pkg/v2/util/paramtable"
)
func Test_NewClient(t *testing.T) {
paramtable.Init()
ctx := context.Background()
client, err := NewClient(ctx, "", 1, false)
assert.Nil(t, client)
assert.Error(t, err)
client, err = NewClient(ctx, "test", 2, false)
assert.NoError(t, err)
assert.NotNil(t, client)
checkFunc := func(retNotNil bool) {
retCheck := func(notNil bool, ret interface{}, err error) {
if notNil {
assert.NotNil(t, ret)
assert.NoError(t, err)
} else {
assert.Nil(t, ret)
assert.Error(t, err)
}
}
r1, err := client.GetComponentStates(ctx, nil)
retCheck(retNotNil, r1, err)
r2, err := client.GetStatisticsChannel(ctx, nil)
retCheck(retNotNil, r2, err)
r3, err := client.WatchDmChannels(ctx, nil)
retCheck(retNotNil, r3, err)
r4, err := client.FlushSegments(ctx, nil)
retCheck(retNotNil, r4, err)
r5, err := client.GetMetrics(ctx, nil)
retCheck(retNotNil, r5, err)
r6, err := client.CompactionV2(ctx, nil)
retCheck(retNotNil, r6, err)
r8, err := client.ResendSegmentStats(ctx, nil)
retCheck(retNotNil, r8, err)
r10, err := client.ShowConfigurations(ctx, nil)
retCheck(retNotNil, r10, err)
r11, err := client.GetCompactionState(ctx, nil)
retCheck(retNotNil, r11, err)
r12, err := client.NotifyChannelOperation(ctx, nil)
retCheck(retNotNil, r12, err)
r13, err := client.CheckChannelOperationProgress(ctx, nil)
retCheck(retNotNil, r13, err)
r14, err := client.DropCompactionPlan(ctx, nil)
retCheck(retNotNil, r14, err)
r15, err := client.CreateTask(ctx, nil)
retCheck(retNotNil, r15, err)
r16, err := client.QueryTask(ctx, nil)
retCheck(retNotNil, r16, err)
r17, err := client.DropTask(ctx, nil)
retCheck(retNotNil, r17, err)
}
client.(*Client).grpcClient = &mock2.GRPCClientBase[DataNodeClient]{
GetGrpcClientErr: errors.New("dummy"),
}
newFunc1 := func(cc *grpc.ClientConn) DataNodeClient {
return DataNodeClient{
DataNodeClient: &mock2.GrpcDataNodeClient{Err: nil},
IndexNodeClient: &mock2.GrpcDataNodeClient{Err: nil},
}
}
client.(*Client).grpcClient.SetNewGrpcClientFunc(newFunc1)
checkFunc(false)
client.(*Client).grpcClient = &mock2.GRPCClientBase[DataNodeClient]{
GetGrpcClientErr: nil,
}
newFunc2 := func(cc *grpc.ClientConn) DataNodeClient {
return DataNodeClient{
DataNodeClient: &mock2.GrpcDataNodeClient{Err: errors.New("dummy")},
IndexNodeClient: &mock2.GrpcDataNodeClient{Err: errors.New("dummy")},
}
}
client.(*Client).grpcClient.SetNewGrpcClientFunc(newFunc2)
checkFunc(false)
client.(*Client).grpcClient = &mock2.GRPCClientBase[DataNodeClient]{
GetGrpcClientErr: nil,
}
newFunc3 := func(cc *grpc.ClientConn) DataNodeClient {
return DataNodeClient{
DataNodeClient: &mock2.GrpcDataNodeClient{Err: nil},
IndexNodeClient: &mock2.GrpcDataNodeClient{Err: nil},
}
}
client.(*Client).grpcClient.SetNewGrpcClientFunc(newFunc3)
checkFunc(true)
err = client.Close()
assert.NoError(t, err)
}
func TestIndexClient(t *testing.T) {
paramtable.Init()
ctx := context.Background()
client, err := NewClient(ctx, "localhost:1234", 1, false)
assert.NoError(t, err)
assert.NotNil(t, client)
mockIN := mocks.NewMockDataNodeClient(t)
mockDN := mocks.NewMockDataNodeClient(t)
mockNode := DataNodeClient{
DataNodeClient: mockDN,
IndexNodeClient: mockIN,
}
mockGrpcClient := mocks.NewMockGrpcClient[DataNodeClient](t)
mockGrpcClient.EXPECT().Close().Return(nil)
mockGrpcClient.EXPECT().ReCall(mock.Anything, mock.Anything).
RunAndReturn(func(ctx context.Context, f func(nodeClient DataNodeClient) (interface{}, error)) (interface{}, error) {
return f(mockNode)
})
client.(*Client).grpcClient = mockGrpcClient
t.Run("GetComponentStates", func(t *testing.T) {
mockDN.EXPECT().GetComponentStates(mock.Anything, mock.Anything).Return(nil, nil)
_, err := client.GetComponentStates(ctx, nil)
assert.NoError(t, err)
})
t.Run("GetStatisticsChannel", func(t *testing.T) {
mockDN.EXPECT().GetStatisticsChannel(mock.Anything, mock.Anything).Return(nil, nil)
_, err := client.GetStatisticsChannel(ctx, nil)
assert.NoError(t, err)
})
t.Run("CreatJob", func(t *testing.T) {
mockIN.EXPECT().CreateJob(mock.Anything, mock.Anything).Return(nil, nil)
req := &workerpb.CreateJobRequest{
ClusterID: "0",
BuildID: 0,
}
_, err := client.CreateJob(ctx, req)
assert.NoError(t, err)
})
t.Run("QueryJob", func(t *testing.T) {
mockIN.EXPECT().QueryJobs(mock.Anything, mock.Anything).Return(nil, nil)
req := &workerpb.QueryJobsRequest{}
_, err := client.QueryJobs(ctx, req)
assert.NoError(t, err)
})
t.Run("DropJob", func(t *testing.T) {
mockIN.EXPECT().DropJobs(mock.Anything, mock.Anything).Return(nil, nil)
req := &workerpb.DropJobsRequest{}
_, err := client.DropJobs(ctx, req)
assert.NoError(t, err)
})
t.Run("ShowConfigurations", func(t *testing.T) {
mockDN.EXPECT().ShowConfigurations(mock.Anything, mock.Anything).Return(nil, nil)
req := &internalpb.ShowConfigurationsRequest{
Pattern: "",
}
_, err := client.ShowConfigurations(ctx, req)
assert.NoError(t, err)
})
t.Run("GetMetrics", func(t *testing.T) {
mockDN.EXPECT().GetMetrics(mock.Anything, mock.Anything).Return(nil, nil)
req, err := metricsinfo.ConstructRequestByMetricType(metricsinfo.SystemInfoMetrics)
assert.NoError(t, err)
_, err = client.GetMetrics(ctx, req)
assert.NoError(t, err)
})
t.Run("GetJobStats", func(t *testing.T) {
mockIN.EXPECT().GetJobStats(mock.Anything, mock.Anything).Return(nil, nil)
req := &workerpb.GetJobStatsRequest{}
_, err := client.GetJobStats(ctx, req)
assert.NoError(t, err)
})
t.Run("CreateJobV2", func(t *testing.T) {
mockIN.EXPECT().CreateJobV2(mock.Anything, mock.Anything).Return(nil, nil)
req := &workerpb.CreateJobV2Request{}
_, err := client.CreateJobV2(ctx, req)
assert.NoError(t, err)
})
t.Run("QueryJobsV2", func(t *testing.T) {
mockIN.EXPECT().QueryJobsV2(mock.Anything, mock.Anything).Return(nil, nil)
req := &workerpb.QueryJobsV2Request{}
_, err := client.QueryJobsV2(ctx, req)
assert.NoError(t, err)
})
t.Run("DropJobsV2", func(t *testing.T) {
mockIN.EXPECT().DropJobsV2(mock.Anything, mock.Anything).Return(nil, nil)
req := &workerpb.DropJobsV2Request{}
_, err := client.DropJobsV2(ctx, req)
assert.NoError(t, err)
})
t.Run("CreateTask", func(t *testing.T) {
mockIN.EXPECT().CreateTask(mock.Anything, mock.Anything).Return(nil, nil)
req := &workerpb.CreateTaskRequest{}
_, err := client.CreateTask(ctx, req)
assert.NoError(t, err)
})
t.Run("QueryTask", func(t *testing.T) {
mockIN.EXPECT().QueryTask(mock.Anything, mock.Anything).Return(nil, nil)
req := &workerpb.QueryTaskRequest{}
_, err := client.QueryTask(ctx, req)
assert.NoError(t, err)
})
t.Run("DropTask", func(t *testing.T) {
mockIN.EXPECT().DropTask(mock.Anything, mock.Anything).Return(nil, nil)
req := &workerpb.DropTaskRequest{}
_, err := client.DropTask(ctx, req)
assert.NoError(t, err)
})
err = client.Close()
assert.NoError(t, err)
}