mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-07 09:38:39 +08:00
02e2170601
issue: #43897, #44123 pr: #45224 also pick pr: #45216,#45154,#45033,#45145,#45092,#45058,#45029 enhance: Close channel replicator more gracefully (#45029) issue: https://github.com/milvus-io/milvus/issues/44123 enhance: Show create time for import job (#45058) issue: https://github.com/milvus-io/milvus/issues/45056 fix: wal state may be unconsistent after recovering from crash (#45092) issue: #45088, #45086 - Message on control channel should trigger the checkpoint update. - LastConfrimedMessageID should be recovered from the minimum of checkpoint or the LastConfirmedMessageID of uncommitted txn. - Add more log info for wal debugging. fix: make ack of broadcaster cannot canceled by client (#45145) issue: #45141 - make ack of broadcaster cannot canceled by rpc. - make clone for assignment snapshot of wal balancer. - add server id for GetReplicateCheckpoint to avoid failure. enhance: support collection and index with WAL-based DDL framework (#45033) issue: #43897 - Part of collection/index related DDL is implemented by WAL-based DDL framework now. - Support following message type in wal, CreateCollection, DropCollection, CreatePartition, DropPartition, CreateIndex, AlterIndex, DropIndex. - Part of collection/index related DDL can be synced by new CDC now. - Refactor some UT for collection/index DDL. - Add Tombstone scheduler to manage the tombstone GC for collection or partition meta. - Move the vchannel allocation into streaming pchannel manager. enhance: support load/release collection/partition with WAL-based DDL framework (#45154) issue: #43897 - Load/Release collection/partition is implemented by WAL-based DDL framework now. - Support AlterLoadConfig/DropLoadConfig in wal now. - Load/Release operation can be synced by new CDC now. - Refactor some UT for load/release DDL. enhance: Don't start cdc by default (#45216) issue: https://github.com/milvus-io/milvus/issues/44123 fix: unrecoverable when replicate from old (#45224) issue: #44962 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com> Signed-off-by: chyezh <chyezh@outlook.com> Co-authored-by: yihao.dai <yihao.dai@zilliz.com>
94 lines
2.5 KiB
Go
94 lines
2.5 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package tombstone
|
|
|
|
import (
|
|
"context"
|
|
"math/rand"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
"github.com/stretchr/testify/assert"
|
|
"go.uber.org/atomic"
|
|
|
|
"github.com/milvus-io/milvus/pkg/v2/util/syncutil"
|
|
)
|
|
|
|
func TestTombstoneSweeper_AddTombstone(t *testing.T) {
|
|
sweeper := NewTombstoneSweeper()
|
|
sweeper.Close()
|
|
|
|
sweeperImpl := &tombstoneSweeperImpl{
|
|
notifier: syncutil.NewAsyncTaskNotifier[struct{}](),
|
|
incoming: make(chan Tombstone),
|
|
tombstones: make(map[string]Tombstone),
|
|
interval: 1 * time.Millisecond,
|
|
}
|
|
go sweeperImpl.background()
|
|
|
|
testTombstone := &testTombstoneImpl{
|
|
id: "test",
|
|
confirmed: atomic.NewBool(false),
|
|
canRemove: atomic.NewBool(false),
|
|
removed: atomic.NewBool(false),
|
|
}
|
|
|
|
sweeperImpl.AddTombstone(testTombstone)
|
|
|
|
time.Sleep(5 * time.Millisecond)
|
|
assert.False(t, testTombstone.removed.Load())
|
|
|
|
testTombstone.confirmed.Store(true)
|
|
time.Sleep(5 * time.Millisecond)
|
|
assert.False(t, testTombstone.removed.Load())
|
|
|
|
testTombstone.canRemove.Store(true)
|
|
assert.Eventually(t, func() bool {
|
|
return testTombstone.removed.Load()
|
|
}, 100*time.Millisecond, 10*time.Millisecond)
|
|
|
|
sweeperImpl.Close()
|
|
assert.Len(t, sweeperImpl.tombstones, 0)
|
|
}
|
|
|
|
type testTombstoneImpl struct {
|
|
id string
|
|
confirmed *atomic.Bool
|
|
canRemove *atomic.Bool
|
|
removed *atomic.Bool
|
|
}
|
|
|
|
func (t *testTombstoneImpl) ID() string {
|
|
return t.id
|
|
}
|
|
|
|
func (t *testTombstoneImpl) ConfirmCanBeRemoved(ctx context.Context) (bool, error) {
|
|
if rand.Intn(2) == 0 {
|
|
return false, errors.New("fail to confirm")
|
|
}
|
|
return t.confirmed.Load(), nil
|
|
}
|
|
|
|
func (t *testTombstoneImpl) Remove(ctx context.Context) error {
|
|
if !t.canRemove.Load() {
|
|
return errors.New("tombstone can not be removed")
|
|
}
|
|
t.removed.Store(true)
|
|
return nil
|
|
}
|