Zhen Ye 309d564796
enhance: support collection and index with WAL-based DDL framework (#45033)
issue: #43897

- Part of collection/index related DDL is implemented by WAL-based DDL
framework now.
- Support following message type in wal, CreateCollection,
DropCollection, CreatePartition, DropPartition, CreateIndex, AlterIndex,
DropIndex.
- Part of collection/index related DDL can be synced by new CDC now.
- Refactor some UT for collection/index DDL.
- Add Tombstone scheduler to manage the tombstone GC for collection or
partition meta.
- Move the vchannel allocation into streaming pchannel manager.

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2025-10-30 14:24:08 +08:00

122 lines
3.7 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package tombstone
import (
"context"
"time"
"go.uber.org/zap"
"github.com/milvus-io/milvus/pkg/v2/log"
"github.com/milvus-io/milvus/pkg/v2/util/syncutil"
"github.com/milvus-io/milvus/pkg/v2/util/typeutil"
)
// NewTombstoneSweeper creates a new tombstone sweeper.
// It will start a background goroutine to sweep the tombstones periodically.
// Once the tombstone is safe to be removed, it will be removed by the background goroutine.
func NewTombstoneSweeper() TombstoneSweeper {
ts := &tombstoneSweeperImpl{
notifier: syncutil.NewAsyncTaskNotifier[struct{}](),
incoming: make(chan Tombstone),
tombstones: make(map[string]Tombstone),
interval: 5 * time.Minute,
}
ts.SetLogger(log.With(log.FieldModule(typeutil.RootCoordRole), log.FieldComponent("tombstone_sweeper")))
go ts.background()
return ts
}
// TombstoneSweeper is a sweeper for the tombstones.
type tombstoneSweeperImpl struct {
log.Binder
notifier *syncutil.AsyncTaskNotifier[struct{}]
incoming chan Tombstone
tombstones map[string]Tombstone
interval time.Duration
// TODO: add metrics for the tombstone sweeper.
}
// AddTombstone adds a tombstone to the sweeper.
func (s *tombstoneSweeperImpl) AddTombstone(tombstone Tombstone) {
select {
case <-s.notifier.Context().Done():
case s.incoming <- tombstone:
}
}
func (s *tombstoneSweeperImpl) background() {
defer func() {
s.notifier.Finish(struct{}{})
s.Logger().Info("tombstone sweeper background exit")
}()
s.Logger().Info("tombstone sweeper background start", zap.Duration("interval", s.interval))
ticker := time.NewTicker(s.interval)
defer ticker.Stop()
for {
select {
case tombstone := <-s.incoming:
if _, ok := s.tombstones[tombstone.ID()]; !ok {
s.tombstones[tombstone.ID()] = tombstone
s.Logger().Info("tombstone added", zap.String("tombstone", tombstone.ID()))
}
case <-ticker.C:
s.triggerGCTombstone(s.notifier.Context())
case <-s.notifier.Context().Done():
return
}
}
}
// triggerGCTombstone triggers the garbage collection of the tombstones.
func (s *tombstoneSweeperImpl) triggerGCTombstone(ctx context.Context) {
if len(s.tombstones) == 0 {
return
}
for _, tombstone := range s.tombstones {
if ctx.Err() != nil {
// The tombstone sweeper is closing, stop it.
return
}
tombstoneID := tombstone.ID()
confirmed, err := tombstone.ConfirmCanBeRemoved(ctx)
if err != nil {
s.Logger().Warn("fail to confirm if tombstone can be removed", zap.String("tombstone", tombstoneID), zap.Error(err))
continue
}
if !confirmed {
continue
}
if err := tombstone.Remove(ctx); err != nil {
s.Logger().Warn("fail to remove tombstone", zap.String("tombstone", tombstoneID), zap.Error(err))
continue
}
delete(s.tombstones, tombstoneID)
s.Logger().Info("tombstone removed", zap.String("tombstone", tombstoneID))
}
}
// Close closes the tombstone sweeper.
func (s *tombstoneSweeperImpl) Close() {
s.notifier.Cancel()
s.notifier.BlockUntilFinish()
}