mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-07 01:28:27 +08:00
6d4961b978
issue: #43858 Refactor the balance checker implementation to use priority queues for managing collection balance operations, improving processing efficiency and order control. Changes include: - Export priority queue interfaces (Item, BaseItem, PriorityQueue) - Replace collection round-robin with priority-based queue system - Add BalanceCheckCollectionMaxCount configuration parameter - Optimize balance task generation with batch processing limits - Refactor processBalanceQueue method for different strategies - Enhance test coverage with comprehensive unit tests The new priority queue system processes collections based on row count or collection ID order, providing better control over balance operation priorities and resource utilization. --------- Signed-off-by: Wei Liu <wei.liu@zilliz.com>
97 lines
2.8 KiB
Go
97 lines
2.8 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package balance
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestMinPriorityQueue(t *testing.T) {
|
|
pq := NewPriorityQueue()
|
|
|
|
for i := 0; i < 5; i++ {
|
|
priority := i % 3
|
|
nodeItem := newNodeItem(priority, int64(i))
|
|
pq.Push(&nodeItem)
|
|
}
|
|
|
|
item := pq.Pop()
|
|
assert.Equal(t, item.getPriority(), 0)
|
|
assert.Equal(t, item.(*nodeItem).nodeID, int64(0))
|
|
item = pq.Pop()
|
|
assert.Equal(t, item.getPriority(), 0)
|
|
assert.Equal(t, item.(*nodeItem).nodeID, int64(3))
|
|
item = pq.Pop()
|
|
assert.Equal(t, item.getPriority(), 1)
|
|
assert.Equal(t, item.(*nodeItem).nodeID, int64(1))
|
|
item = pq.Pop()
|
|
assert.Equal(t, item.getPriority(), 1)
|
|
assert.Equal(t, item.(*nodeItem).nodeID, int64(4))
|
|
item = pq.Pop()
|
|
assert.Equal(t, item.getPriority(), 2)
|
|
println(item.getPriority())
|
|
assert.Equal(t, item.(*nodeItem).nodeID, int64(2))
|
|
}
|
|
|
|
func TestPopPriorityQueue(t *testing.T) {
|
|
pq := NewPriorityQueue()
|
|
|
|
for i := 0; i < 1; i++ {
|
|
priority := 1
|
|
nodeItem := newNodeItem(priority, int64(i))
|
|
pq.Push(&nodeItem)
|
|
}
|
|
|
|
item := pq.Pop()
|
|
assert.Equal(t, item.getPriority(), 1)
|
|
assert.Equal(t, item.(*nodeItem).nodeID, int64(0))
|
|
pq.Push(item)
|
|
|
|
// if it's round robin, but not working
|
|
item = pq.Pop()
|
|
assert.Equal(t, item.getPriority(), 1)
|
|
assert.Equal(t, item.(*nodeItem).nodeID, int64(0))
|
|
}
|
|
|
|
func TestMaxPriorityQueue(t *testing.T) {
|
|
pq := NewPriorityQueue()
|
|
|
|
for i := 0; i < 5; i++ {
|
|
priority := i % 3
|
|
nodeItem := newNodeItem(-priority, int64(i))
|
|
pq.Push(&nodeItem)
|
|
}
|
|
|
|
item := pq.Pop()
|
|
assert.Equal(t, item.getPriority(), -2)
|
|
assert.Equal(t, item.(*nodeItem).nodeID, int64(2))
|
|
item = pq.Pop()
|
|
assert.Equal(t, item.getPriority(), -1)
|
|
assert.Equal(t, item.(*nodeItem).nodeID, int64(4))
|
|
item = pq.Pop()
|
|
assert.Equal(t, item.getPriority(), -1)
|
|
assert.Equal(t, item.(*nodeItem).nodeID, int64(1))
|
|
item = pq.Pop()
|
|
assert.Equal(t, item.getPriority(), 0)
|
|
assert.Equal(t, item.(*nodeItem).nodeID, int64(3))
|
|
item = pq.Pop()
|
|
assert.Equal(t, item.getPriority(), 0)
|
|
assert.Equal(t, item.(*nodeItem).nodeID, int64(0))
|
|
}
|