mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-06 17:18:35 +08:00
f5f053f1d2
Related to #44761 This commit refactors the privilege management system in the proxy component by: 1. **Separation of Concerns**: Extracts privilege-related functionality from MetaCache into a dedicated `internal/proxy/privilege` package, improving code organization and maintainability. 2. **New Package Structure**: Creates `internal/proxy/privilege/` with: - `cache.go`: Core privilege cache implementation (PrivilegeCache) - `result_cache.go`: Privilege enforcement result caching - `model.go`: Casbin model and policy enforcement functions - `meta_cache_adapter.go`: Casbin adapter for MetaCache integration - Corresponding test files and mock implementations 3. **MetaCache Simplification**: Removes privilege and credential management methods from MetaCache interface and implementation: - Removed: GetCredentialInfo, RemoveCredential, UpdateCredential - Removed: GetPrivilegeInfo, GetUserRole, RefreshPolicyInfo, InitPolicyInfo - Deleted: meta_cache_adapter.go, privilege_cache.go and their tests 4. **Updated References**: Updates all callsites to use the new privilegeCache global: - Authentication interceptor now uses privilegeCache for password verification - Credential cache operations (InvalidateCredentialCache, UpdateCredentialCache, UpdateCredential) now use privilegeCache - Policy refresh operations (RefreshPolicyInfoCache) now use privilegeCache - Privilege interceptor uses new privilege.GetEnforcer() and privilege result cache 5. **Improved API**: Renames cache functions for clarity: - GetPrivilegeCache → GetResultCache - SetPrivilegeCache → SetResultCache - CleanPrivilegeCache → CleanResultCache This refactoring makes the codebase more modular, separates privilege management concerns from general metadata caching, and provides a clearer API for privilege enforcement operations. --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
83 lines
3.2 KiB
Go
83 lines
3.2 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package privilege
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/casbin/casbin/v2/model"
|
|
jsonadapter "github.com/casbin/json-adapter/v2"
|
|
|
|
"github.com/milvus-io/milvus/pkg/v2/util/merr"
|
|
)
|
|
|
|
// MetaCacheCasbinAdapter is the implementation of `persist.Adapter` with Cache
|
|
// Since the usage shall be read-only, it implements only `LoadPolicy` for now.
|
|
type MetaCacheCasbinAdapter struct {
|
|
cacheSource func() PrivilegeCache
|
|
}
|
|
|
|
func NewMetaCacheCasbinAdapter(cacheSource func() PrivilegeCache) *MetaCacheCasbinAdapter {
|
|
return &MetaCacheCasbinAdapter{
|
|
cacheSource: cacheSource,
|
|
}
|
|
}
|
|
|
|
// LoadPolicy loads all policy rules from the storage.
|
|
// Implementing `persist.Adapter`.
|
|
func (a *MetaCacheCasbinAdapter) LoadPolicy(model model.Model) error {
|
|
cache := a.cacheSource()
|
|
if cache == nil {
|
|
return merr.WrapErrServiceInternal("cache source return nil cache")
|
|
}
|
|
policyInfo := strings.Join(cache.GetPrivilegeInfo(context.Background()), ",")
|
|
|
|
policy := fmt.Sprintf("[%s]", policyInfo)
|
|
byteSource := []byte(policy)
|
|
jAdapter := jsonadapter.NewAdapter(&byteSource)
|
|
return jAdapter.LoadPolicy(model)
|
|
}
|
|
|
|
// SavePolicy saves all policy rules to the storage.
|
|
// Implementing `persist.Adapter`.
|
|
// MetaCacheCasbinAdapter is read-only, always returns error
|
|
func (a *MetaCacheCasbinAdapter) SavePolicy(model model.Model) error {
|
|
return merr.WrapErrServiceInternal("MetaCacheCasbinAdapter is read-only, but received SavePolicy call")
|
|
}
|
|
|
|
// AddPolicy adds a policy rule to the storage.
|
|
// Implementing `persist.Adapter`.
|
|
// MetaCacheCasbinAdapter is read-only, always returns error
|
|
func (a *MetaCacheCasbinAdapter) AddPolicy(sec string, ptype string, rule []string) error {
|
|
return merr.WrapErrServiceInternal("MetaCacheCasbinAdapter is read-only, but received AddPolicy call")
|
|
}
|
|
|
|
// RemovePolicy removes a policy rule from the storage.
|
|
// Implementing `persist.Adapter`.
|
|
// MetaCacheCasbinAdapter is read-only, always returns error
|
|
func (a *MetaCacheCasbinAdapter) RemovePolicy(sec string, ptype string, rule []string) error {
|
|
return merr.WrapErrServiceInternal("MetaCacheCasbinAdapter is read-only, but received RemovePolicy call")
|
|
}
|
|
|
|
// RemoveFilteredPolicy removes policy rules that match the filter from the storage.
|
|
// This is part of the Auto-Save feature.
|
|
func (a *MetaCacheCasbinAdapter) RemoveFilteredPolicy(sec string, ptype string, fieldIndex int, fieldValues ...string) error {
|
|
return merr.WrapErrServiceInternal("MetaCacheCasbinAdapter is read-only, but received RemoveFilteredPolicy call")
|
|
}
|