mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-06 17:18:35 +08:00
3327df72e4
issue: #43897 - The original broadcast ack operation need to recover message from etcd, which can not support cdc. - immutable message will set as the ack parameter to fix it. Signed-off-by: chyezh <chyezh@outlook.com>
40 lines
1.2 KiB
Go
40 lines
1.2 KiB
Go
package streaming
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/milvus-io/milvus/pkg/v2/streaming/util/message"
|
|
"github.com/milvus-io/milvus/pkg/v2/streaming/util/types"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/retry"
|
|
"github.com/milvus-io/milvus/pkg/v2/util/typeutil"
|
|
)
|
|
|
|
var _ Broadcast = broadcast{}
|
|
|
|
type broadcast struct {
|
|
*walAccesserImpl
|
|
}
|
|
|
|
func (b broadcast) Append(ctx context.Context, msg message.BroadcastMutableMessage) (*types.BroadcastAppendResult, error) {
|
|
assertValidBroadcastMessage(msg)
|
|
if !b.lifetime.Add(typeutil.LifetimeStateWorking) {
|
|
return nil, ErrWALAccesserClosed
|
|
}
|
|
defer b.lifetime.Done()
|
|
|
|
// The broadcast operation will be sent to the coordinator.
|
|
// The coordinator will dispatch the message to all the vchannels with an eventual consistency guarantee.
|
|
return b.streamingCoordClient.Broadcast().Broadcast(ctx, msg)
|
|
}
|
|
|
|
func (b broadcast) Ack(ctx context.Context, msg message.ImmutableMessage) error {
|
|
if !b.lifetime.Add(typeutil.LifetimeStateWorking) {
|
|
// should be an unreachable error.
|
|
return ErrWALAccesserClosed
|
|
}
|
|
defer b.lifetime.Done()
|
|
|
|
// retry until the ctx is canceled.
|
|
return retry.Do(ctx, func() error { return b.streamingCoordClient.Broadcast().Ack(ctx, msg) }, retry.AttemptAlways())
|
|
}
|