// Licensed to the LF AI & Data foundation under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The ASF licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you may not use this file except in compliance // with the License. You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. package compaction import ( "context" "fmt" "math" "path" "sort" "strconv" "sync" "time" "github.com/cockroachdb/errors" "github.com/golang/protobuf/proto" "github.com/samber/lo" "go.opentelemetry.io/otel" "go.uber.org/atomic" "go.uber.org/zap" "github.com/milvus-io/milvus-proto/go-api/v2/schemapb" "github.com/milvus-io/milvus/internal/datanode/allocator" "github.com/milvus-io/milvus/internal/datanode/io" "github.com/milvus-io/milvus/internal/proto/clusteringpb" "github.com/milvus-io/milvus/internal/proto/datapb" "github.com/milvus-io/milvus/internal/storage" "github.com/milvus-io/milvus/pkg/common" "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/metrics" "github.com/milvus-io/milvus/pkg/util/conc" "github.com/milvus-io/milvus/pkg/util/funcutil" "github.com/milvus-io/milvus/pkg/util/hardware" "github.com/milvus-io/milvus/pkg/util/lock" "github.com/milvus-io/milvus/pkg/util/merr" "github.com/milvus-io/milvus/pkg/util/metautil" "github.com/milvus-io/milvus/pkg/util/paramtable" "github.com/milvus-io/milvus/pkg/util/timerecord" "github.com/milvus-io/milvus/pkg/util/tsoutil" "github.com/milvus-io/milvus/pkg/util/typeutil" ) var _ Compactor = (*clusteringCompactionTask)(nil) type clusteringCompactionTask struct { binlogIO io.BinlogIO allocator allocator.Allocator ctx context.Context cancel context.CancelFunc done chan struct{} tr *timerecord.TimeRecorder plan *datapb.CompactionPlan // schedule spillChan chan SpillSignal pool *conc.Pool[any] // metrics spillCount *atomic.Int64 writtenRowNum *atomic.Int64 // inner field collectionID int64 partitionID int64 currentTs typeutil.Timestamp // for TTL isVectorClusteringKey bool clusteringKeyField *schemapb.FieldSchema primaryKeyField *schemapb.FieldSchema spillMutex sync.Mutex memoryBufferSize int64 clusterBuffers []*ClusterBuffer clusterBufferLocks *lock.KeyLock[int] // scalar keyToBufferFunc func(interface{}) *ClusterBuffer // vector segmentIDOffsetMapping map[int64]string offsetToBufferFunc func(int64, []uint32) *ClusterBuffer } type ClusterBuffer struct { id int writer *SegmentWriter bufferRowNum atomic.Int64 flushedRowNum int64 flushedBinlogs map[typeutil.UniqueID]*datapb.FieldBinlog uploadedSegments []*datapb.CompactionSegment uploadedSegmentStats map[typeutil.UniqueID]storage.SegmentStats clusteringKeyFieldStats *storage.FieldStats } type SpillSignal struct { buffer *ClusterBuffer } func NewClusteringCompactionTask( ctx context.Context, binlogIO io.BinlogIO, alloc allocator.Allocator, plan *datapb.CompactionPlan, ) *clusteringCompactionTask { ctx, cancel := context.WithCancel(ctx) return &clusteringCompactionTask{ ctx: ctx, cancel: cancel, binlogIO: binlogIO, allocator: alloc, plan: plan, tr: timerecord.NewTimeRecorder("clustering_compaction"), done: make(chan struct{}, 1), spillChan: make(chan SpillSignal, 100), clusterBuffers: make([]*ClusterBuffer, 0), clusterBufferLocks: lock.NewKeyLock[int](), spillCount: atomic.NewInt64(0), writtenRowNum: atomic.NewInt64(0), } } func (t *clusteringCompactionTask) Complete() { t.done <- struct{}{} } func (t *clusteringCompactionTask) Stop() { t.cancel() <-t.done } func (t *clusteringCompactionTask) GetPlanID() typeutil.UniqueID { return t.plan.GetPlanID() } func (t *clusteringCompactionTask) GetChannelName() string { return t.plan.GetChannel() } func (t *clusteringCompactionTask) GetCollection() int64 { return t.plan.GetSegmentBinlogs()[0].GetCollectionID() } func (t *clusteringCompactionTask) init() error { t.collectionID = t.GetCollection() t.partitionID = t.plan.GetSegmentBinlogs()[0].GetPartitionID() var pkField *schemapb.FieldSchema if t.plan.Schema == nil { return errors.New("empty schema in compactionPlan") } for _, field := range t.plan.Schema.Fields { if field.GetIsPrimaryKey() && field.GetFieldID() >= 100 && typeutil.IsPrimaryFieldType(field.GetDataType()) { pkField = field } if field.GetFieldID() == t.plan.GetClusteringKeyField() { t.clusteringKeyField = field } } t.primaryKeyField = pkField t.isVectorClusteringKey = typeutil.IsVectorType(t.clusteringKeyField.DataType) t.currentTs = tsoutil.GetCurrentTime() t.memoryBufferSize = t.getMemoryBufferSize() workerPoolSize := t.getWorkerPoolSize() t.pool = conc.NewPool[any](workerPoolSize) log.Info("clustering compaction task initialed", zap.Int64("memory_buffer_size", t.memoryBufferSize), zap.Int("worker_pool_size", workerPoolSize)) return nil } func (t *clusteringCompactionTask) Compact() (*datapb.CompactionPlanResult, error) { ctx, span := otel.Tracer(typeutil.DataNodeRole).Start(t.ctx, fmt.Sprintf("clusteringCompaction-%d", t.GetPlanID())) defer span.End() log := log.With(zap.Int64("planID", t.plan.GetPlanID()), zap.String("type", t.plan.GetType().String())) if t.plan.GetType() != datapb.CompactionType_ClusteringCompaction { // this shouldn't be reached log.Warn("compact wrong, illegal compaction type") return nil, merr.WrapErrIllegalCompactionPlan() } log.Info("Clustering compaction", zap.Duration("wait in queue elapse", t.tr.RecordSpan())) if !funcutil.CheckCtxValid(ctx) { log.Warn("compact wrong, task context done or timeout") return nil, ctx.Err() } ctxTimeout, cancelAll := context.WithTimeout(ctx, time.Duration(t.plan.GetTimeoutInSeconds())*time.Second) defer cancelAll() err := t.init() if err != nil { return nil, err } defer t.cleanUp(ctx) // 1, download delta logs to build deltaMap deltaBlobs, _, err := loadDeltaMap(t.plan.GetSegmentBinlogs()) if err != nil { return nil, err } deltaPk2Ts, err := mergeDeltalogs(ctxTimeout, t.binlogIO, deltaBlobs) if err != nil { return nil, err } // 2, get analyze result if t.isVectorClusteringKey { if err := t.getVectorAnalyzeResult(ctx); err != nil { return nil, err } } else { if err := t.getScalarAnalyzeResult(ctx); err != nil { return nil, err } } // 3, mapping log.Info("Clustering compaction start mapping", zap.Int("bufferNum", len(t.clusterBuffers))) uploadSegments, partitionStats, err := t.mapping(ctx, deltaPk2Ts) if err != nil { return nil, err } // 4, collect partition stats err = t.uploadPartitionStats(ctx, t.collectionID, t.partitionID, partitionStats) if err != nil { return nil, err } // 5, assemble CompactionPlanResult planResult := &datapb.CompactionPlanResult{ State: datapb.CompactionTaskState_completed, PlanID: t.GetPlanID(), Segments: uploadSegments, Type: t.plan.GetType(), Channel: t.plan.GetChannel(), } metrics.DataNodeCompactionLatency. WithLabelValues(fmt.Sprint(paramtable.GetNodeID()), t.plan.GetType().String()). Observe(float64(t.tr.ElapseSpan().Milliseconds())) log.Info("Clustering compaction finished", zap.Duration("elapse", t.tr.ElapseSpan())) return planResult, nil } func (t *clusteringCompactionTask) getScalarAnalyzeResult(ctx context.Context) error { analyzeDict, err := t.scalarAnalyze(ctx) if err != nil { return err } plan := t.scalarPlan(analyzeDict) scalarToClusterBufferMap := make(map[interface{}]*ClusterBuffer, 0) for id, bucket := range plan { fieldStats, err := storage.NewFieldStats(t.clusteringKeyField.FieldID, t.clusteringKeyField.DataType, 0) if err != nil { return err } for _, key := range bucket { fieldStats.UpdateMinMax(storage.NewScalarFieldValue(t.clusteringKeyField.DataType, key)) } buffer := &ClusterBuffer{ id: id, flushedBinlogs: make(map[typeutil.UniqueID]*datapb.FieldBinlog, 0), uploadedSegments: make([]*datapb.CompactionSegment, 0), uploadedSegmentStats: make(map[typeutil.UniqueID]storage.SegmentStats, 0), clusteringKeyFieldStats: fieldStats, } t.refreshBufferWriter(buffer) t.clusterBuffers = append(t.clusterBuffers, buffer) for _, key := range bucket { scalarToClusterBufferMap[key] = buffer } } t.keyToBufferFunc = func(key interface{}) *ClusterBuffer { // todo: if keys are too many, the map will be quite large, we should mark the range of each buffer and select buffer by range return scalarToClusterBufferMap[key] } return nil } func (t *clusteringCompactionTask) getVectorAnalyzeResult(ctx context.Context) error { analyzeResultPath := t.plan.AnalyzeResultPath centroidFilePath := path.Join(analyzeResultPath, metautil.JoinIDPath(t.collectionID, t.partitionID, t.clusteringKeyField.FieldID), common.Centroids) offsetMappingFiles := make(map[int64]string, 0) for _, segmentID := range t.plan.AnalyzeSegmentIds { path := path.Join(analyzeResultPath, metautil.JoinIDPath(t.collectionID, t.partitionID, t.clusteringKeyField.FieldID, segmentID), common.OffsetMapping) offsetMappingFiles[segmentID] = path log.Debug("read segment offset mapping file", zap.Int64("segmentID", segmentID), zap.String("path", path)) } t.segmentIDOffsetMapping = offsetMappingFiles centroidBytes, err := t.binlogIO.Download(ctx, []string{centroidFilePath}) if err != nil { return err } centroids := &clusteringpb.ClusteringCentroidsStats{} err = proto.Unmarshal(centroidBytes[0], centroids) if err != nil { return err } log.Debug("read clustering centroids stats", zap.String("path", centroidFilePath), zap.Int("centroidNum", len(centroids.GetCentroids())), zap.Any("offsetMappingFiles", t.segmentIDOffsetMapping)) for id, centroid := range centroids.GetCentroids() { fieldStats, err := storage.NewFieldStats(t.clusteringKeyField.FieldID, t.clusteringKeyField.DataType, 0) if err != nil { return err } fieldStats.SetVectorCentroids(storage.NewVectorFieldValue(t.clusteringKeyField.DataType, centroid)) clusterBuffer := &ClusterBuffer{ id: id, flushedBinlogs: make(map[typeutil.UniqueID]*datapb.FieldBinlog, 0), uploadedSegments: make([]*datapb.CompactionSegment, 0), uploadedSegmentStats: make(map[typeutil.UniqueID]storage.SegmentStats, 0), clusteringKeyFieldStats: fieldStats, } t.refreshBufferWriter(clusterBuffer) t.clusterBuffers = append(t.clusterBuffers, clusterBuffer) } t.offsetToBufferFunc = func(offset int64, idMapping []uint32) *ClusterBuffer { return t.clusterBuffers[idMapping[offset]] } return nil } // mapping read and split input segments into buffers func (t *clusteringCompactionTask) mapping(ctx context.Context, deltaPk2Ts map[interface{}]typeutil.Timestamp, ) ([]*datapb.CompactionSegment, *storage.PartitionStatsSnapshot, error) { inputSegments := t.plan.GetSegmentBinlogs() mapStart := time.Now() // start spill goroutine go t.backgroundSpill(ctx) futures := make([]*conc.Future[any], 0, len(inputSegments)) for _, segment := range inputSegments { segmentClone := &datapb.CompactionSegmentBinlogs{ SegmentID: segment.SegmentID, // only FieldBinlogs needed FieldBinlogs: segment.FieldBinlogs, } future := t.pool.Submit(func() (any, error) { err := t.mappingSegment(ctx, segmentClone, deltaPk2Ts) return struct{}{}, err }) futures = append(futures, future) } if err := conc.AwaitAll(futures...); err != nil { return nil, nil, err } // force spill all buffers err := t.spillAll(ctx) if err != nil { return nil, nil, err } resultSegments := make([]*datapb.CompactionSegment, 0) resultPartitionStats := &storage.PartitionStatsSnapshot{ SegmentStats: make(map[typeutil.UniqueID]storage.SegmentStats), } for _, buffer := range t.clusterBuffers { for _, seg := range buffer.uploadedSegments { se := &datapb.CompactionSegment{ PlanID: seg.GetPlanID(), SegmentID: seg.GetSegmentID(), NumOfRows: seg.GetNumOfRows(), InsertLogs: seg.GetInsertLogs(), Field2StatslogPaths: seg.GetField2StatslogPaths(), Deltalogs: seg.GetDeltalogs(), Channel: seg.GetChannel(), } log.Debug("put segment into final compaction result", zap.String("segment", se.String())) resultSegments = append(resultSegments, se) } for segID, segmentStat := range buffer.uploadedSegmentStats { log.Debug("put segment into final partition stats", zap.Int64("segmentID", segID), zap.Any("stats", segmentStat)) resultPartitionStats.SegmentStats[segID] = segmentStat } } log.Info("mapping end", zap.Int64("collectionID", t.GetCollection()), zap.Int64("partitionID", t.partitionID), zap.Int("segmentFrom", len(inputSegments)), zap.Int("segmentTo", len(resultSegments)), zap.Duration("elapse", time.Since(mapStart))) return resultSegments, resultPartitionStats, nil } func (t *clusteringCompactionTask) getWrittenMemoryBufferSize() int64 { var totalBufferSize int64 = 0 for _, buffer := range t.clusterBuffers { totalBufferSize = totalBufferSize + int64(buffer.writer.WrittenMemorySize()) } return totalBufferSize } // read insert log of one segment, mappingSegment into buckets according to clusteringKey. flush data to file when necessary func (t *clusteringCompactionTask) mappingSegment( ctx context.Context, segment *datapb.CompactionSegmentBinlogs, delta map[interface{}]typeutil.Timestamp, ) error { ctx, span := otel.Tracer(typeutil.DataNodeRole).Start(ctx, fmt.Sprintf("Compact-Map-%d", t.GetPlanID())) defer span.End() log := log.With(zap.Int64("planID", t.GetPlanID()), zap.Int64("collectionID", t.GetCollection()), zap.Int64("partitionID", t.partitionID), zap.Int64("segmentID", segment.GetSegmentID())) log.Info("mapping segment start") processStart := time.Now() fieldBinlogPaths := make([][]string, 0) var ( expired int64 = 0 deleted int64 = 0 remained int64 = 0 ) isDeletedValue := func(v *storage.Value) bool { ts, ok := delta[v.PK.GetValue()] // insert task and delete task has the same ts when upsert // here should be < instead of <= // to avoid the upsert data to be deleted after compact if ok && uint64(v.Timestamp) < ts { return true } return false } mappingStats := &clusteringpb.ClusteringCentroidIdMappingStats{} if t.isVectorClusteringKey { offSetPath := t.segmentIDOffsetMapping[segment.SegmentID] offsetBytes, err := t.binlogIO.Download(ctx, []string{offSetPath}) if err != nil { return err } err = proto.Unmarshal(offsetBytes[0], mappingStats) if err != nil { return err } } // Get the number of field binlog files from non-empty segment var binlogNum int for _, b := range segment.GetFieldBinlogs() { if b != nil { binlogNum = len(b.GetBinlogs()) break } } // Unable to deal with all empty segments cases, so return error if binlogNum == 0 { log.Warn("compact wrong, all segments' binlogs are empty") return merr.WrapErrIllegalCompactionPlan() } for idx := 0; idx < binlogNum; idx++ { var ps []string for _, f := range segment.GetFieldBinlogs() { ps = append(ps, f.GetBinlogs()[idx].GetLogPath()) } fieldBinlogPaths = append(fieldBinlogPaths, ps) } for _, path := range fieldBinlogPaths { bytesArr, err := t.binlogIO.Download(ctx, path) blobs := make([]*storage.Blob, len(bytesArr)) var segmentSize int64 for i := range bytesArr { blobs[i] = &storage.Blob{Value: bytesArr[i]} segmentSize = segmentSize + int64(len(bytesArr[i])) } if err != nil { log.Warn("download insertlogs wrong", zap.Strings("path", path), zap.Error(err)) return err } pkIter, err := storage.NewInsertBinlogIterator(blobs, t.primaryKeyField.GetFieldID(), t.primaryKeyField.GetDataType()) if err != nil { log.Warn("new insert binlogs Itr wrong", zap.Strings("path", path), zap.Error(err)) return err } var offset int64 = -1 for pkIter.HasNext() { vInter, _ := pkIter.Next() v, ok := vInter.(*storage.Value) if !ok { log.Warn("transfer interface to Value wrong", zap.Strings("path", path)) return errors.New("unexpected error") } offset++ // Filtering deleted entity if isDeletedValue(v) { deleted++ continue } // Filtering expired entity ts := typeutil.Timestamp(v.Timestamp) if isExpiredEntity(t.plan.GetCollectionTtl(), t.currentTs, ts) { expired++ continue } row, ok := v.Value.(map[typeutil.UniqueID]interface{}) if !ok { log.Warn("transfer interface to map wrong", zap.Strings("path", path)) return errors.New("unexpected error") } clusteringKey := row[t.clusteringKeyField.FieldID] var clusterBuffer *ClusterBuffer if t.isVectorClusteringKey { clusterBuffer = t.offsetToBufferFunc(offset, mappingStats.GetCentroidIdMapping()) } else { clusterBuffer = t.keyToBufferFunc(clusteringKey) } err = t.writeToBuffer(ctx, clusterBuffer, v) if err != nil { return err } remained++ // currentSize := t.totalBufferSize.Load() if (remained+1)%20 == 0 { currentBufferSize := t.getWrittenMemoryBufferSize() // trigger spill if clusterBuffer.bufferRowNum.Load() > t.plan.GetMaxSegmentRows() || clusterBuffer.writer.IsFull() { // reach segment/binlog max size t.spillChan <- SpillSignal{ buffer: clusterBuffer, } } else if currentBufferSize >= t.getMemoryBufferMiddleWatermark() { // reach spill trigger threshold t.spillChan <- SpillSignal{} } // if the total buffer size is too large, block here, wait for memory release by spill if currentBufferSize > t.getMemoryBufferHighWatermark() { loop: for { select { case <-ctx.Done(): log.Warn("stop waiting for memory buffer release as context done") return nil case <-t.done: log.Warn("stop waiting for memory buffer release as task chan done") return nil default: currentSize := t.getWrittenMemoryBufferSize() if currentSize < t.getMemoryBufferMiddleWatermark() { break loop } time.Sleep(time.Millisecond * 200) } } } } } } log.Info("mapping segment end", zap.Int64("remained_entities", remained), zap.Int64("deleted_entities", deleted), zap.Int64("expired_entities", expired), zap.Int64("written_row_num", t.writtenRowNum.Load()), zap.Duration("elapse", time.Since(processStart))) return nil } func (t *clusteringCompactionTask) writeToBuffer(ctx context.Context, clusterBuffer *ClusterBuffer, value *storage.Value) error { t.clusterBufferLocks.Lock(clusterBuffer.id) defer t.clusterBufferLocks.Unlock(clusterBuffer.id) // prepare if clusterBuffer.writer == nil { err := t.refreshBufferWriter(clusterBuffer) if err != nil { return err } } err := clusterBuffer.writer.Write(value) if err != nil { return err } t.writtenRowNum.Inc() clusterBuffer.bufferRowNum.Add(1) return nil } func (t *clusteringCompactionTask) getWorkerPoolSize() int { return int(math.Max(float64(paramtable.Get().DataNodeCfg.ClusteringCompactionWorkerPoolSize.GetAsInt()), 1.0)) } // getMemoryBufferSize return memoryBufferSize func (t *clusteringCompactionTask) getMemoryBufferSize() int64 { return int64(float64(hardware.GetMemoryCount()) * paramtable.Get().DataNodeCfg.ClusteringCompactionMemoryBufferRatio.GetAsFloat()) } func (t *clusteringCompactionTask) getMemoryBufferMiddleWatermark() int64 { return int64(float64(t.memoryBufferSize) * 0.5) } func (t *clusteringCompactionTask) getMemoryBufferHighWatermark() int64 { return int64(float64(t.memoryBufferSize) * 0.9) } func (t *clusteringCompactionTask) backgroundSpill(ctx context.Context) { for { select { case <-ctx.Done(): log.Info("clustering compaction task context exit") return case <-t.done: log.Info("clustering compaction task done") return case signal := <-t.spillChan: var err error if signal.buffer == nil { err = t.spillLargestBuffers(ctx) } else { err = func() error { t.clusterBufferLocks.Lock(signal.buffer.id) defer t.clusterBufferLocks.Unlock(signal.buffer.id) return t.spill(ctx, signal.buffer) }() } if err != nil { log.Warn("fail to spill data", zap.Error(err)) // todo handle error } } } } func (t *clusteringCompactionTask) spillLargestBuffers(ctx context.Context) error { // only one spillLargestBuffers or spillAll should do at the same time t.spillMutex.Lock() defer t.spillMutex.Unlock() bufferIDs := make([]int, 0) for _, buffer := range t.clusterBuffers { bufferIDs = append(bufferIDs, buffer.id) } sort.Slice(bufferIDs, func(i, j int) bool { return t.clusterBuffers[i].writer.GetRowNum() > t.clusterBuffers[j].writer.GetRowNum() }) for index, bufferId := range bufferIDs { err := func() error { t.clusterBufferLocks.Lock(bufferId) defer t.clusterBufferLocks.Unlock(bufferId) return t.spill(ctx, t.clusterBuffers[bufferId]) }() if err != nil { return err } if index >= len(bufferIDs) { break } } return nil } func (t *clusteringCompactionTask) spillAll(ctx context.Context) error { // only one spillLargestBuffers or spillAll should do at the same time t.spillMutex.Lock() defer t.spillMutex.Unlock() for _, buffer := range t.clusterBuffers { err := func() error { t.clusterBufferLocks.Lock(buffer.id) defer t.clusterBufferLocks.Unlock(buffer.id) err := t.spill(ctx, buffer) if err != nil { log.Error("spill fail") return err } err = t.packBufferToSegment(ctx, buffer) return err }() if err != nil { return err } } return nil } func (t *clusteringCompactionTask) packBufferToSegment(ctx context.Context, buffer *ClusterBuffer) error { if len(buffer.flushedBinlogs) == 0 { return nil } insertLogs := make([]*datapb.FieldBinlog, 0) for _, fieldBinlog := range buffer.flushedBinlogs { insertLogs = append(insertLogs, fieldBinlog) } statPaths, err := statSerializeWrite(ctx, t.binlogIO, t.allocator, buffer.writer, buffer.flushedRowNum) if err != nil { return err } // pack current spill data into a segment seg := &datapb.CompactionSegment{ PlanID: t.plan.GetPlanID(), SegmentID: buffer.writer.GetSegmentID(), NumOfRows: buffer.flushedRowNum, InsertLogs: insertLogs, Field2StatslogPaths: []*datapb.FieldBinlog{statPaths}, Channel: t.plan.GetChannel(), } buffer.uploadedSegments = append(buffer.uploadedSegments, seg) segmentStats := storage.SegmentStats{ FieldStats: []storage.FieldStats{buffer.clusteringKeyFieldStats.Clone()}, NumRows: int(buffer.flushedRowNum), } buffer.uploadedSegmentStats[buffer.writer.GetSegmentID()] = segmentStats // refresh t.refreshBufferWriter(buffer) buffer.flushedRowNum = 0 buffer.flushedBinlogs = make(map[typeutil.UniqueID]*datapb.FieldBinlog, 0) log.Info("finish pack segment", zap.Int64("partitionID", t.partitionID), zap.Int64("segID", buffer.writer.GetSegmentID()), zap.String("seg", seg.String()), zap.Any("segStats", segmentStats)) return nil } func (t *clusteringCompactionTask) spill(ctx context.Context, buffer *ClusterBuffer) error { log := log.With(zap.Int("bufferID", buffer.id), zap.Int64("bufferSize", buffer.bufferRowNum.Load())) if buffer.writer.IsEmpty() { return nil } kvs, partialBinlogs, err := serializeWrite(ctx, t.allocator, buffer.writer) if err != nil { log.Warn("compact wrong, failed to serialize writer", zap.Error(err)) return err } if err := t.binlogIO.Upload(ctx, kvs); err != nil { log.Warn("compact wrong, failed to upload kvs", zap.Error(err)) } for fID, path := range partialBinlogs { tmpBinlog, ok := buffer.flushedBinlogs[fID] if !ok { tmpBinlog = path } else { tmpBinlog.Binlogs = append(tmpBinlog.Binlogs, path.GetBinlogs()...) } buffer.flushedBinlogs[fID] = tmpBinlog } buffer.flushedRowNum = buffer.flushedRowNum + buffer.bufferRowNum.Load() // clean buffer buffer.bufferRowNum.Store(0) t.spillCount.Inc() log.Info("finish spill binlogs", zap.Int64("spillCount", t.spillCount.Load())) if buffer.flushedRowNum > t.plan.GetMaxSegmentRows() { if err := t.packBufferToSegment(ctx, buffer); err != nil { return err } } return nil } func (t *clusteringCompactionTask) uploadPartitionStats(ctx context.Context, collectionID, partitionID typeutil.UniqueID, partitionStats *storage.PartitionStatsSnapshot) error { // use planID as partitionStats version version := t.plan.PlanID partitionStats.Version = version partitionStatsBytes, err := storage.SerializePartitionStatsSnapshot(partitionStats) if err != nil { return err } newStatsPath := path.Join(common.PartitionStatsPath, metautil.JoinIDPath(collectionID, partitionID), t.plan.GetChannel(), strconv.FormatInt(version, 10)) kv := map[string][]byte{ newStatsPath: partitionStatsBytes, } err = t.binlogIO.Upload(ctx, kv) if err != nil { return err } log.Info("Finish upload PartitionStats file", zap.String("key", newStatsPath), zap.Int("length", len(partitionStatsBytes))) return nil } // cleanUp try best to clean all temp datas func (t *clusteringCompactionTask) cleanUp(ctx context.Context) { } func (t *clusteringCompactionTask) scalarAnalyze(ctx context.Context) (map[interface{}]int64, error) { inputSegments := t.plan.GetSegmentBinlogs() futures := make([]*conc.Future[any], 0, len(inputSegments)) analyzeStart := time.Now() var mutex sync.Mutex analyzeDict := make(map[interface{}]int64, 0) for _, segment := range inputSegments { segmentClone := &datapb.CompactionSegmentBinlogs{ SegmentID: segment.SegmentID, FieldBinlogs: segment.FieldBinlogs, Field2StatslogPaths: segment.Field2StatslogPaths, Deltalogs: segment.Deltalogs, InsertChannel: segment.InsertChannel, Level: segment.Level, CollectionID: segment.CollectionID, PartitionID: segment.PartitionID, } future := t.pool.Submit(func() (any, error) { analyzeResult, err := t.scalarAnalyzeSegment(ctx, segmentClone) mutex.Lock() defer mutex.Unlock() for key, v := range analyzeResult { if _, exist := analyzeDict[key]; exist { analyzeDict[key] = analyzeDict[key] + v } else { analyzeDict[key] = v } } return struct{}{}, err }) futures = append(futures, future) } if err := conc.AwaitAll(futures...); err != nil { return nil, err } log.Info("analyze end", zap.Int64("collectionID", t.GetCollection()), zap.Int64("partitionID", t.partitionID), zap.Int("segments", len(inputSegments)), zap.Duration("elapse", time.Since(analyzeStart))) return analyzeDict, nil } func (t *clusteringCompactionTask) scalarAnalyzeSegment( ctx context.Context, segment *datapb.CompactionSegmentBinlogs, ) (map[interface{}]int64, error) { log := log.With(zap.Int64("planID", t.GetPlanID()), zap.Int64("segmentID", segment.GetSegmentID())) // vars processStart := time.Now() fieldBinlogPaths := make([][]string, 0) // initial timestampFrom, timestampTo = -1, -1 is an illegal value, only to mark initial state var ( timestampTo int64 = -1 timestampFrom int64 = -1 expired int64 = 0 deleted int64 = 0 remained int64 = 0 analyzeResult map[interface{}]int64 = make(map[interface{}]int64, 0) ) // Get the number of field binlog files from non-empty segment var binlogNum int for _, b := range segment.GetFieldBinlogs() { if b != nil { binlogNum = len(b.GetBinlogs()) break } } // Unable to deal with all empty segments cases, so return error if binlogNum == 0 { log.Warn("compact wrong, all segments' binlogs are empty") return nil, merr.WrapErrIllegalCompactionPlan() } log.Debug("binlogNum", zap.Int("binlogNum", binlogNum)) for idx := 0; idx < binlogNum; idx++ { var ps []string for _, f := range segment.GetFieldBinlogs() { // todo add a new reader only read one column if f.FieldID == t.primaryKeyField.GetFieldID() || f.FieldID == t.clusteringKeyField.GetFieldID() || f.FieldID == common.RowIDField || f.FieldID == common.TimeStampField { ps = append(ps, f.GetBinlogs()[idx].GetLogPath()) } } fieldBinlogPaths = append(fieldBinlogPaths, ps) } for _, path := range fieldBinlogPaths { bytesArr, err := t.binlogIO.Download(ctx, path) blobs := make([]*storage.Blob, len(bytesArr)) for i := range bytesArr { blobs[i] = &storage.Blob{Value: bytesArr[i]} } if err != nil { log.Warn("download insertlogs wrong", zap.Strings("path", path), zap.Error(err)) return nil, err } pkIter, err := storage.NewInsertBinlogIterator(blobs, t.primaryKeyField.GetFieldID(), t.primaryKeyField.GetDataType()) if err != nil { log.Warn("new insert binlogs Itr wrong", zap.Strings("path", path), zap.Error(err)) return nil, err } // log.Info("pkIter.RowNum()", zap.Int("pkIter.RowNum()", pkIter.RowNum()), zap.Bool("hasNext", pkIter.HasNext())) for pkIter.HasNext() { vIter, _ := pkIter.Next() v, ok := vIter.(*storage.Value) if !ok { log.Warn("transfer interface to Value wrong", zap.Strings("path", path)) return nil, errors.New("unexpected error") } // Filtering expired entity ts := typeutil.Timestamp(v.Timestamp) if isExpiredEntity(t.plan.GetCollectionTtl(), t.currentTs, ts) { expired++ continue } // Update timestampFrom, timestampTo if v.Timestamp < timestampFrom || timestampFrom == -1 { timestampFrom = v.Timestamp } if v.Timestamp > timestampTo || timestampFrom == -1 { timestampTo = v.Timestamp } // rowValue := vIter.GetData().(*iterators.InsertRow).GetValue() row, ok := v.Value.(map[typeutil.UniqueID]interface{}) if !ok { log.Warn("transfer interface to map wrong", zap.Strings("path", path)) return nil, errors.New("unexpected error") } key := row[t.clusteringKeyField.GetFieldID()] if _, exist := analyzeResult[key]; exist { analyzeResult[key] = analyzeResult[key] + 1 } else { analyzeResult[key] = 1 } remained++ } } log.Info("analyze segment end", zap.Int64("remained entities", remained), zap.Int64("deleted entities", deleted), zap.Int64("expired entities", expired), zap.Duration("map elapse", time.Since(processStart))) return analyzeResult, nil } func (t *clusteringCompactionTask) scalarPlan(dict map[interface{}]int64) [][]interface{} { keys := lo.MapToSlice(dict, func(k interface{}, _ int64) interface{} { return k }) sort.Slice(keys, func(i, j int) bool { return storage.NewScalarFieldValue(t.clusteringKeyField.DataType, keys[i]).LE(storage.NewScalarFieldValue(t.clusteringKeyField.DataType, keys[j])) }) buckets := make([][]interface{}, 0) currentBucket := make([]interface{}, 0) var currentBucketSize int64 = 0 maxRows := t.plan.MaxSegmentRows preferRows := t.plan.PreferSegmentRows for _, key := range keys { // todo can optimize if dict[key] > preferRows { if len(currentBucket) != 0 { buckets = append(buckets, currentBucket) currentBucket = make([]interface{}, 0) currentBucketSize = 0 } buckets = append(buckets, []interface{}{key}) } else if currentBucketSize+dict[key] > maxRows { buckets = append(buckets, currentBucket) currentBucket = []interface{}{key} currentBucketSize = dict[key] } else if currentBucketSize+dict[key] > preferRows { currentBucket = append(currentBucket, key) buckets = append(buckets, currentBucket) currentBucket = make([]interface{}, 0) currentBucketSize = 0 } else { currentBucket = append(currentBucket, key) currentBucketSize += dict[key] } } buckets = append(buckets, currentBucket) return buckets } func (t *clusteringCompactionTask) refreshBufferWriter(buffer *ClusterBuffer) error { segmentID, err := t.allocator.AllocOne() if err != nil { return err } writer, err := NewSegmentWriter(t.plan.GetSchema(), t.plan.MaxSegmentRows, segmentID, t.partitionID, t.collectionID) if err != nil { return err } buffer.writer = writer buffer.bufferRowNum.Store(0) return nil }