1265 Commits

Author SHA1 Message Date
SimFG
2465d86138
enhance: [2.3] support related privilege for grant api (#30154)
/kind improvement
pr: #30153

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-01-22 14:42:55 +08:00
yah01
ce318f3286
enhance: make the error of parsing expression to ParameterInvalid (#29681) (#29795)
before this, the error is unexpected error
pr: #29681

Signed-off-by: yah01 <yang.cen@zilliz.com>
2024-01-22 13:36:55 +08:00
yihao.dai
b95f0cc0a1
enhance: Add a counter monitoring for the rate-limit requests (#30109) (#30132)
Add a counter monitoring metric for the ratelimited rpc requests with
labels: proxy nodeID, rpc request type, and state.

issue: https://github.com/milvus-io/milvus/issues/30052

pr: https://github.com/milvus-io/milvus/pull/30109

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-01-21 14:44:59 +08:00
SimFG
be1470a654
enhance: [2.3] Add load/release partitions to replicate msg stream (#30001)
/kind improvement
pr: #28399

---------

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-01-18 22:50:55 +08:00
congqixia
ce1ba6808a
enhance: [cherry-pick] change some important request log level to Info (#30062) (#30071)
Cherry-pick from master
pr: #30062 
Some important request log level shall be at least Info level

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-18 12:44:55 +08:00
PowderLi
ff93e8b489
fix: [CHERRY-PICK] CollectionSchema.autoID is deprecated (#30011)
issue: [#30000](https://github.com/milvus-io/milvus/issues/30000)
related to: [milvus-proto
#202](https://github.com/milvus-io/milvus-proto/pull/202)
master pr: #30002

1. replace collSchema.AutoID with primaryField.AutoID
2. show `enableDynamic` & `enableDynamicField` at the same time
3. avoid data race about the access to metacache

Signed-off-by: PowderLi <min.li@zilliz.com>
2024-01-16 14:32:53 +08:00
cai.zhang
434ac1f6d0
fix: [Pick]Fix error message for indexing (#29906)
issue: #29897 

master pr: #29898

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-01-14 13:30:52 +08:00
aoiasd
128f197797
enhance: [Cherry-Pick] support access log print cluster prefix (#29646) (#29831)
relate: https://github.com/milvus-io/milvus/issues/29645
pr: https://github.com/milvus-io/milvus/pull/29646

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-01-12 18:58:52 +08:00
wayblink
e1446da83c
feat: [Cherry-pick] Implement DescribeAlias and ListAliases interfaces (#29896)
#22882
pr: #29641

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2024-01-12 16:30:51 +08:00
wei liu
16e7f51033
fix: Dynamic update rate limit config with wrong value (#29902)
pr: #29901 
when apply dynamic config changes, we should format the value to proper
unit
This PR fix update rate limit config with wrong value.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-01-12 15:10:51 +08:00
wei liu
5520bfbb05
enhance: Change some frequency log to rated level (#29720) (#29903)
pr: #29720
This PR change some frequency log to rated level

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-01-12 11:46:52 +08:00
congqixia
cd93954214
enhance: [Cherry-pick] pre-allocate result FieldData space to reduce growslice (#29726) (#29866)
Cherry-pick from master
pr: #29726

See also: #29113

Add a new utitliy function in `pkg/util/typetuil` to pre-allocate field
data slice capacity acoording to search limit. This shall avoid copying
the data during `AppendFieldData` when previous slice is out of space.
And shall also save CPU time during high paylog.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-11 17:59:01 +08:00
zhenshan.cao
7cf2be09b5
fix: Restore the MVCC functionality. (#29749) (#29802)
When the TimeTravel functionality was previously removed, it
inadvertently affected the MVCC functionality within the system. This PR
aims to reintroduce the internal MVCC functionality as follows:

1. Add MvccTimestamp to the requests of Search/Query and the results of
Search internally.
2. When the delegator receives a Query/Search request and there is no
MVCC timestamp set in the request, set the delegator's current tsafe as
the MVCC timestamp of the request. If the request already has an MVCC
timestamp, do not modify it.
3. When the Proxy handles Search and triggers the second phase ReQuery,
divide the ReQuery into different shards and pass the MVCC timestamp to
the corresponding Query requests.

issue: #29656
pr: #29749

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-01-11 14:42:49 +08:00
zhenshan.cao
8c2ca3fb79
feat: Authorize users to query grant info of their roles (#29747) (#29762)
Once a role is granted to a user, the user should automatically possess
the privilege information associated with that role.

issue: #29710
pr: #29747

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-01-08 18:06:49 +08:00
congqixia
0c83440f99
enhance: [Cherry-pick] cache collection schema attributes to reduce proxy cpu (#29668) (#29692)
Cherry-pick from master
pr: #29668

See also #29113

The collection schema is crucial when performing search/query but some
of the information is calculated for every request.

This PR change schema field of cached collection info into a utility
`schemaInfo` type to store some stable result, say pk field,
partitionKeyEnabled, etc. And provided field name to id map for
search/query services.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-07 22:36:48 +08:00
smellthemoon
fcd23e2ec2
enhance:Add upsert vector metrics(#29226) (#29674)
pr: https://github.com/milvus-io/milvus/pull/29226

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-01-05 15:44:47 +08:00
MrPresent-Han
151a5c3ca8
fix: iterator lose data for duplicted result(#29406) (#29446)
related: #29406
pr: #29451

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-12-27 23:22:46 +08:00
aoiasd
1311911a26
enhance: [Cherry-Pick] make sure stream closed (#29457)
relate: https://github.com/milvus-io/milvus/issues/28367
pr: https://github.com/milvus-io/milvus/pull/29456

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-27 10:02:46 +08:00
aoiasd
6eeb4b7f9a
enhance: [Cherry-Pick] Refine delete by expression for forbid proxy dml task scheduler hang (#29359)
relate: https://github.com/milvus-io/milvus/issues/29146
pr: https://github.com/milvus-io/milvus/pull/29340

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-26 17:50:48 +08:00
aoiasd
2256b53e03
fix: [Cherry-pick]Remove SetFinalizer which cause proxy msgstream memory leak (#29404)
relate: https://github.com/milvus-io/milvus/issues/28367
pr: https://github.com/milvus-io/milvus/pull/29403

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-25 10:16:53 +08:00
wei liu
5fa63da4e3
fix: Rename invalid parameterutil package path (#29334) (#29391)
pr: #29334
This PR renames the invalid parameterutil package path

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-22 10:06:41 +08:00
SimFG
74e72ce27e
enhance: [2.3] Support to get the param value in the runtime (#29298)
pr: #29297
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-21 20:36:43 +08:00
yihao.dai
d8800f5ca5
fix: Return time tick delay error and refine quota error messages (#29289) (#29363)
This pr:
Handles the time tick delay error when converting old error codes to
milvus errors.
Enhances quota error messages by eliminating "force deny" and
substituting it with "quota exceeded."

pr: https://github.com/milvus-io/milvus/pull/29289
issue: https://github.com/milvus-io/milvus/issues/29288

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-12-21 14:58:49 +08:00
congqixia
15bad6485f
enhance: [cherry-pick] refine proxy meta cache partition logic (#29315) (#29378)
Cherry-pick from master
pr: #29315
See also #29113

- Unify partition info refresh logic
- Prevent parse partition names for each partition key search request

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-21 14:16:42 +08:00
Jiquan Long
8ef0c571b3
enhance: make consistency level used in delete configurable (#29280) (#29284)
pr: #29280 
issue: #29279

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-12-20 14:14:34 +08:00
cai.zhang
3182b9df5b
fix: [Pick]Set the default index name to the name of the existing index (#29281)
issue: #29269 
master pr: #29275

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-12-20 14:10:40 +08:00
PowderLi
9af24da65a
fix: rootCoord decide the builtin role cannot be deleted (#29248)
issue: #29243

only rootCoord read the configuration item `builtinRoles`, so proxy
never know whether the role to be deleted is builtin.

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-18 14:22:42 +08:00
cai.zhang
966487962a
enhance: [Pick] Set default index name as field name (#29219)
master pr: #29218

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-12-15 12:02:37 +08:00
congqixia
d8d699401b
enhance: [cherry-pick] Add http method to control datacoord garbage collection (#29212)
Cherry-pick from master
pr: #29052
See also #29051

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi.Xia <congqi.xia@zilliz.com>
2023-12-15 02:16:38 +08:00
congqixia
7d2fa93ee8
enhance: [cherry-pick] remove reset seed for every shuffle (#29196)
Cherry-pick from master
pr: #29195
See also #29113
rand.Seed is deprecated and cost noticable CPU time during heavy payload

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-14 17:38:37 +08:00
congqixia
efef573c67
enhance: [cherry-pick] Add a config item for partition name as regexp feature (#29154) (#29183)
Cherry pick from master
pr: #29154 
See also #29177
Add a config item for partition name as regexp feature and disable it by
default

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-14 14:46:37 +08:00
SimFG
c2ce7bce1a
fix: [2.3] the unstable unit test TestReplicateManager (#29147)
/kind improvement
pr: #28718

Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-13 10:46:44 +08:00
congqixia
78865c02e1
enhance: [cherry-pick] Use zap.Stringer for large log field (#29143) (#29153)
Cherry pick from master
pr: #29143
See also #29113
Using zap.Stringer log field will evaluate log field value only when log
level meets the configuration, which could save some CPU time in search
route

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-13 09:48:38 +08:00
PowderLi
92db41518d
enhance: upgrade proto to use partition related privileges (#29100)
issue: [milvus-proto
#212](https://github.com/milvus-io/milvus-proto/issues/212)
master pr: #28961

milvus can't use partition related privileges until upgrade
milvus-proto, even if them were added to milvus-proto

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-12 13:22:38 +08:00
congqixia
d36bf21f28
enhance: [cherry-pick] Avoid initializing casbin enforcer for each request (#29118)
Cherry-pick from master
pr: #29117 
See also #29113

This patch:
- Replace plain Enforcer with `casbin.SyncedEnforcer`
- Add implementation of persist.Adapter with `MetaCacheCasbinAdapter`
- Invoke enforcer.LoadPolicy when policy updated

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-12 10:36:43 +08:00
PowderLi
10d3224638
enhance: add 3 builtin roles #28961 (#29010)
issue: #28960
master pr: #28961

add new configuration: builtinRoles
user can define roles in config file: milvus.yaml

there is an example:

db_ro, only have read privileges, include load
db_rw, read and write privileges, include create/drop/rename collection
db_admin, not only read and write privileges, but also user
administration

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-08 10:52:36 +08:00
aoiasd
b639fd66b4
fix: [Cherry-pick] accesslog can not print search expression (#28931)
relate: https://github.com/milvus-io/milvus/issues/28893
pr: https://github.com/milvus-io/milvus/pull/28899

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-08 02:00:36 +08:00
MrPresent-Han
5f4ac437b2
enhance: [Cherry-pick] Moving etcd client into session (#27069) (#28996)
relate: #26694
pr: https://github.com/milvus-io/milvus/pull/27069

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
Co-authored-by: Filip Haltmayer <81822489+filip-halt@users.noreply.github.com>
2023-12-07 16:22:34 +08:00
aoiasd
cb7b1d1d51
enhance: [Cherry-pick] pack proxy connection code and support accesslog print SDK_Version (#28844)
relate: https://github.com/milvus-io/milvus/issues/28086
pr: https://github.com/milvus-io/milvus/pull/28835

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-07 12:06:34 +08:00
PowderLi
cdd1305f26
enhance: find collection schema from cache (#28916)
issue: #28781 #28329
master pr: #28782

1. There is no need to call `DescribeCollection`, if the collection's
schema is found in the globalMetaCache
2. did `GetProperties` to check the access to Azure Blob Service

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-06 22:44:33 +08:00
jaime
275e3ea456
fix: Fix missing target db name for RenameCollection (#28911)
issue: #28908
pr: #28909

Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-12-03 08:28:31 +08:00
PowderLi
96c8e8d587
fix: azure ListObjects (#27931) (#28894)
issue: #27932
master pr: #27931

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-01 18:34:31 +08:00
aoiasd
9bf33eb576
fix: [Cherry-Pick] accesslog method status not return failed when error in response (#28827)
relate: https://github.com/milvus-io/milvus/issues/28086
pr: https://github.com/milvus-io/milvus/pull/28824

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-01 15:30:38 +08:00
aoiasd
880189e598
enhance: Delete by complex expression use partitionKey optimization (#27952) (#28128)
relate: https://github.com/milvus-io/milvus/issues/27948
pr: https://github.com/milvus-io/milvus/pull/27952

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-11-30 17:56:31 +08:00
aoiasd
224f2755c5
enhance: [Cherry-pick]Refine accesslog to support format by yaml and support more metric (#28740)
relate: https://github.com/milvus-io/milvus/issues/28086
pr: https://github.com/milvus-io/milvus/issues/28086

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-11-28 15:34:28 +08:00
jaime
9378f78218
enhance: Add logs for each step during service initialization (#28687)
/kind improvement
pr: #28624

Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-11-27 17:54:26 +08:00
yah01
55fda49104
enhance: validate JSON data while inserting (#28602) (#28725)
some SDKs doesn't check the JSON data validation,
add this in server.

pr: #28602

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-27 16:16:26 +08:00
yah01
c4be1ddf44
enhance: improve the error messages and logs (#28684) (#28726)
- better name for log fields
- make the error and log consistent

pr: #28684

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-27 15:40:26 +08:00
yihao.dai
8520ee7552
enhance: Print nq (#28507) (#28639)
Log nq in search path.

pr: https://github.com/milvus-io/milvus/pull/28507

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-11-27 10:18:26 +08:00
yah01
5ca7851f4a
enhance: refine error messages (#28424) (#28614)
- Split the simple reason and full detail
- Refine existing error messages related: #28422
related: https://github.com/milvus-io/milvus/issues/28422
pr: #28424

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-24 10:04:24 +08:00