1280 Commits

Author SHA1 Message Date
yah01
a8d9b0ccba
enhance: optimize the loading index performance (#29894) (#30018)
this utilizes concurrent loading
pr: #29894

Signed-off-by: yah01 <yang.cen@zilliz.com>
2024-01-22 13:12:56 +08:00
foxspy
0700434c58
fix: patching search cache param when index meta does not hold one (#30116)
patch search cache param from index configs when index meta could not
get the search cache size key

issue: #30113 
pr: #30119

Signed-off-by: xianliang <xianliang.li@zilliz.com>
2024-01-19 11:50:56 +08:00
congqixia
14aa20b7f7
enhance: [cherry-pick] fix otel config param type & leak (#30068)
cherry pick from master
pr: #29810 #30055 

`SampleFraction` shall be float and all `C.CString` shall be freed

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-18 12:43:05 +08:00
zhagnlu
9f6a19c56c
fix: increase expr recursion depth to avoid parse failed (#29860) (#30021)
pr: #29860

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-01-16 19:48:38 +08:00
chyezh
072b11355d
fix: SealedIndexingEntry in SealedIndexingRecord may leak without smart pointer protected (#29966)
may related issue: #29828
pr: #29932

Signed-off-by: chyezh <ye.zhen@zilliz.com>
2024-01-15 10:30:52 +08:00
zhenshan.cao
7cf2be09b5
fix: Restore the MVCC functionality. (#29749) (#29802)
When the TimeTravel functionality was previously removed, it
inadvertently affected the MVCC functionality within the system. This PR
aims to reintroduce the internal MVCC functionality as follows:

1. Add MvccTimestamp to the requests of Search/Query and the results of
Search internally.
2. When the delegator receives a Query/Search request and there is no
MVCC timestamp set in the request, set the delegator's current tsafe as
the MVCC timestamp of the request. If the request already has an MVCC
timestamp, do not modify it.
3. When the Proxy handles Search and triggers the second phase ReQuery,
divide the ReQuery into different shards and pass the MVCC timestamp to
the corresponding Query requests.

issue: #29656
pr: #29749

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-01-11 14:42:49 +08:00
PowderLi
9e7974a2c6
fix:[CHERRY_PICK] link with install path's libblob-chunk-manager (#29731)
issue: #29494
pr: #29496


1. link with install path's libblob-chunk-manager
2. performance of `ShouldBindWith` is better than `ShouldBindBodyWith`
3. the middleware shouldn't read the unrefreshed parameter repeatly
4. diff from old restful, named HandlersV1

Signed-off-by: PowderLi <min.li@zilliz.com>
2024-01-07 19:52:49 +08:00
PowderLi
cb355cacce
enhance: get a blob to check object storage config (#29705)
issue: #29672
master pr: #29703

the storage account need privileges of actions
`Microsoft.Storage/storageAccounts/blobServices/containers/blobs/*` at
least

Signed-off-by: PowderLi <min.li@zilliz.com>
2024-01-05 18:02:47 +08:00
foxspy
66c84655d8
fix: [Cherry-pick] throw exception when upload file failed for DiskIndex (#29628)
Cherry pick from master
pr: #29627 
related to: #29417

Signed-off-by: xianliang <xianliang.li@zilliz.com>
2024-01-03 11:10:47 +08:00
congqixia
687eb3955e
enhance: [Cherry-pick] Refine C.NewSegment response and handle exception (#28952) (#29550)
Cherry-pick from master
pr: #28952
See also #28795

Orignal `C.NewSegment` may panic if some condition is not met, this pr
changes response struct to `CNewSegmentResult`, which contains
`C.CStatus` and may return catched exception

---------

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-28 14:48:47 +08:00
yah01
e422a62a80
enhance: improve the handling for segcore error (#29471) (#29521)
- fix lost exception details in segcore
- improve the logs of handling errors from segcore

pr: #29471

Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-12-27 19:06:46 +08:00
Jiquan Long
82fb37e332
fix: panic in concurrent insert/query scenario (#29408) (#29488)
issue: https://github.com/milvus-io/milvus/issues/29405
pr: #29408 

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-12-27 15:08:45 +08:00
yah01
0ec8c6c748
enhance: reduce the memory usage of variable length data (#29387) (#29402)
add all loading data into a buffer and then copy them into the a
fit-in-size memory
pr: https://github.com/milvus-io/milvus/pull/29387

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-12-22 16:56:42 +08:00
chyezh
ace81b8306
fix: fixup data race at generate binlog index (#29371)
issue: #29339
pr: #29370

Signed-off-by: chyezh <ye.zhen@zilliz.com>
2023-12-21 14:56:40 +08:00
yah01
babfb7d671
enhance: remove all unnecessary string formatting (#29323) (#29361)
done by two regex expressions:

- `PanicInfo\((.+),[. \n]+fmt::format\(([.\s\S]+?)\)\)`
- `AssertInfo\((.+),[. \n]+fmt::format\(([.\s\S]+?)\)\)`

related: #28811
pr: #29323

Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-12-21 10:14:52 +08:00
congqixia
4e8409e7dc
enhance: [cherry-pick] ignore proto generated files (#29250)
Cherry-pick from master
pr: #28537
ignore proto generated files
issue: #28566

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Co-authored-by: sunby <sunbingyi1992@gmail.com>
2023-12-15 22:46:39 +08:00
Cai Yudong
0a2c38d942
enhance: Remove omp from segcore (#29236)
Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
2023-12-15 16:12:38 +08:00
Enwei Jiao
1e2a0dd127
enhance: Support otlp with insecure (#29131)
pr: https://github.com/milvus-io/milvus/pull/29115

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-12-12 16:44:37 +08:00
PowderLi
92db41518d
enhance: upgrade proto to use partition related privileges (#29100)
issue: [milvus-proto
#212](https://github.com/milvus-io/milvus-proto/issues/212)
master pr: #28961

milvus can't use partition related privileges until upgrade
milvus-proto, even if them were added to milvus-proto

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-12 13:22:38 +08:00
foxspy
82ac914bd4
enhance: [cherry-pick] support mmap for indexes loaded from disk file (#29002)
master pr: #28904 
issue: #28903

Signed-off-by: xianliang <xianliang.li@zilliz.com>
2023-12-08 10:32:34 +08:00
MrPresent-Han
cd34173e55
fix: fix precision for search reduce(#27325) (#29032)
related: #27325 
pr: https://github.com/milvus-io/milvus/pull/29031

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-12-08 10:10:35 +08:00
liliu-z
f6700551be
enhance: Bump Knowhere's version to 2.2.3 (#29035)
Knowhere's new bug fix version:
https://github.com/zilliztech/knowhere/releases/tag/v2.2.3

related issues: #28821 #28810 #27552 #27516 #28603 #21483

Signed-off-by: Li Liu <li.liu@zilliz.com>
2023-12-07 14:08:33 +08:00
cqy123456
8fd38c8eea
enhance:[cherry-pick] Use binlog index for better search performance (#29012)
this pr is cherry-pick from master:
pr: https://github.com/milvus-io/milvus/pull/28528
pr: https://github.com/milvus-io/milvus/pull/27673
related issue:
issue: https://github.com/milvus-io/milvus/issues/27678

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2023-12-07 09:52:34 +08:00
PowderLi
cdd1305f26
enhance: find collection schema from cache (#28916)
issue: #28781 #28329
master pr: #28782

1. There is no need to call `DescribeCollection`, if the collection's
schema is found in the globalMetaCache
2. did `GetProperties` to check the access to Azure Blob Service

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-06 22:44:33 +08:00
PowderLi
43ec2c2bd7
enhance: [CHERRY-PICK] use already installed vcpkg (#28915)
issue: #28683 master pr: #28505
issue: #28686 master pr: #28703

1. update the base image: milvusdb/milvus-env (#28505) to avoid
downloading installation packages in CI workload install vcpkg and
install some packages in advance
2. use the latest image
2. update azure-identity-cpp from beta to release

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-05 11:12:32 +08:00
yah01
1ab538be43
enhance: enable assert method to format arguments (#28812) (#28907)
for now the assert method in segcore could accept a string information,
too many codes don't print the value they assert.

make it happy
related #28811
pr: #28812

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-12-05 10:22:32 +08:00
congqixia
ed550ebb7c
enhance: [cherry-pick] Resolve libunwind requirement conflict using 1.7.2 (#28935)
Cherry-pick from master
pr: #28929
Try to resolve libunwind dependency requirement conflict between glog &
folly

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-04 14:06:40 +08:00
yihao.dai
c936cc8a95
fix: Fix get binary vector from chunk cache (#28866) (#28884)
The way of getting binary vector size is wrong. This PR will fix it.

issue: https://github.com/milvus-io/milvus/issues/28865

pr: https://github.com/milvus-io/milvus/pull/28866

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-12-01 17:50:32 +08:00
Gao
b6cb9e90d2
fix: [2.3] update folly to resolve simd issue (#28879)
related issue: https://github.com/milvus-io/milvus/issues/27552 , after
this, milvus could run successfully on sse4.2 only machine
pr: #28878

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2023-12-01 13:52:32 +08:00
congqixia
63e1ac0846
fix: [cherry-pick] schema->size() check logic with system field (#28802) (#28841)
Cherry pick from master
pr: #28802

Now segcore load system field info as well, the growing segment
assertion shall not pass with "+ 2" value
This will cause all growing segments load failure
Fix #28801
Related to #28478
See also #28524

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-01 13:28:30 +08:00
yah01
ce8219f1a3
fix: bypass growing index if no index meta (#28791) (#28859)
we shouldn't panic if no index meta, just skip building it
fix #28022
pr: #28791

---------

Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-11-30 21:10:32 +08:00
yah01
8ea1ef03ad
enhance: store system fields in segcore (#28524) (#28727)
we need the system fields info for some usacase
fix: #28523

pr: #28524

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-28 15:32:31 +08:00
cai.zhang
3b06db1d04
enhance: [Pick] Handle knowhere error for creare diskann index (#28691)
master pr: #28690

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-26 18:58:25 +08:00
yah01
c6ba4fa102
enhance: enhance the accuracy of memory usage (#28554) (#28559)
before this, Milvus use container/system's memory info to get the memory
usage, which could be inaccurate.

we allocates the memory by private anon mmap,
then rss - shared would be the accurate memory usage

resolve https://github.com/milvus-io/milvus/issues/28553
pr: #28554

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-24 14:12:25 +08:00
zhagnlu
0bda17e97b
enhance: Add precheck when chunk manager init (#28593)
#28329 
pr: https://github.com/milvus-io/milvus/pull/28330

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2023-11-23 20:34:25 +08:00
zhagnlu
41667f3227
enhance: Disable stdout buffer (#28597)
#28390 
pr: https://github.com/milvus-io/milvus/pull/28391

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2023-11-23 20:20:24 +08:00
PowderLi
1383680b3a
add internal storage metrics (#28279)
/kind improvement
issue: #28277

pr: #28278

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-11-19 17:22:25 +08:00
yah01
2073a0a76a
enhance: reduce 1x copy for variable length field while retrieving (#28345) (#28531)
- Reduce 1x copy for varchar/string/JSON/array types while retrieving
- Reduce 1x copy for int8/int16 while retrieving
fix #28530
pr: #28345

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-17 20:48:21 +08:00
yah01
1743f581e6
enhance: reduce 1x copy while retrieving data from growing segment (#28323) (#28475)
We first fill the data into a vector and then copy it into the proto,
for some types (exclude variable-length types and int8, int16),
data could be directly copied into the proto.

Sealed segment has been optimized in
https://github.com/milvus-io/milvus/pull/28106.

pr: #28323

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-17 14:40:26 +08:00
Enwei Jiao
9997eeb4bb
fix: Fix rocksdb compile failed (#28486)
pr: #28484
/kind improvement

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-11-16 16:38:20 +08:00
yah01
c92e6b654f
Reduce 1x memory copy for retrieving data (#28106) (#28217)
/kind improvement
Before this, while retrieving data (query/search), we first copy the
data into a fixed vector, and then copy data from this into the proto
field.
Now we can directly copy the data into the proto field.

This optimization can't be done with int8, int16 due to the proto
doesn't provide the two types, we store them in int32s

Also, this can't be done with variable length field like string, JSON,
see https://github.com/protocolbuffers/protobuf/issues/10866. I tried
but it seems proto doesn't guarantee the memory layout as we expected,
it crashed
pr: #28106

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-15 10:50:20 +08:00
cai.zhang
c8cab4dfc3
No hit when the index exceeds the array length (#28302)
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-09 22:10:32 +08:00
congqixia
83b7f05fe1
Sync proto generated files to avoid --dirty tag (#28316)
The proto generated files is out of sync for image build env
This will cause --dirty="-dev" tag in Milvus build version
Sync changed files to avoid this case

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-09 21:22:21 +08:00
yah01
0497bbf05d
Handle exception while loading (#28306)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-09 19:28:35 +08:00
PowderLi
39c24fe07b
print azure sdk log (#28241)
Signed-off-by: PowderLi <min.li@zilliz.com>
2023-11-09 10:08:20 +08:00
zhagnlu
99350b1be4
Force set aliyun use_virtual_host to true for all (#28237)
Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2023-11-08 11:10:21 +08:00
foxspy
1944e955cb
publish cardinal for milvus 2.3.3 (#28254)
Signed-off-by: xianliang <xianliang.li@zilliz.com>
2023-11-08 10:56:20 +08:00
Gao
cc3dd6eda4
Set Knowhere version to v2.2.2 (#28252)
Signed-off-by: chasingegg <chao.gao@zilliz.com>
2023-11-08 08:46:19 +08:00
cai.zhang
19230db7f5
Fix bug for constructing ArrayView with fixed-length type (#28186)
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-07 23:36:21 +08:00
yihao.dai
d0bea0eb0a
Get vector concurrently (#28119)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-11-07 19:38:21 +08:00