906 Commits

Author SHA1 Message Date
Xiaofan
a3ea66f621
fix: drop partition can not be successful if load failed[2.4] (#38871)
related to https://github.com/milvus-io/milvus/issues/38649
pr: #38793
when partition load failed, the partition drop will also fail due to the
wrong error message

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
2025-01-02 09:54:54 +08:00
Patrick Weizhi Xu
ccbe6fc646
enhance: [2.4] add param for tuning max VARCHAR length (#38890)
issue: #38882
pr: https://github.com/milvus-io/milvus/pull/38884

Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
(cherry picked from commit 72fecd4f34637a78c1cbc789ee3d97797b458fc0)
2024-12-31 18:19:19 +08:00
yihao.dai
163b258a68
enhance: Bump milvus version to v2.4.20 (#38889)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-12-31 16:33:56 +08:00
foxspy
c0e781072e
fix: [2.4] enable mmap for sparse index (#38849)
issue: #29419
/kind branch-feature

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
2024-12-31 16:28:53 +08:00
SimFG
bd67acc68a
enhance: [2.4] update expr version to support method parameter type conversion (#38781)
/kind improvement
issue: #38780

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-12-30 15:59:06 +08:00
congqixia
fec92e9fa6
enhance: Bump milvus & proto version to v2.4.19 (#38773)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-12-26 16:34:50 +08:00
jaime
b496fa1914
fix: Revert Expose metrics of stanby coordinators (#27698) (#38742)
issue: #38608
pr: #38620

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-12-26 10:16:51 +08:00
cai.zhang
e8eea587d5
enhance: [2.4] Revert clean compaction task in compactionHandler (#38753)
Reverts milvus-io/milvus#38584

issue: https://github.com/milvus-io/milvus/issues/35711

master pr: https://github.com/milvus-io/milvus/pull/38170

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-12-25 21:44:50 +08:00
XuanYang-cn
7f1116566e
enhance: [24]Add missing delete metrics (#38634) (#38746)
Add 2 counter metrics:
- Total delete entries from deltalog:
milvus_datanode_compaction_delete_count
- Total missing deletes: milvus_datanode_compaction_missing_delete_count

See also: #34665
pr: #38634

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-12-25 19:44:52 +08:00
sthuang
ef6aae86cf
fix: [2.4] fix privilege group list and list collections (#38698)
cherry-pick from: https://github.com/milvus-io/milvus/pull/38684
related: https://github.com/milvus-io/milvus/issues/37031

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2024-12-25 14:32:51 +08:00
Zhen Ye
5d2f454ce4
enhance: add multiply factor when loading index (#38721)
issue: #38715
pr: #38716

Signed-off-by: chyezh <chyezh@outlook.com>
2024-12-25 10:50:58 +08:00
cai.zhang
afaabc2a38
enhance: [2.4] clean compaction task in compactionHandler (#38170) (#38584)
issue: #35711

master pr: #38170

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Co-authored-by: wayblink <anyang.wang@zilliz.com>
2024-12-24 15:34:50 +08:00
congqixia
451deb3298
enhance: Bump milvus & proto version to v2.4.18 (#38552)
mockery update related to #31779

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-12-19 10:32:47 +08:00
sthuang
6364e323de
fix: [2.4] privilege group privileges granted from ClusterAdmin permission denied (#38530)
cherry-pick from master: https://github.com/milvus-io/milvus/pull/38514
related: https://github.com/milvus-io/milvus/issues/38460

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2024-12-18 13:20:46 +08:00
jaime
ee7dffc758
fix: sync task still running after DataNode has stopped (#38441)
issue: #38319
pr: #38377

---------

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-12-18 12:38:47 +08:00
Zhen Ye
2e2f61538f
fix: kafka use shared channel to receive produce result (#38534)
issue: #38531
pr: #38532

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2024-12-18 10:36:49 +08:00
congqixia
f878dbf8d2
enhance: [2.4] Bump golang/x/crypto for all packages (#38445) (#38470)
Cherry pick from master
pr: #38445
Related to #38446
See also https://github.com/milvus-io/milvus/security/dependabot/103

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-12-16 14:36:45 +08:00
Xianhui Lin
352e51a88d
enhance: [2.4]alterdatabase support delete property (#38450)
alterdatabase support delete property
issue: https://github.com/milvus-io/milvus/issues/38379

---------

Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
2024-12-15 17:40:44 +08:00
SimFG
4c896c628c
fix: [2.4] replicate message exception when the ttMsgEnable config is changed dynamically (#38440)
- issue: #38177
- pr: #38178

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-12-14 23:24:51 +08:00
Zhen Ye
1da4ac4159
enhance: add detail, replica count for resource group (#38315)
issue: #30647
pr: #38314

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2024-12-13 14:14:49 +08:00
wei liu
83e162f5f1
enhance: Enable score based balance channel policy (#38143) (#38378)
issue: #38142
pr: #38143
current balance channel policy only consider current collection's
distribution, so if all collections has 1 channel, and all channels has
been loaded on same querynode, after querynode num increase, balance
channel won't be triggered.

This PR enable score based balance channel policy, to achieve:
1. distribute all channels evenly across multiple querynodes
2. distribute each collection's channel evenly across multiple
querynodes.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-12-13 10:28:44 +08:00
SimFG
df73f93126
enhance: [2.4] pick some master improvements to 2.4 branch (#38128)
- issue: #38127

master pr list:
- #37759
- #37835
- #37845
- #37874
- #37894
- #37969
- #37983
- #38005
- #38035

---------

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-12-13 10:24:45 +08:00
sthuang
19818c55b2
enhance: [2.4] add privilege group privilege into built-in privilege group (#38408)
cherry-pick from master: https://github.com/milvus-io/milvus/pull/38393
related issue: https://github.com/milvus-io/milvus/issues/37031

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2024-12-12 19:56:43 +08:00
Gao
d7e926f1cb
enhance: [2.4] support recall estimation (#38064)
issue: #37899 
pr: #38017

---------

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2024-12-11 20:40:48 +08:00
jaime
7cee01af44
fix: stream connection leak in case of error (#38321)
issue: #38318
pr: #38320

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-12-11 15:38:49 +08:00
Buqian Zheng
25249fd26e
enhance: [2.4] add metrics for counting number of nun-zeros/tokens of sparse search (#38328)
sparse vectors may have arbitrary number of non zeros and it is hard to
optimize without knowing the actual distribution of nnz. this PR adds a
metric for analyzing that.

pr: #38329 

also fixed a bug of sparse when searching by pk

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
2024-12-11 10:00:43 +08:00
Zhen Ye
6b310e16dc
enhance: remove the rpc layer of coordinator when enabling standalone or mixcoord (#38207)
issue: #37764
pr: #37815 
also see: #38259

- add a local client to call local server directly for
querycoord/rootcoord/datacoord.
- enable local client if milvus is running mixcoord or standalone mode.
- after removing rpc layer from mixcoord, the querycoord at standby mode
will be blocked forever of deployment rolling

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2024-12-10 20:38:44 +08:00
cai.zhang
ddc40a7266
enhance: [2.4]Determine the number of buffers based on the resource limits of the DataNode (#38210)
issue: #28410 

master pr: #38209

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-12-08 17:54:41 +08:00
Xianhui Lin
a51647569b
enhance: [2.4]alterindex & altercollection supports altering properties (#38111)
enhance :

alterindex delete properties
We have introduced a new parameter deleteKeys to the alterindex
functionality, which allows for the deletion of properties within an
index. This enhancement provides users with the flexibility to manage
index properties more effectively by removing specific keys as needed.
altercollection delete properties
We have introduced a new parameter deleteKeys to the altercollection
functionality, which allows for the deletion of properties within an
collection. This enhancement provides users with the flexibility to
manage collection properties more effectively by removing specific keys
as needed.
3.support altercollectionfield
We currently support modifying the fieldparams of a field in a
collection using altercollectionfield, which only allows changes to the
max-length attribute.
Key Points:

New Parameter - deleteKeys: This new parameter enables the deletion of
specified properties from an index. By passing a list of keys to
deleteKeys, users can remove the corresponding properties from the
index.

Mutual Exclusivity: The deleteKeys parameter cannot be used in
conjunction with the extraParams parameter. Users must choose one
parameter to pass based on their requirement. If deleteKeys is provided,
it indicates an intent to delete properties; if extraParams is provided,
it signifies the addition or update of properties.

issue: https://github.com/milvus-io/milvus/issues/37436
pr: https://github.com/milvus-io/milvus/pull/37437

---------

Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
2024-12-06 14:50:41 +08:00
wei liu
8646bba134
fix: grant ManualCompact api doesn't work (#38096) (#38168)
issue: #38086
pr: #38096
cause ManualCompact api pass collection id in request, but RBAC requires
to check collection name, so grant ManualCompact api doesn't work.

This PR refine the ManualCompact api to accpet collection name in
request.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-12-05 16:00:42 +08:00
jaime
319f5494cd
enhance: optimize CPU usage for CheckHealth requests (#35595)
issue: #35563
pr: #35589

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-12-04 14:26:41 +08:00
sthuang
66f2dac5f5
fix: [2.4] fix grant/revoke v2 meta and unclear error messages (#38146)
cherry-pick from https://github.com/milvus-io/milvus/pull/38110,
https://github.com/milvus-io/milvus/pull/38130
related issue: https://github.com/milvus-io/milvus/issues/37031

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2024-12-03 22:06:41 +08:00
wei liu
b29237e5d5
enhance: Add collection id to search request count metrics (#38069) (#38144)
pr: #38069 #38167

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-12-03 18:16:39 +08:00
XuanYang-cn
c32ad6573c
enhance: [24]Increase task capacity and clean illegal task (#37896) (#38095)
1. taskQueueCapacity 256 is too small for production when we want to
re-write the entire collection

2. tasks should be cleaned when unable to recover, or the meta will
remain in etcd forever later.

pr: #37896

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-12-02 11:58:38 +08:00
yihao.dai
913a00911b
enhance: [2.4] Reduce GetIndexInfos calls (#37840)
Batch `GetIndexInfos` calls for segments to reduce RPC calls.

issue: https://github.com/milvus-io/milvus/issues/37634

pr: https://github.com/milvus-io/milvus/pull/37695

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-11-28 14:38:37 +08:00
Gao
165afbba91
enhance: support retry search when topk is reduced and result not enough (#37093)
issue: #35576 
pr: #35645

---------

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2024-11-28 10:12:37 +08:00
jaime
09a7b55c87
enhance: set the maximum database configuration to be refreshable (#37932)
pr: #37931

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-11-27 11:26:36 +08:00
congqixia
af4e008cd1
enhance: [2.4] Add thread watcher to provide actual thread num (#37905) (#37921)
Cherry pick from master
pr: #37905 

Related to #37904

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-11-27 11:24:36 +08:00
wei liu
93063ce1f9
fix: Prevent simultaneous balance of segments and channels (#37850) (#37939)
issue: #33550
pr: #37850
balance segment and balance segment execute at same time, which will
cause bounch of corner case.

This PR disable simultaneous balance of segments and channels

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-11-26 10:26:40 +08:00
sthuang
d8f1af68e9
enhance: [2.4] RBAC built in privilege groups and grant v2 (#37787)
cherry-pick from master: https://github.com/milvus-io/milvus/pull/37720,
https://github.com/milvus-io/milvus/pull/37785
issue: https://github.com/milvus-io/milvus/issues/37031

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2024-11-25 11:24:54 +08:00
wei liu
ff6e8e2f2b
fix: [skip e2e] unstable ut TestResourceManager (#37761) (#37936)
issue: #37760
pr: #37761

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-11-25 11:06:34 +08:00
congqixia
4aca68a739
enhance: Bump milvus & proto verison to v2.4.17 (#37920)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-11-22 14:08:34 +08:00
zhenshan.cao
9b3de3ac3e
fix: Revert "enhance: [2.4] Enable RemoteLoad l0 forward policy" (#37875)
issue https://github.com/milvus-io/milvus/issues/35303
pr: https://github.com/milvus-io/milvus/pull/37867
This reverts commit cdf703aabc2ec7e4addded68e808ba6add3ab2cb.

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-11-22 12:40:33 +08:00
congqixia
a10f95d71c
enhance: Bump milvus & proto version to v2.4.16 (#37762)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-11-18 20:36:31 +08:00
yihao.dai
13f83df019
enhance: [2.4] Remove segment-level tag from monitoring metrics (#37737)
When there are a large number of segments, the metrics consume a lot of
memory. This PR Remove segment-level tag from monitoring metrics.

issue: https://github.com/milvus-io/milvus/issues/37636

pr: https://github.com/milvus-io/milvus/pull/37696

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-11-16 23:04:33 +08:00
congqixia
cdf703aabc
enhance: [2.4] Enable RemoteLoad l0 forward policy by default (#37678) (#37713)
Cherry-pick from master
pr: #37678
Related to #35303

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-11-15 18:28:31 +08:00
smellthemoon
b3e6482367
enhance: add search params in search request in restful(#36304) (#37673)
pr: #36304 
pr: #36714 
pr: #36448

---------

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-11-15 17:54:30 +08:00
congqixia
e222289038
fix: [2.4] Store default value if ErrKeyNotFound is returned (#37691) (#37705)
Cherry-pick from master
pr: #37691
Related to #37690

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-11-15 14:50:32 +08:00
congqixia
d073f322a4
enhance: [2.4] Add cgo call metrics for load/write API (#37405) (#37627)
Cherry-pick from master
pr: #37405

Cgo API cost is not observerable since not metrics is related to them.
This PR add metrics for some sync cgo call related to load & write

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-11-13 13:58:30 +08:00
wei liu
6dc879b1e2
enhance: Enable node assign policy on resource group (#36968) (#37588)
issue: #36977
pr: #36968
with node_label_filter on resource group, user can add label on
querynode with env `MILVUS_COMPONENT_LABEL`, then resource group will
prefer to accept node which match it's node_label_filter.

then querynode's can't be group by labels, and put querynodes with same
label to same resource groups.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-11-13 11:10:29 +08:00