admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-02-02 01:06:41 +08:00
Code Issues Packages Projects Releases Wiki Activity
18,686 Commits 146 Branches 196 Tags
Commit Graph

79 Commits

Author SHA1 Message Date
congqixia
69a82acc46
enhance: [Cherry-pick] Set delete scope for LoadSegment streaming data (#30245) (#30367) 
Cherry pick from master
pr: #30245
See also #29474

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2024-02-02 16:05:06 +08:00
chyezh
c8e3a48214
fix: querynode num entity metric is broken by illegal label (#29949) 
issue: #29766
also see pr: #29825
pr: #29948

Signed-off-by: chyezh <ye.zhen@zilliz.com>
 2024-01-14 10:22:59 +08:00
congqixia
c21229b7bb
enhance: [cherry-pick] add trace span for wait tsafe (#29911) (#29929) 
Cherry-pick from master
pr: #29911 
Add tracing span for search/query operation waiting tsafe duration

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2024-01-12 20:17:01 +08:00
zhenshan.cao
7cf2be09b5
fix: Restore the MVCC functionality. (#29749) (#29802) 
When the TimeTravel functionality was previously removed, it
inadvertently affected the MVCC functionality within the system. This PR
aims to reintroduce the internal MVCC functionality as follows:

1. Add MvccTimestamp to the requests of Search/Query and the results of
Search internally.
2. When the delegator receives a Query/Search request and there is no
MVCC timestamp set in the request, set the delegator's current tsafe as
the MVCC timestamp of the request. If the request already has an MVCC
timestamp, do not modify it.
3. When the Proxy handles Search and triggers the second phase ReQuery,
divide the ReQuery into different shards and pass the MVCC timestamp to
the corresponding Query requests.

issue: #29656
pr: #29749

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
 2024-01-11 14:42:49 +08:00
yah01
e7e4561da8
fix: the entities num metric may be contributed more than once (#29767) (#29825) 
the growing segments contribute to this metric while inserting and
putting into the manager, but the current impl inserts data before
putting the segments into manager, which leads to double contributions

fix: #29766
pr: #29767

Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2024-01-11 10:24:51 +08:00
yah01
3c3fc160e9
fix: make the entity num metric accurate (#29643) (#29644) 
fix https://github.com/milvus-io/milvus/issues/29642
pr: #29643

Signed-off-by: yah01 <yang.cen@zilliz.com>
 2024-01-04 19:26:47 +08:00
MrPresent-Han
757834602a
enhance: add param for bloomfilter(#29388) (#29614) 
related: https://github.com/milvus-io/milvus/issues/29388
pr: https://github.com/milvus-io/milvus/pull/29490

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
 2024-01-02 18:58:47 +08:00
congqixia
dd52a674aa
enhance: [cherry-pick] add ctx for HandleCStatus and callers (#29517) (#29546) 
Cherry-pick from master
pr: #29517 
See also #29516

Make `HandleCStatus` print trace id for better logging

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-12-28 10:20:47 +08:00
congqixia
14d8b1fe85
fix: [Cherry-pick] Add scope limit for querynode DeleteRequest (#29476) 
Cherry-pick from master
pr: #29474 
See also #27515

When Delegator processes delete data, it forwards delete data with only
segment id specified. When two segments has same segment id but one is
growing and the other is sealed, the delete will be applied to both
segments which causes delete data out of order when concurrent load
segment occurs.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-12-26 16:40:50 +08:00
congqixia
f25d1f9b2c
enhance: [cherry-pick] change protection to RLock for loadStreamDelete (#29452) 
Cherry-pick from master
pr: #29450 
See also #29332

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-12-25 23:27:01 +08:00
congqixia
9050b236e4
fix: [cherry-pick] delegator may mark segment offline by mistake (#29344) 
cherry-pick from master
pr: #29343
See also #29332

The segment may be released before or during the request when delegator
tries to forward delete request to yet. Currently, these two situation
returns different error code.

In this particular case, ErrSegmentNotLoaded and ErrSegmentNotFound
shall both be ignored preventing return search service unavailable by
mistake.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-12-20 21:16:41 +08:00
Gao
ccca932cc6
fix: [2.3] correct autoindex segment num (#28429) 
issue: #28386 
pr: #28387

Signed-off-by: chasingegg <chao.gao@zilliz.com>
 2023-11-28 19:24:26 +08:00
wei liu
4558af94d5
fix retry on offline node (#28079) (#28139) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-11-03 16:00:17 +08:00
congqixia
994bb6991b
Refine offline segments logic in shard delegator (#28073) (#28084) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-11-01 23:18:17 +08:00
congqixia
3c716717b6
Add ctx parameter for tsafe pkg & NewDelegator method (#27877) (#28075) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-11-01 23:14:35 +08:00
wei liu
8041fc3c75
avoid add empty growing segment to delegator distribution (#27930) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-10-26 10:10:10 +08:00
aoiasd
9ba79a97e4
Add some log for delete task when it need query (#27317) 
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
 2023-10-24 14:54:12 +08:00
yihao.dai
d9431266bb
Fix panic at loadSegment during rolling upgrade (#27671) 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
 2023-10-13 16:31:35 +08:00
yah01
be980fbc38
Refine state check (#27541) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-10-11 21:01:35 +08:00
wei liu
0695c88844
refine_log_of_update_target_version (#27572) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-10-11 06:51:33 +08:00
congqixia
258e1ccd66
Refine querynode scheduler lifetime (#26915) 
This PR refines scheduler lifetime control:
- Move private tri-state into lifetime package
- Make scheduler block incoming "Add" task
- Make scheduler Stop wait until all previously accepted task done

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-28 10:21:26 +08:00
congqixia
8c59dba329
Refine queryHook mockery (#27394) 
This PR move `QueryHook` interface to `optimizers` pkg
Update all mockery generated files to latest
Add makefile entry for `QueryHook`

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-28 10:01:26 +08:00
SimFG
26f06dd732
Format the code (#27275) 
Signed-off-by: SimFG <bang.fu@zilliz.com>
 2023-09-21 09:45:27 +08:00
congqixia
cc9974979f
Add staticcheck linter and fix existing problems (#27174) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-19 10:05:22 +08:00
Xiaofan
e51cb739eb
Remove some logs in querynode delegator (#27156) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2023-09-18 10:57:20 +08:00
aoiasd
e107d0794c
support complex delete expression (#25752) 
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
 2023-09-12 10:19:17 +08:00
congqixia
2a5d574a0d
Fix querynodev2 concurrent load logic (#26959) 
Fix logic error from #26926
function `waitSegmentLoadDone` shall return error when context is done

Make delegator control concurrency for each same segment
Related to #26908

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-10 07:41:18 +08:00
XuanYang-cn
7f1ae35e72
Add timeout in dispatcher, AsConsumer and Seek (#26686) 
See also: #25309

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
 2023-09-08 09:51:17 +08:00
congqixia
af5c01082b
Refine delegator lifetime control (#26881) 
- Add SafeChan interface in lifetime package
- Embed SafeChan into  interface
- Replace private lifetime struct in delegator package with
- Refine delegator on-going task lifetime control and wait all accepted task done
- Fix potential goroutine leakage from  if delegator closed concurrently

/kind improvement

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-07 10:11:15 +08:00
MrPresent-Han
528948559f
fix false load failure for long unserviable period(#26813) (#26818) 
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
 2023-09-06 12:57:15 +08:00
congqixia
4b58c71908
Add ctx parameter for organizeTask and GetWorker method (#26835) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-05 10:05:48 +08:00
congqixia
1a8cf5c415
Organize all mockery generation commands in Makefile (#26826) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-04 21:19:48 +08:00
yah01
3349db4aa7
Refine errors to remove changes breaking design (#26521) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-09-04 09:57:09 +08:00
congqixia
89fc9aad82
Improve sync target version logic (#26630) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-08-29 23:12:27 +08:00
wei liu
7af0f7d90c
avoid concurrent sub/unsub on same channel (#26454) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-08-23 10:10:22 +08:00
congqixia
855a04539a
Set delegator lastUpdateTs to startTs (#26416) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-08-17 12:24:18 +08:00
wei liu
23baecd70f
set sealed segment to unreadable before sync target version (#26338) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-08-15 17:27:35 +08:00
Enwei Jiao
7d61355ab0
Refactor log for Query (#26310) 
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
 2023-08-14 18:57:32 +08:00
wei liu
b47a72bfcf
fix set dirty segment distribution to leader view (#26180) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-08-11 11:21:32 +08:00
congqixia
eea9197306
Perform alter distribution under mutex protection (#26229) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-08-09 13:05:15 +08:00
yah01
99c633954a
Downgrade the log level in search path (#26188) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-08-08 18:35:14 +08:00
Bingyi Sun
54c0e64059
Fix search on empty segments set bug (#26136) 
Signed-off-by: sunby <sunbingyi1992@gmail.com>
 2023-08-08 11:17:08 +08:00
wei liu
a132122370
fix time unit in insert/delete cost metrics value (#25893) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-07-25 15:07:01 +08:00
aoiasd
b533c68632
Forbid update checkpoint without msgID (#25694) 
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
 2023-07-25 10:43:04 +08:00
wei liu
0e26486abc
fix segment num in log (#25876) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-07-25 09:13:00 +08:00
wei liu
fc19b85a40
fix count(*）retrieve redundant growing segment (#25825) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-07-24 14:09:00 +08:00
wei liu
32827f538a
add metrics for delegator insert/delete cost (#25733) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-07-21 15:30:59 +08:00
Cai Yudong
9a4761dcc7
Remove binary metrics TANIMOTO/SUPERSTRUCTURE/SUBSTRUCTURE (#25708) 
Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
 2023-07-19 16:16:58 +08:00
congqixia
cc71e065e3
Support load index after segment loaded (#25567) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-07-18 10:51:19 +08:00
Zhihong Yu
a7023ab3cc
Narrow the scope of deleteMut lock in loadStreamDelete (#25436) 
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
 2023-07-17 09:30:34 +08:00