516 Commits

Author SHA1 Message Date
SwechchhaSinha
b34f6588ee
fix: [cherry-pick] changes to propagate traceid from client (#32264) (#34640)
https://github.com/milvus-io/milvus/issues/32321
PR merged to master -
[#32264](https://github.com/milvus-io/milvus/pull/32264)

Issue Description:
Tracing is an important means of identifying bottleneck points in a
system and is crucial for debugging production issues. Milvus(or any DB)
is generally the most downstream system for an user call -- a user call
can originate from UI and pass through multiple components, in
micro-services architecture, before reaching Milvus. So, when an user
experiences a glitch, one would debug the call trace via logs using a
common trace id. As of now, Milvus generates a new trace id for every
call and this request is to make sure client can pass the trace id which
will be used for all the logs across the Milvus sub-components so that
one can fetch logs for a user call across the components -- including
Milvus.

Signed-off-by: Shreesha Srinath Madogaran <smadogaran@salesforce.com>
Signed-off-by: Swechchha Sinha <swechchha.sinha@salesforce.com>
Co-authored-by: madogar <36537062+madogar@users.noreply.github.com>
Co-authored-by: Shreesha Srinath Madogaran <smadogaran@salesforce.com>
2024-08-16 14:12:54 +08:00
Chun Han
20e26588af
fix: enable limiter for restful server(#35350) (#35354)
related: #35350

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
2024-08-13 15:36:21 +08:00
congqixia
032096150d
enhance: Bump milvus version to v2.3.21 (#35419)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-13 11:44:20 +08:00
wei liu
e5681e5b9c
enhance: make delegator delete buffer holding all delete from cp (#29626) (#35074)
See also #29625
pr: #29626 

This PR:
- Add a new implemention of `DeleteBuffer`: listDeleteBuffer
  - holds cacheBlock slice
  - `Put` method append new delete data into last block
  - when a block is full, append a new block into the list
- Add `TryDiscard` method for `DeleteBuffer` interface
  - For doubleCacheBuffer, do nothing
- For listDeleteBuffer, try to evict "old" blocks, which are blocks
before the first block whose start ts is behind provided ts
- Add checkpoint field for `UpdateVersion` sync action, which shall be
used to discard old cache delete block

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Co-authored-by: congqixia <congqi.xia@zilliz.com>
2024-08-09 18:48:18 +08:00
Jiquan Long
d8bfc077a4
enhance: add metric to record disk quota (#35305) (#35320)
https://github.com/milvus-io/milvus/issues/35177
pr: https://github.com/milvus-io/milvus/pull/35305

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-08-08 10:06:17 +08:00
yihao.dai
20dca130c6
enhance: [cherry-pick] Retry on incomplete query result (#35061)
This PR cherry-picks the following PRs:

1. Return specific error codes when encountering incomplete requery
results error. https://github.com/milvus-io/milvus/pull/31343
2. Retry on incomplete requery result in proxy.
https://github.com/milvus-io/milvus/pull/31713

issue: https://github.com/milvus-io/milvus/issues/34820

pr: https://github.com/milvus-io/milvus/pull/31343,
https://github.com/milvus-io/milvus/pull/31713

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-08-05 15:22:16 +08:00
wei liu
ff7c1a79ee
enhance: Reduce delegator memory overloaded factor to 0.1 (#35092) (#35165)
pr: #35092

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-08-05 15:12:16 +08:00
Jiquan Long
6ea7147321
enhance: add metric to record maxInsertRate and queryNodeMemoryHighWaterLevel (#35185) (#35193)
pr: https://github.com/milvus-io/milvus/pull/35185
fix: https://github.com/milvus-io/milvus/issues/35177

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-08-05 10:26:17 +08:00
Gao
0a122533d0
enhance: change autoindex default metric type (#34328)
issue: #34304 
pr: #34261

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2024-08-02 16:22:20 +08:00
yihao.dai
289336a617
enhance: Avoid panic due to nil schema (#35063) (#35065)
/kind improvement

issue: https://github.com/milvus-io/milvus/discussions/25620

pr: https://github.com/milvus-io/milvus/pull/35063

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-07-30 20:19:49 +08:00
Jiquan Long
256817da2d
feat: record the number of times milvus turns into force-deny-writing states (#34960) (#34990)
/kind improvement
fix: https://github.com/milvus-io/milvus/issues/34961
pr: #34960

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-07-25 15:45:46 +08:00
congqixia
a5deaa1d4b
enhance: Bump milvus verions to v2.3.20 (#34915)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-23 14:57:43 +08:00
shaoting-huang
abc7c84699
enhance: Upgrade go version from 1.20 to 1.21 (#34759)
issue https://github.com/milvus-io/milvus/issues/32982

related pr in master:
pr: https://github.com/milvus-io/milvus/pull/33047
https://github.com/milvus-io/milvus/pull/33150
https://github.com/milvus-io/milvus/pull/33176
https://github.com/milvus-io/milvus/pull/33351
https://github.com/milvus-io/milvus/pull/33202
https://github.com/milvus-io/milvus/pull/33192

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2024-07-22 10:09:42 +08:00
Jiquan Long
08c6ab8cfb
feat: record the duration waiting in the proxy queue (#34744) (#34791)
fix: https://github.com/milvus-io/milvus/issues/34743
pr: https://github.com/milvus-io/milvus/pull/34744

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-07-19 15:39:41 +08:00
congqixia
64dc848109
enhance: Bump milvus version to v2.3.19 (#34677)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-15 16:51:38 +08:00
wei liu
79c0c78a07
enhance: Preserve fixed-size memory in delegator node for growing segment (#34602)
issue: #34595
pr: #34596

When consuming insert data on the delegator node, QueryCoord will move
out some sealed segments to manage its memory usage. After the growing
segment gets flushed, some sealed segments from other workers will be
moved back to the delegator node. To avoid the frequent movement of
segments, we estimate the maximum growing row count and preserve a
fixed-size memory in the delegator node.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-07-13 10:25:40 +08:00
congqixia
3c44248105
fix: [2.3] support set up knowhere-build-pool-size on querynode (#34647)
Cherry-pick from master
pr: #30922
Related: #29650

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Co-authored-by: MrPresent-Han <chun.han@zilliz.com>
2024-07-12 19:27:36 +08:00
yihao.dai
c46fccb3e9
fix: Prevent dispatcher merging if curTs is 0 (#34562) (#34626)
When the main dispatcher has not yet consumed data, curTs is 0. During
this time, merging dispatchers should not be allowed; otherwise, the
data of the solo dispatcher will be skipped.

issue: https://github.com/milvus-io/milvus/issues/34255

pr: https://github.com/milvus-io/milvus/pull/34562

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-07-12 15:19:36 +08:00
edward.zeng
7f3a2a278f
enhance: Refine default histogram metric bucket (#34627)
/kind improvement

pr: https://github.com/milvus-io/milvus/pull/34580

Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
2024-07-12 14:07:36 +08:00
SimFG
00b02ee6ae
enhance: [2.3] try to speed up the loading of small collections (#33863)
- issue: #33569
- pr: #33570

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-06-22 11:46:04 +08:00
congqixia
9157980232
fix: [2.3] Return record with largest timestamp for entires with same PK(#33936) (#34026)
Cherry-pick from master
pr: #33936
See also #33883

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-20 19:56:00 +08:00
congqixia
578c38a2f7
enhance: Bump milvus version to v2.3.18 (#33909)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-18 16:30:00 +08:00
aoiasd
963f601a96
enhance:[Cherry-pick] Check by proxy rate limiter when delete get data by query. (#30891) (#33794)
relate: https://github.com/milvus-io/milvus/issues/30927
pr: https://github.com/milvus-io/milvus/pull/30891

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-06-17 19:36:00 +08:00
wei liu
284e79cf3a
enhance: Execute bloom filter apply in parallel to speed up process delete (#33870)
issue: #33610
pr: #33611 #33793

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-06-17 12:06:04 +08:00
congqixia
cc1bf63336
enhance: Bump milvus version to v2.3.17 (#33509)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-31 17:29:45 +08:00
Chun Han
0d4ee287e1
fix: query iterator lack results(#33137) (#33468)
related: #33137
pr: https://github.com/milvus-io/milvus/pull/33422

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2024-05-31 13:54:07 +08:00
congqixia
0ae4c8a11c
enhance: Bump milvus & proto version to v2.3.16 (#33127)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-21 16:39:40 +08:00
congqixia
e325ec0a35
enhance: [2.3]Try LatestMessageID when checkpoint unmarshal fails (#33159)
Cherry-pick from master
pr: #33158
See also #33122

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-21 14:13:40 +08:00
zhenshan.cao
23e7155a48
fix: avoid memoryleak in rendezvousFlushManager (#33112)
issue: https://github.com/milvus-io/milvus/issues/33110

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-05-20 22:19:40 +08:00
congqixia
f848e82971
enhance: [2.3] Add param item to ignore bad message id in checkpoint (#33128)
Cherry-pick from master
pr: #33123
See also #33122

This pr add param item `mq.ignoreBadPosition` to control behavior when
mq failed to parse message id from checkpoint

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-20 11:31:39 +08:00
congqixia
39b07adff1
enhance: Bump milvus & proto version to v2.3.15 (#32947)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-10 19:41:31 +08:00
wayblink
996b79c76c
enhance: Add channelCPs in FlushResponse (#32683)
#32609

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2024-05-10 09:55:31 +08:00
congqixia
a631856321
fix: [2.3] Validate num of rows for insert field data with schema (#32770) (#32845)
Cherry-pick from master
pr: #32770 
See also #32769

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-08 16:25:30 +08:00
SimFG
3a7154b796
enhance: [2.3] add the skip auto id and partition key check config (#32671)
/kind improvement
issue: #32591
pr: #32592

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-04-29 10:19:31 +08:00
aoiasd
bf2c5def8d
enhance: [Cherry-Pick] access log support get sdk type by user agent (#30760) (#32554)
Support get sdk type by user agent when we can't get sdk version by
connection in access log.

---------
pr: https://github.com/milvus-io/milvus/pull/30760

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-04-25 16:37:27 +08:00
congqixia
c36b54cb57
enhance: [2.3] Use different interval for gc scan (#31363) (#32551)
Cherry-pick from master
pr: #31363
See also #31362

This PR make datacoord garbage collection scan operation using differet
interval than other opeartion.

This interval is a newly added param item, which default value is 7*24
hours.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-25 16:07:26 +08:00
foxspy
560e167214
fix: add score compute consistency config for knowhere (#32584)
issue: #32583 
/kind branch-feature

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
2024-04-25 14:07:25 +08:00
congqixia
65003099d8
enhance: Bump milvus version to v2.3.14 (#32455)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-19 13:57:23 +08:00
Xiaofan
37e5728229
fix: reduce didn't handle offset without limit and reduceStopForBest … (#32087)
fix #32059
pr: #32089

this pr fix two issues:
1. offset is not handled correctly without specify a limit
2. reduceStopForBest doesn't guarantee to return limit result even if
there are more result when there is small segment

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
2024-04-10 21:20:37 -07:00
wei liu
9d4ce6e581
enhance: Add restful api for devops to execute rolling upgrade (#29998) (#31846)
issue: #29261
pr: #29998
This PR Add restful api for devops to execute rolling upgrade, including
suspend/resume balance and manual transfer segments/channels.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-04-10 19:47:20 +08:00
cqy123456
47f767cf32
enhance: remove float16 in 2.3 branch (#31720)
issue: https://github.com/milvus-io/milvus/issues/31696

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2024-03-30 10:49:13 +08:00
groot
91cdada12a
fix: minio ssl compatible issue (#31619)
issue: https://github.com/milvus-io/milvus/issues/30709
pr: https://github.com/milvus-io/milvus/pull/31607

Signed-off-by: yhmo <yihua.mo@zilliz.com>
2024-03-27 14:41:20 +08:00
congqixia
f9c8cd8e7b
enhance: Bump milvus & proto version to v2.3.13 (#31579)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-03-25 18:03:10 +08:00
PowderLi
f2f0d44a5d
feat: [cherry-pick] restful phase two (#30430)
issue: #28348 #29732

Support to trace the grpc request, pr: #28349
Support to trace restful request and request error, pr: #28685

restful phase two, pr: #29728 #30343
include: collections, entities, partitions, users, roles, indexes,
aliases, import jobs

---------

Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: PowderLi <min.li@zilliz.com>
Co-authored-by: SimFG <bang.fu@zilliz.com>
2024-03-25 10:39:09 +08:00
Jiquan Long
ab059bb064
enhance: add more metrics (#31271) (#31511)
/kind improvement
pr: #31271 
fix: https://github.com/milvus-io/milvus/issues/31272

This pr add more metrics, which are:

Slow query count, which the duration considered as slow can be
configurable;
Number of deleted entities;
Number of entities per collection;
Number of loaded entities per collection;
Number of indexed entities;
Number of indexed entities, per collection, per index and whether it's a
vetor index;
Quota states (LongTimeTickDelay, MemoryExhuasted, DiskQuotaExhuasted)
per database;

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-03-22 16:11:07 +08:00
wei liu
c8658d17f8
fix: Grpcclient return unrecoverable error (#31256) (#31452)
issue: #31222
pr: #31256

grpcclient's `call` func return a unrecoverable error, then the caller's
retry policy also breaks due to this unrecoverable error.

This PR introduce `retry.Handle`, the new func use `func() (bool,
error)` as input parameters, which return `shouldRetry` directly, to
avoid grpcclient return a unrecoverable error

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-03-21 11:59:12 +08:00
groot
1ca7cba222
enhance: Support MinIO TLS connection (#31292)
issue: https://github.com/milvus-io/milvus/issues/30709
master pr: #31311

Signed-off-by: yhmo <yihua.mo@zilliz.com>
Co-authored-by: Chen Rao <chenrao317328@163.com>
2024-03-21 11:15:20 +08:00
congqixia
94f3aec80a
enhance: [Cherry-pick] Add metrics for querycoord current target cp lag (#31391) (#31463)
Cherry-pick from master
pr: #31391 #31399
See also #31390

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-03-21 10:17:07 +08:00
congqixia
86e347a1a4
enhance: [2.3] Cache formatted key for param item (#31388) (#31402)
Cherry-pick from master
pr: #31388 
See also #30806

`formatKey` may cost lots of CPU on string processing under high QPS
scenario, this PR adds a formattedKeys cache preventing string operation
in each param get value.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-03-19 19:25:10 +08:00
congqixia
4e48a4de0e
enhance: Bump milvus & proto version to v2.3.12 (#31193)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-03-14 19:09:04 +08:00