922 Commits

Author SHA1 Message Date
SimFG
355dc82822
fix: [2.4] deny to set the mmap param for the alter index api (#39521)
- issue: #39517
- pr: #39518

Signed-off-by: SimFG <bang.fu@zilliz.com>
2025-01-23 11:23:08 +08:00
yihao.dai
86ae07d705
enhance: [2.4] Limit the maximum number of segments restored and fail the job if saving the binlog fails (#39473)
1. Limit the maximum number of restored segments to 1024.
2. Fail the import job if saving binlog fails.
3. Fail the import job if saving the import task fails to prevent
repeatedly generating dirty importing segments.
4. Update proto.

issue: https://github.com/milvus-io/milvus/issues/39331

pr: https://github.com/milvus-io/milvus/pull/39344

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2025-01-21 15:55:05 +08:00
Xianhui Lin
6111a0dc22
enhance: [2.4]Add schema update time verification for insert and upsert to use cache (#39405)
enhance: Add schema update time verification for insert and upsert to
use cache
issue: https://github.com/milvus-io/milvus/issues/39093
Related to pr: https://github.com/milvus-io/milvus/pull/39096

Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
2025-01-21 10:19:11 +08:00
aoiasd
cc8e34c0b8
enhance: [2.4] remain token after authorize (#39454)
pr: https://github.com/milvus-io/milvus/pull/39453

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2025-01-20 20:27:17 +08:00
congqixia
34c7b08344
enhance: Bump milvus & proto version to v2.4.21 (#39328)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-16 14:27:11 +08:00
SimFG
c6480ee15a
feat: [2.4] root privileges can be customized (#39325)
- issue: #39184
- pr: #39191

Signed-off-by: SimFG <bang.fu@zilliz.com>
2025-01-16 14:17:03 +08:00
congqixia
ca7ecdbc6a
enhance: [2.4] Unify LoadStateLock RLock & PinIf (#39206) (#39290)
Cherry-pick from master
pr: #39206 #39308
Related to #39205

This PR merge `RLock` & `PinIfNotReleased` into `PinIf` function
preventing segment being released before any Read operation finished.

---------

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-16 02:03:02 +08:00
yihao.dai
995d5e1cf6
enhance: [2.4] Optimize GetLocalDiskSize and segment loader mutex (#38908)
1. Make the segment loader lock protect only the resource.
2. Optimize GetDiskUsage to avoid excessive overhead.

issue: https://github.com/milvus-io/milvus/issues/37630

pr: https://github.com/milvus-io/milvus/pull/38599

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2025-01-14 21:41:00 +08:00
zhenshan.cao
3474c5962f
enhance: Add primary field name in SearchResult and QueryResults (#39223)
issue: https://github.com/milvus-io/milvus/pull/39220
pr: https://github.com/milvus-io/milvus/pull/39220

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2025-01-14 16:15:00 +08:00
SimFG
0f4e1d1bf8
fix: [2.4] use the object heap to keep the min ddl ts order (#39193)
- issue: #39002
- pr: #39118

Signed-off-by: SimFG <bang.fu@zilliz.com>
2025-01-14 14:23:05 +08:00
congqixia
5d919b077b
enhance: [2.4] Bump golang/x/net to v0.33 fixing security alarm (#39209)
Cherry pick from master
pr: #38850 

Related to https://github.com/milvus-io/milvus/security/dependabot/106

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-13 19:35:00 +08:00
sthuang
e56399720d
fix: [2.4] rbac custom group privilege level check (#39194)
cherry-pick from master: https://github.com/milvus-io/milvus/pull/39164
related: related: https://github.com/milvus-io/milvus/issues/39086

---------

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2025-01-13 13:58:58 +08:00
congqixia
29a0e31c2f
fix: [2.4] Return io error other than NotExist refreshing config (#38924) (#39073)
Cherry-pick from master
pr: #38924 
Related to #38923

This PR:

- Check whether `os.Stat` config file error is io.ErrNotExist
- Panic when get config return error during Milvus initialization

---------

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-10 14:09:04 +08:00
Zhen Ye
782cd749bb
enhance: make new go package to manage proto (#39129)
issue: #39095
pr: #39114

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2025-01-10 10:13:01 +08:00
cai.zhang
3b99485615
enhance: clean compaction task in compactionHandler (#38170) (#38848)
issue: #35711, #38811 

master pr: #38170
master pr:  #38925

---------

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Co-authored-by: wayblink <anyang.wang@zilliz.com>
2025-01-08 15:58:57 +08:00
aoiasd
b3410f52d9
enhance:[Cherry-pick] report restful and grpc auth info to hook (#38892)
pr: https://github.com/milvus-io/milvus/pull/38112
https://github.com/milvus-io/milvus/pull/38943

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2025-01-06 15:10:57 +08:00
Xiaofan
a3ea66f621
fix: drop partition can not be successful if load failed[2.4] (#38871)
related to https://github.com/milvus-io/milvus/issues/38649
pr: #38793
when partition load failed, the partition drop will also fail due to the
wrong error message

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
2025-01-02 09:54:54 +08:00
Patrick Weizhi Xu
ccbe6fc646
enhance: [2.4] add param for tuning max VARCHAR length (#38890)
issue: #38882
pr: https://github.com/milvus-io/milvus/pull/38884

Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
(cherry picked from commit 72fecd4f34637a78c1cbc789ee3d97797b458fc0)
2024-12-31 18:19:19 +08:00
yihao.dai
163b258a68
enhance: Bump milvus version to v2.4.20 (#38889)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-12-31 16:33:56 +08:00
foxspy
c0e781072e
fix: [2.4] enable mmap for sparse index (#38849)
issue: #29419
/kind branch-feature

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
2024-12-31 16:28:53 +08:00
SimFG
bd67acc68a
enhance: [2.4] update expr version to support method parameter type conversion (#38781)
/kind improvement
issue: #38780

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-12-30 15:59:06 +08:00
congqixia
fec92e9fa6
enhance: Bump milvus & proto version to v2.4.19 (#38773)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-12-26 16:34:50 +08:00
jaime
b496fa1914
fix: Revert Expose metrics of stanby coordinators (#27698) (#38742)
issue: #38608
pr: #38620

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-12-26 10:16:51 +08:00
cai.zhang
e8eea587d5
enhance: [2.4] Revert clean compaction task in compactionHandler (#38753)
Reverts milvus-io/milvus#38584

issue: https://github.com/milvus-io/milvus/issues/35711

master pr: https://github.com/milvus-io/milvus/pull/38170

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-12-25 21:44:50 +08:00
XuanYang-cn
7f1116566e
enhance: [24]Add missing delete metrics (#38634) (#38746)
Add 2 counter metrics:
- Total delete entries from deltalog:
milvus_datanode_compaction_delete_count
- Total missing deletes: milvus_datanode_compaction_missing_delete_count

See also: #34665
pr: #38634

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-12-25 19:44:52 +08:00
sthuang
ef6aae86cf
fix: [2.4] fix privilege group list and list collections (#38698)
cherry-pick from: https://github.com/milvus-io/milvus/pull/38684
related: https://github.com/milvus-io/milvus/issues/37031

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2024-12-25 14:32:51 +08:00
Zhen Ye
5d2f454ce4
enhance: add multiply factor when loading index (#38721)
issue: #38715
pr: #38716

Signed-off-by: chyezh <chyezh@outlook.com>
2024-12-25 10:50:58 +08:00
cai.zhang
afaabc2a38
enhance: [2.4] clean compaction task in compactionHandler (#38170) (#38584)
issue: #35711

master pr: #38170

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Co-authored-by: wayblink <anyang.wang@zilliz.com>
2024-12-24 15:34:50 +08:00
congqixia
451deb3298
enhance: Bump milvus & proto version to v2.4.18 (#38552)
mockery update related to #31779

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-12-19 10:32:47 +08:00
sthuang
6364e323de
fix: [2.4] privilege group privileges granted from ClusterAdmin permission denied (#38530)
cherry-pick from master: https://github.com/milvus-io/milvus/pull/38514
related: https://github.com/milvus-io/milvus/issues/38460

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2024-12-18 13:20:46 +08:00
jaime
ee7dffc758
fix: sync task still running after DataNode has stopped (#38441)
issue: #38319
pr: #38377

---------

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-12-18 12:38:47 +08:00
Zhen Ye
2e2f61538f
fix: kafka use shared channel to receive produce result (#38534)
issue: #38531
pr: #38532

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2024-12-18 10:36:49 +08:00
congqixia
f878dbf8d2
enhance: [2.4] Bump golang/x/crypto for all packages (#38445) (#38470)
Cherry pick from master
pr: #38445
Related to #38446
See also https://github.com/milvus-io/milvus/security/dependabot/103

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-12-16 14:36:45 +08:00
Xianhui Lin
352e51a88d
enhance: [2.4]alterdatabase support delete property (#38450)
alterdatabase support delete property
issue: https://github.com/milvus-io/milvus/issues/38379

---------

Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
2024-12-15 17:40:44 +08:00
SimFG
4c896c628c
fix: [2.4] replicate message exception when the ttMsgEnable config is changed dynamically (#38440)
- issue: #38177
- pr: #38178

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-12-14 23:24:51 +08:00
Zhen Ye
1da4ac4159
enhance: add detail, replica count for resource group (#38315)
issue: #30647
pr: #38314

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2024-12-13 14:14:49 +08:00
wei liu
83e162f5f1
enhance: Enable score based balance channel policy (#38143) (#38378)
issue: #38142
pr: #38143
current balance channel policy only consider current collection's
distribution, so if all collections has 1 channel, and all channels has
been loaded on same querynode, after querynode num increase, balance
channel won't be triggered.

This PR enable score based balance channel policy, to achieve:
1. distribute all channels evenly across multiple querynodes
2. distribute each collection's channel evenly across multiple
querynodes.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-12-13 10:28:44 +08:00
SimFG
df73f93126
enhance: [2.4] pick some master improvements to 2.4 branch (#38128)
- issue: #38127

master pr list:
- #37759
- #37835
- #37845
- #37874
- #37894
- #37969
- #37983
- #38005
- #38035

---------

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-12-13 10:24:45 +08:00
sthuang
19818c55b2
enhance: [2.4] add privilege group privilege into built-in privilege group (#38408)
cherry-pick from master: https://github.com/milvus-io/milvus/pull/38393
related issue: https://github.com/milvus-io/milvus/issues/37031

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2024-12-12 19:56:43 +08:00
Gao
d7e926f1cb
enhance: [2.4] support recall estimation (#38064)
issue: #37899 
pr: #38017

---------

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2024-12-11 20:40:48 +08:00
jaime
7cee01af44
fix: stream connection leak in case of error (#38321)
issue: #38318
pr: #38320

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-12-11 15:38:49 +08:00
Buqian Zheng
25249fd26e
enhance: [2.4] add metrics for counting number of nun-zeros/tokens of sparse search (#38328)
sparse vectors may have arbitrary number of non zeros and it is hard to
optimize without knowing the actual distribution of nnz. this PR adds a
metric for analyzing that.

pr: #38329 

also fixed a bug of sparse when searching by pk

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
2024-12-11 10:00:43 +08:00
Zhen Ye
6b310e16dc
enhance: remove the rpc layer of coordinator when enabling standalone or mixcoord (#38207)
issue: #37764
pr: #37815 
also see: #38259

- add a local client to call local server directly for
querycoord/rootcoord/datacoord.
- enable local client if milvus is running mixcoord or standalone mode.
- after removing rpc layer from mixcoord, the querycoord at standby mode
will be blocked forever of deployment rolling

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2024-12-10 20:38:44 +08:00
cai.zhang
ddc40a7266
enhance: [2.4]Determine the number of buffers based on the resource limits of the DataNode (#38210)
issue: #28410 

master pr: #38209

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-12-08 17:54:41 +08:00
Xianhui Lin
a51647569b
enhance: [2.4]alterindex & altercollection supports altering properties (#38111)
enhance :

alterindex delete properties
We have introduced a new parameter deleteKeys to the alterindex
functionality, which allows for the deletion of properties within an
index. This enhancement provides users with the flexibility to manage
index properties more effectively by removing specific keys as needed.
altercollection delete properties
We have introduced a new parameter deleteKeys to the altercollection
functionality, which allows for the deletion of properties within an
collection. This enhancement provides users with the flexibility to
manage collection properties more effectively by removing specific keys
as needed.
3.support altercollectionfield
We currently support modifying the fieldparams of a field in a
collection using altercollectionfield, which only allows changes to the
max-length attribute.
Key Points:

New Parameter - deleteKeys: This new parameter enables the deletion of
specified properties from an index. By passing a list of keys to
deleteKeys, users can remove the corresponding properties from the
index.

Mutual Exclusivity: The deleteKeys parameter cannot be used in
conjunction with the extraParams parameter. Users must choose one
parameter to pass based on their requirement. If deleteKeys is provided,
it indicates an intent to delete properties; if extraParams is provided,
it signifies the addition or update of properties.

issue: https://github.com/milvus-io/milvus/issues/37436
pr: https://github.com/milvus-io/milvus/pull/37437

---------

Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
2024-12-06 14:50:41 +08:00
wei liu
8646bba134
fix: grant ManualCompact api doesn't work (#38096) (#38168)
issue: #38086
pr: #38096
cause ManualCompact api pass collection id in request, but RBAC requires
to check collection name, so grant ManualCompact api doesn't work.

This PR refine the ManualCompact api to accpet collection name in
request.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-12-05 16:00:42 +08:00
jaime
319f5494cd
enhance: optimize CPU usage for CheckHealth requests (#35595)
issue: #35563
pr: #35589

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-12-04 14:26:41 +08:00
sthuang
66f2dac5f5
fix: [2.4] fix grant/revoke v2 meta and unclear error messages (#38146)
cherry-pick from https://github.com/milvus-io/milvus/pull/38110,
https://github.com/milvus-io/milvus/pull/38130
related issue: https://github.com/milvus-io/milvus/issues/37031

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2024-12-03 22:06:41 +08:00
wei liu
b29237e5d5
enhance: Add collection id to search request count metrics (#38069) (#38144)
pr: #38069 #38167

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-12-03 18:16:39 +08:00
XuanYang-cn
c32ad6573c
enhance: [24]Increase task capacity and clean illegal task (#37896) (#38095)
1. taskQueueCapacity 256 is too small for production when we want to
re-write the entire collection

2. tasks should be cleaned when unable to recover, or the meta will
remain in etcd forever later.

pr: #37896

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-12-02 11:58:38 +08:00