From fef87f879cd8dd80fd0791a1920ad8dedfd67a24 Mon Sep 17 00:00:00 2001 From: bigsheeper Date: Thu, 17 Nov 2022 20:21:14 +0800 Subject: [PATCH] Disable tt delay protection (#20657) Signed-off-by: bigsheeper Signed-off-by: bigsheeper --- configs/milvus.yaml | 2 +- internal/util/paramtable/quota_param_test.go | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/configs/milvus.yaml b/configs/milvus.yaml index 5bcbc57537..ae397dcb7c 100644 --- a/configs/milvus.yaml +++ b/configs/milvus.yaml @@ -451,7 +451,7 @@ quotaAndLimits: # specific conditions, such as memory of nodes to water marker), `true` means always reject all dml requests. forceDeny: false ttProtection: - enabled: true + enabled: false # maxTimeTickDelay indicates the backpressure for DML Operations. # DML rates would be reduced according to the ratio of time tick delay to maxTimeTickDelay, # if time tick delay is greater than maxTimeTickDelay, all DML requests would be rejected. diff --git a/internal/util/paramtable/quota_param_test.go b/internal/util/paramtable/quota_param_test.go index 675fe52a09..391223c5e0 100644 --- a/internal/util/paramtable/quota_param_test.go +++ b/internal/util/paramtable/quota_param_test.go @@ -19,7 +19,6 @@ package paramtable import ( "math" "testing" - "time" "github.com/stretchr/testify/assert" ) @@ -72,8 +71,8 @@ func TestQuotaParam(t *testing.T) { t.Run("test limit writing", func(t *testing.T) { assert.False(t, qc.ForceDenyWriting) - assert.Equal(t, true, qc.TtProtectionEnabled) - assert.Equal(t, 300*time.Second, qc.MaxTimeTickDelay) + assert.Equal(t, false, qc.TtProtectionEnabled) + assert.Equal(t, math.MaxInt64, int(qc.MaxTimeTickDelay)) assert.Equal(t, defaultLowWaterLevel, qc.DataNodeMemoryLowWaterLevel) assert.Equal(t, defaultHighWaterLevel, qc.DataNodeMemoryHighWaterLevel) assert.Equal(t, defaultLowWaterLevel, qc.QueryNodeMemoryLowWaterLevel)