From fd68837f849054fd39dcccde87cbc46417282d10 Mon Sep 17 00:00:00 2001 From: "cai.zhang" Date: Tue, 7 Nov 2023 23:34:26 +0800 Subject: [PATCH] Fix bug for setting index state when indexnode connecting failed (#28220) Signed-off-by: Cai Zhang --- internal/datacoord/index_builder.go | 4 ++-- internal/datacoord/index_builder_test.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/datacoord/index_builder.go b/internal/datacoord/index_builder.go index 1fe758b08d..99d2feab2e 100644 --- a/internal/datacoord/index_builder.go +++ b/internal/datacoord/index_builder.go @@ -360,12 +360,12 @@ func (ib *indexBuilder) getTaskState(buildID, nodeID UniqueID) indexTaskState { if err != nil { log.Ctx(ib.ctx).Warn("IndexCoord get jobs info from IndexNode fail", zap.Int64("nodeID", nodeID), zap.Error(err)) - return indexTaskInProgress + return indexTaskRetry } if response.GetStatus().GetErrorCode() != commonpb.ErrorCode_Success { log.Ctx(ib.ctx).Warn("IndexCoord get jobs info from IndexNode fail", zap.Int64("nodeID", nodeID), zap.Int64("buildID", buildID), zap.String("fail reason", response.GetStatus().GetReason())) - return indexTaskInProgress + return indexTaskRetry } // indexInfos length is always one. diff --git a/internal/datacoord/index_builder_test.go b/internal/datacoord/index_builder_test.go index 5bd1f6bcb4..5a5e148be9 100644 --- a/internal/datacoord/index_builder_test.go +++ b/internal/datacoord/index_builder_test.go @@ -930,7 +930,7 @@ func TestIndexBuilder_Error(t *testing.T) { state, ok := ib.tasks[buildID] assert.True(t, ok) - assert.Equal(t, indexTaskInProgress, state) + assert.Equal(t, indexTaskRetry, state) }) t.Run("get state fail", func(t *testing.T) { @@ -955,7 +955,7 @@ func TestIndexBuilder_Error(t *testing.T) { state, ok := ib.tasks[buildID] assert.True(t, ok) - assert.Equal(t, indexTaskInProgress, state) + assert.Equal(t, indexTaskRetry, state) }) t.Run("finish task fail", func(t *testing.T) {