admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-02-02 01:06:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add log for Connect api (#24547)

Browse Source 
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
This commit is contained in:
Jiquan Long 2023-05-31 16:41:33 +08:00 committed by GitHub
parent ee45c79158
commit fccca55128
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/proxy/client_info.go
View File

@ -41,7 +41,8 @@ func (c clientInfo) getLogger() []zap.Field {
}
func (c clientInfo) ctxLogRegister(ctx context.Context) {
log.Ctx(ctx).Info("client register", c.getLogger()...)
fields := append(c.getLogger(), zap.String("db", GetCurDBNameFromContextOrDefault(ctx)))
log.Ctx(ctx).Info("client register", fields...)
}
func (c clientInfo) logDeregister() {

10
internal/proxy/impl.go
View File

@ -5491,6 +5491,10 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest
}
db := GetCurDBNameFromContextOrDefault(ctx)
logsToBePrinted := append(getLoggerOfClientInfo(request.GetClientInfo()), zap.String("db", db))
log := log.Ctx(ctx).With(logsToBePrinted...)
log.Info("connect received")
// maybe an `API` like `HasDatabase` is better, `ListDatabases` is a little heavy.
resp, err := node.rootCoord.ListDatabases(ctx, &milvuspb.ListDatabasesRequest{
@ -5500,6 +5504,7 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest
})
if err != nil {
log.Info("connect failed, failed to list databases", zap.Error(err))
return &milvuspb.ConnectResponse{
Status: &commonpb.Status{
ErrorCode: commonpb.ErrorCode_UnexpectedError,
@ -5509,12 +5514,16 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest
}
if resp.GetStatus().GetErrorCode() != commonpb.ErrorCode_Success {
log.Info("connect failed, failed to list databases",
zap.String("code", resp.GetStatus().GetErrorCode().String()),
zap.String("reason", resp.GetStatus().GetReason()))
return &milvuspb.ConnectResponse{
Status: proto.Clone(resp.GetStatus()).(*commonpb.Status),
}, nil
}
if !funcutil.SliceContain(resp.GetDbNames(), db) {
log.Info("connect failed, target database not exist")
return &milvuspb.ConnectResponse{
Status: &commonpb.Status{
ErrorCode: commonpb.ErrorCode_UnexpectedError, // DatabaseNotExist?
@ -5525,6 +5534,7 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest
ts, err := node.tsoAllocator.AllocOne(ctx)
if err != nil {
log.Info("connect failed, failed to allocate timestamp", zap.Error(err))
return &milvuspb.ConnectResponse{
Status: &commonpb.Status{
ErrorCode: commonpb.ErrorCode_UnexpectedError,