admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix compute score on replica selection (#25582)

Browse Source 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
This commit is contained in:
wei liu 2023-07-14 10:02:31 +08:00 committed by GitHub
parent c51922eb0b
commit fc9a6dc241
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/proxy/look_aside_balancer.go
View File

@ -151,8 +151,8 @@ func (b *LookAsideBalancer) calculateScore(node int64, cost *internalpb.CostAggr
return 0
}
executeSpeed := float64(cost.ResponseTime) - float64(1)/float64(cost.ServiceTime)
workload := math.Pow(float64(1+cost.TotalNQ+executingNQ), 3.0) / float64(cost.ServiceTime)
executeSpeed := float64(cost.ResponseTime) - float64(cost.ServiceTime)
workload := math.Pow(float64(1+cost.TotalNQ+executingNQ), 3.0) * float64(cost.ServiceTime)
if workload < 0.0 {
return math.MaxFloat64
}

6
internal/proxy/look_aside_balancer_test.go
View File

@ -98,7 +98,7 @@ func (suite *LookAsideBalancerSuite) TestCalculateScore() {
score3 := suite.balancer.calculateScore(-1, costMetrics3, 0)
score4 := suite.balancer.calculateScore(-1, costMetrics4, 0)
suite.Equal(float64(12), score1)
suite.Equal(float64(8.5), score2)
suite.Equal(float64(19), score2)
suite.Equal(float64(17), score3)
suite.Equal(float64(5), score4)
@ -107,7 +107,7 @@ func (suite *LookAsideBalancerSuite) TestCalculateScore() {
score7 := suite.balancer.calculateScore(-1, costMetrics3, 5)
score8 := suite.balancer.calculateScore(-1, costMetrics4, 5)
suite.Equal(float64(347), score5)
suite.Equal(float64(176), score6)
suite.Equal(float64(689), score6)
suite.Equal(float64(352), score7)
suite.Equal(float64(220), score8)
@ -200,7 +200,7 @@ func (suite *LookAsideBalancerSuite) TestSelectNode() {
executingNQ: map[int64]int64{1: 0, 2: 0, 3: 0},
requestCount: 100,
result: map[int64]int64{1: 27, 2: 34, 3: 39},
result: map[int64]int64{1: 40, 2: 32, 3: 28},
},
{
name: "one qn has task in queue",