admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(db): DropPartitionsByDates

Browse Source 
Former-commit-id: 2534fa34f690ba60788e3619b6a87a9a7ed8650e
This commit is contained in:
Xu Peng 2019-05-27 18:17:13 +08:00
parent 01e4e605e2
commit fbe1278a3a
7 changed files with 9 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/src/db/DB.h
View File

@ -23,8 +23,6 @@ public:
virtual Status add_group(meta::TableSchema& table_schema_) = 0;
virtual Status get_group(meta::TableSchema& table_schema_) = 0;
virtual Status delete_vectors(const std::string& table_id,
const meta::DatesT& dates) = 0;
virtual Status has_group(const std::string& table_id_, bool& has_or_not_) = 0;
virtual Status get_group_files(const std::string& table_id_,
const int date_delta_,

6
cpp/src/db/DBImpl.cpp
View File

@ -44,12 +44,6 @@ Status DBImpl<EngineT>::get_group(meta::TableSchema& table_schema) {
return _pMeta->DescribeTable(table_schema);
}
template<typename EngineT>
Status DBImpl<EngineT>::delete_vectors(const std::string& table_id,
const meta::DatesT& dates) {
return _pMeta->delete_group_partitions(table_id, dates);
}
template<typename EngineT>
Status DBImpl<EngineT>::has_group(const std::string& table_id, bool& has_or_not) {
return _pMeta->HasTable(table_id, has_or_not);

1
cpp/src/db/DBImpl.h
View File

@ -35,7 +35,6 @@ public:
virtual Status add_group(meta::TableSchema& table_schema) override;
virtual Status get_group(meta::TableSchema& table_schema) override;
virtual Status delete_vectors(const std::string& table_id, const meta::DatesT& dates) override;
virtual Status has_group(const std::string& table_id_, bool& has_or_not_) override;
virtual Status get_group_files(const std::string& table_id_,

4
cpp/src/db/DBMetaImpl.cpp
View File

@ -111,8 +111,8 @@ Status DBMetaImpl::initialize() {
}
// PXU TODO: Temp solution. Will fix later
Status DBMetaImpl::delete_group_partitions(const std::string& table_id,
const meta::DatesT& dates) {
Status DBMetaImpl::DropPartitionsByDates(const std::string& table_id,
const DatesT& dates) {
if (dates.size() == 0) {
return Status::OK();
}

4
cpp/src/db/DBMetaImpl.h
View File

@ -24,8 +24,8 @@ public:
virtual Status HasTable(const std::string& table_id, bool& has_or_not) override;
virtual Status CreateTableFile(TableFileSchema& file_schema) override;
virtual Status delete_group_partitions(const std::string& table_id,
const meta::DatesT& dates) override;
virtual Status DropPartitionsByDates(const std::string& table_id,
const DatesT& dates) override;
virtual Status has_group_file(const std::string& table_id_,
const std::string& file_id_,

4
cpp/src/db/Meta.h
View File

@ -27,8 +27,8 @@ public:
virtual Status HasTable(const std::string& table_id, bool& has_or_not) = 0;
virtual Status CreateTableFile(TableFileSchema& file_schema) = 0;
virtual Status delete_group_partitions(const std::string& table_id,
const meta::DatesT& dates) = 0;
virtual Status DropPartitionsByDates(const std::string& table_id,
const DatesT& dates) = 0;
virtual Status has_group_file(const std::string& table_id_,
const std::string& file_id_,

6
cpp/unittest/db/meta_tests.cpp
View File

@ -65,14 +65,14 @@ TEST_F(MetaTest, table_file_TEST) {
meta::DatesT dates;
dates.push_back(meta::Meta::GetDate());
status = impl_->delete_group_partitions(table_file.table_id, dates);
status = impl_->DropPartitionsByDates(table_file.table_id, dates);
ASSERT_FALSE(status.ok());
dates.clear();
for (auto i=2; i < 10; ++i) {
dates.push_back(meta::Meta::GetDateWithDelta(-1*i));
}
status = impl_->delete_group_partitions(table_file.table_id, dates);
status = impl_->DropPartitionsByDates(table_file.table_id, dates);
ASSERT_TRUE(status.ok());
table_file.date = meta::Meta::GetDateWithDelta(-2);
@ -83,7 +83,7 @@ TEST_F(MetaTest, table_file_TEST) {
dates.clear();
dates.push_back(table_file.date);
status = impl_->delete_group_partitions(table_file.table_id, dates);
status = impl_->DropPartitionsByDates(table_file.table_id, dates);
ASSERT_TRUE(status.ok());
status = impl_->get_group_file(table_file.table_id, table_file.file_id, table_file);
ASSERT_TRUE(status.ok());