admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: check field exists in column groups before reading from loon manifest (#46816)

Browse Source 
Related to #44956

Before reading field data from loon manifest, check if the field exists
in column groups first. If the field does not exist, return an empty
result instead of proceeding with the read operation.

This is a workaround until loon natively supports returning null for
non-existent fields.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia 2026-01-07 10:09:25 +08:00 committed by GitHub
parent 63026e6791
commit fbd8a766c5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
internal/core/src/storage/Util.cpp
View File

@ -1504,7 +1504,21 @@ GetFieldDatasFromManifest(
std::optional<DataType> element_type) {
auto column_groups = GetColumnGroups(manifest_path, loon_ffi_properties);
// ReaderHandle reader_handler = 0;
// TODO remove manual check after loon support read null for non-exists field
bool field_exists = false;
const auto field_id_to_find = std::to_string(field_meta.field_id);
for (size_t i = 0; i < column_groups->size() && !field_exists; i++) {
auto column_group = column_groups->get_column_group(i);
for (const auto& column : column_group->columns) {
if (column == field_id_to_find) {
field_exists = true;
break;
}
}
}
if (!field_exists) {
return {};
}
std::string field_id_str = std::to_string(field_meta.field_id);
std::vector<std::string> needed_columns = {field_id_str};