From fb6e4ceee7fcda97e333296b4de3d8b1b74ccbce Mon Sep 17 00:00:00 2001 From: wei liu Date: Tue, 9 May 2023 14:06:40 +0800 Subject: [PATCH] correct the behavior of create duplicate rg (#23963) Signed-off-by: Wei Liu --- internal/querycoordv2/meta/resource_manager.go | 2 +- internal/querycoordv2/meta/resource_manager_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/querycoordv2/meta/resource_manager.go b/internal/querycoordv2/meta/resource_manager.go index 6b31da0571..1f403a5e7d 100644 --- a/internal/querycoordv2/meta/resource_manager.go +++ b/internal/querycoordv2/meta/resource_manager.go @@ -136,7 +136,7 @@ func (rm *ResourceManager) AddResourceGroup(rgName string) error { } if rm.groups[rgName] != nil { - return nil + return ErrRGAlreadyExist } if len(rm.groups) >= 1024 { diff --git a/internal/querycoordv2/meta/resource_manager_test.go b/internal/querycoordv2/meta/resource_manager_test.go index 287576691f..1735f4b520 100644 --- a/internal/querycoordv2/meta/resource_manager_test.go +++ b/internal/querycoordv2/meta/resource_manager_test.go @@ -67,7 +67,7 @@ func (suite *ResourceManagerSuite) TestManipulateResourceGroup() { // test add duplicate rg err = suite.manager.AddResourceGroup("rg1") - suite.NoError(err) + suite.Error(err) // test delete rg err = suite.manager.RemoveResourceGroup("rg1") suite.NoError(err)