admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: [AddField] Check field empty instead of existence (#42789)

Browse Source 
Related to #42773

Growing segment fills all known meta into `InsertRecord` data, which
cause even the field is missing, the field data will still exists.

This PR update the logic while finish loading growing segment to check
field empty or not instead of existence.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia 2025-06-17 17:22:39 +08:00 committed by GitHub
parent a9dcd4a380
commit f9caad95b9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
internal/core/src/segcore/SegmentGrowingImpl.cpp
View File

@ -1253,7 +1253,9 @@ SegmentGrowingImpl::FinishLoad() {
if (field_id.get() < START_USER_FIELDID) {
continue;
}
if (!insert_record_.is_data_exist(field_id)) {
// append_data is called according to schema before
// so we must check data empty here
if (!IsVectorDataType(field_meta.get_data_type()) &&insert_record_.get_data_base(field_id)->empty()) {
fill_empty_field(field_meta);
}
}
@ -1262,7 +1264,12 @@ SegmentGrowingImpl::FinishLoad() {
void
SegmentGrowingImpl::fill_empty_field(const FieldMeta& field_meta) {
auto field_id = field_meta.get_id();
insert_record_.append_field_meta(field_id, field_meta, size_per_chunk());
// append meta only needed when schema is old
// loading old segment with new schema will have meta appended
if (!insert_record_.is_data_exist(field_id)) {
insert_record_.append_field_meta(
field_id, field_meta, size_per_chunk());
}
auto total_row_num = insert_record_.size();
@ -1271,6 +1278,9 @@ SegmentGrowingImpl::fill_empty_field(const FieldMeta& field_meta) {
0, total_row_num, data.get(), field_meta);
insert_record_.get_valid_data(field_id)->set_data_raw(
total_row_num, data.get(), field_meta);
LOG_INFO("Growing segment {} fill empty field {} done",
this->get_segment_id(),
field_meta.get_id().get());
}
} // namespace milvus::segcore