From f8929cc36a0186de577ec2f2c03a40f254170ead Mon Sep 17 00:00:00 2001 From: aoiasd <45024769+aoiasd@users.noreply.github.com> Date: Tue, 21 May 2024 10:39:39 +0800 Subject: [PATCH] fix: can't generate traceID when use noop exporter (#33191) relate: https://github.com/milvus-io/milvus/issues/33190 Signed-off-by: aoiasd --- pkg/tracer/tracer.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/pkg/tracer/tracer.go b/pkg/tracer/tracer.go index bb675f6f48..7f18634064 100644 --- a/pkg/tracer/tracer.go +++ b/pkg/tracer/tracer.go @@ -29,7 +29,6 @@ import ( "go.opentelemetry.io/otel/sdk/resource" sdk "go.opentelemetry.io/otel/sdk/trace" semconv "go.opentelemetry.io/otel/semconv/v1.4.0" - "go.opentelemetry.io/otel/trace" "go.uber.org/zap" "github.com/milvus-io/milvus/pkg/log" @@ -63,11 +62,6 @@ func CloseTracerProvider(ctx context.Context) error { } func SetTracerProvider(exp sdk.SpanExporter, traceIDRatio float64) { - if exp == nil { - otel.SetTracerProvider(trace.NewNoopTracerProvider()) - return - } - tp := sdk.NewTracerProvider( sdk.WithBatcher(exp), sdk.WithResource(resource.NewWithAttributes(