From f4661299240563e65a8a78d671a017481b4c0cdd Mon Sep 17 00:00:00 2001 From: wei liu Date: Fri, 2 Aug 2024 14:48:14 +0800 Subject: [PATCH] enhance: add segment state on data coord bin log size metrics (#35153) Signed-off-by: Wei Liu --- internal/datacoord/meta.go | 2 +- pkg/metrics/datacoord_metrics.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/internal/datacoord/meta.go b/internal/datacoord/meta.go index 71b696a473..ecc711d340 100644 --- a/internal/datacoord/meta.go +++ b/internal/datacoord/meta.go @@ -412,7 +412,7 @@ func (m *meta) GetQuotaInfo() *metricsinfo.DataCoordQuotaMetrics { coll, ok := m.collections[segment.GetCollectionID()] if ok { metrics.DataCoordStoredBinlogSize.WithLabelValues(coll.DatabaseName, - fmt.Sprint(segment.GetCollectionID()), fmt.Sprint(segment.GetID())).Set(float64(segmentSize)) + fmt.Sprint(segment.GetCollectionID()), fmt.Sprint(segment.GetID()), segment.GetState().String()).Set(float64(segmentSize)) } else { log.Warn("not found database name", zap.Int64("collectionID", segment.GetCollectionID())) } diff --git a/pkg/metrics/datacoord_metrics.go b/pkg/metrics/datacoord_metrics.go index 36338eeb84..3bf4dfe8b7 100644 --- a/pkg/metrics/datacoord_metrics.go +++ b/pkg/metrics/datacoord_metrics.go @@ -138,6 +138,7 @@ var ( databaseLabelName, collectionIDLabelName, segmentIDLabelName, + segmentStateLabelName, }) DataCoordSegmentBinLogFileCount = prometheus.NewGaugeVec( prometheus.GaugeOpts{