admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-06 17:18:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: [skip e2e] TestNodeDownOnSingleReplica has unstable result (#37288)

Browse Source 
issue: #37289
those test case use search to verify replica's status, but if the search
gap is 1s, the node down's effect may be fixed up by balance.

This PR remove the 1 second gap between search operation.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
This commit is contained in:
wei liu 2024-11-01 10:50:21 +08:00 committed by GitHub
parent 0ac8b166b3
commit f190e5d802
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/integration/replicas/balance/replica_test.go
View File

@ -106,7 +106,7 @@ func (s *ReplicaTestSuit) TestNodeDownOnSingleReplica() {
case <-stopSearchCh: case <-stopSearchCh:
log.Info("stop search") log.Info("stop search")
return return
case <-time.After(time.Second): default:
expr := fmt.Sprintf("%s > 0", integration.Int64Field) expr := fmt.Sprintf("%s > 0", integration.Int64Field)
nq := 10 nq := 10
topk := 10 topk := 10
@ -131,9 +131,8 @@ func (s *ReplicaTestSuit) TestNodeDownOnSingleReplica() {
// stop qn in single replica expected got search failures // stop qn in single replica expected got search failures
qn.Stop() qn.Stop()
s.Eventually(func() bool { time.Sleep(10 * time.Second)
return failCounter.Load() > 0 s.True(failCounter.Load() > 0)
}, 30*time.Second, 1*time.Second)
close(stopSearchCh) close(stopSearchCh)
} }
@ -176,7 +175,7 @@ func (s *ReplicaTestSuit) TestNodeDownOnMultiReplica() {
case <-stopSearchCh: case <-stopSearchCh:
log.Info("stop search") log.Info("stop search")
return return
case <-time.After(time.Second): default:
expr := fmt.Sprintf("%s > 0", integration.Int64Field) expr := fmt.Sprintf("%s > 0", integration.Int64Field)
nq := 10 nq := 10
topk := 10 topk := 10