mirror of
https://gitee.com/milvus-io/milvus.git
synced 2025-12-08 01:58:34 +08:00
enhance: Make accesslog.$consistency_level represent actual value used (#44706)
Related to #44703 This PR: - Add `SetActualConsistencyLevel` to `info.AccessInfo` interface and related util method processing it - Make `$consistency_level` returning actual value if set --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
parent
97c987f313
commit
efbe6669ec
@ -50,6 +50,9 @@ type GrpcAccessInfo struct {
|
|||||||
grpcInfo *grpc.UnaryServerInfo
|
grpcInfo *grpc.UnaryServerInfo
|
||||||
start time.Time
|
start time.Time
|
||||||
end time.Time
|
end time.Time
|
||||||
|
|
||||||
|
// runtime set info
|
||||||
|
actualConsistencyLevel *commonpb.ConsistencyLevel
|
||||||
}
|
}
|
||||||
|
|
||||||
func NewGrpcAccessInfo(ctx context.Context, grpcInfo *grpc.UnaryServerInfo, req interface{}) *GrpcAccessInfo {
|
func NewGrpcAccessInfo(ctx context.Context, grpcInfo *grpc.UnaryServerInfo, req interface{}) *GrpcAccessInfo {
|
||||||
@ -299,6 +302,10 @@ func (i *GrpcAccessInfo) OutputFields() string {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (i *GrpcAccessInfo) ConsistencyLevel() string {
|
func (i *GrpcAccessInfo) ConsistencyLevel() string {
|
||||||
|
// return actual consistency level if set
|
||||||
|
if i.actualConsistencyLevel != nil {
|
||||||
|
return i.actualConsistencyLevel.String()
|
||||||
|
}
|
||||||
level, ok := requestutil.GetConsistencyLevelFromRequst(i.req)
|
level, ok := requestutil.GetConsistencyLevelFromRequst(i.req)
|
||||||
if ok {
|
if ok {
|
||||||
return level.String()
|
return level.String()
|
||||||
@ -357,3 +364,7 @@ func (i *GrpcAccessInfo) ClientRequestTime() string {
|
|||||||
|
|
||||||
return time.UnixMilli(unixmsec).Format(timeFormat)
|
return time.UnixMilli(unixmsec).Format(timeFormat)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (i *GrpcAccessInfo) SetActualConsistencyLevel(acl commonpb.ConsistencyLevel) {
|
||||||
|
i.actualConsistencyLevel = &acl
|
||||||
|
}
|
||||||
|
|||||||
@ -16,6 +16,8 @@
|
|||||||
|
|
||||||
package info
|
package info
|
||||||
|
|
||||||
|
import "github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
||||||
|
|
||||||
const (
|
const (
|
||||||
Unknown = "Unknown"
|
Unknown = "Unknown"
|
||||||
timeFormat = "2006/01/02 15:04:05.000 -07:00"
|
timeFormat = "2006/01/02 15:04:05.000 -07:00"
|
||||||
@ -80,6 +82,7 @@ type AccessInfo interface {
|
|||||||
SearchParams() string
|
SearchParams() string
|
||||||
QueryParams() string
|
QueryParams() string
|
||||||
ClientRequestTime() string
|
ClientRequestTime() string
|
||||||
|
SetActualConsistencyLevel(commonpb.ConsistencyLevel)
|
||||||
}
|
}
|
||||||
|
|
||||||
func Get(i AccessInfo, keys ...string) []any {
|
func Get(i AccessInfo, keys ...string) []any {
|
||||||
|
|||||||
@ -25,6 +25,7 @@ import (
|
|||||||
"github.com/gin-gonic/gin"
|
"github.com/gin-gonic/gin"
|
||||||
"github.com/samber/lo"
|
"github.com/samber/lo"
|
||||||
|
|
||||||
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
||||||
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
|
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
|
||||||
"github.com/milvus-io/milvus/pkg/v2/util/requestutil"
|
"github.com/milvus-io/milvus/pkg/v2/util/requestutil"
|
||||||
)
|
)
|
||||||
@ -41,6 +42,9 @@ type RestfulInfo struct {
|
|||||||
params *gin.LogFormatterParams
|
params *gin.LogFormatterParams
|
||||||
start time.Time
|
start time.Time
|
||||||
req interface{}
|
req interface{}
|
||||||
|
|
||||||
|
// runtime set info
|
||||||
|
actualConsistencyLevel *commonpb.ConsistencyLevel
|
||||||
}
|
}
|
||||||
|
|
||||||
func NewRestfulInfo() *RestfulInfo {
|
func NewRestfulInfo() *RestfulInfo {
|
||||||
@ -209,6 +213,10 @@ func (i *RestfulInfo) OutputFields() string {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (i *RestfulInfo) ConsistencyLevel() string {
|
func (i *RestfulInfo) ConsistencyLevel() string {
|
||||||
|
// return actual consistency level if set
|
||||||
|
if i.actualConsistencyLevel != nil {
|
||||||
|
return i.actualConsistencyLevel.String()
|
||||||
|
}
|
||||||
level, ok := requestutil.GetConsistencyLevelFromRequst(i.req)
|
level, ok := requestutil.GetConsistencyLevelFromRequst(i.req)
|
||||||
if ok {
|
if ok {
|
||||||
return level.String()
|
return level.String()
|
||||||
@ -259,3 +267,7 @@ func (i *RestfulInfo) QueryParams() string {
|
|||||||
func (i *RestfulInfo) ClientRequestTime() string {
|
func (i *RestfulInfo) ClientRequestTime() string {
|
||||||
return Unknown
|
return Unknown
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (i *RestfulInfo) SetActualConsistencyLevel(acl commonpb.ConsistencyLevel) {
|
||||||
|
i.actualConsistencyLevel = &acl
|
||||||
|
}
|
||||||
|
|||||||
@ -25,6 +25,7 @@ import (
|
|||||||
"github.com/gin-gonic/gin"
|
"github.com/gin-gonic/gin"
|
||||||
"google.golang.org/grpc"
|
"google.golang.org/grpc"
|
||||||
|
|
||||||
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
||||||
"github.com/milvus-io/milvus/internal/proxy/accesslog/info"
|
"github.com/milvus-io/milvus/internal/proxy/accesslog/info"
|
||||||
)
|
)
|
||||||
|
|
||||||
@ -82,3 +83,13 @@ func timeFromName(filename, prefix, ext string) (time.Time, error) {
|
|||||||
ts := filename[len(prefix) : len(filename)-len(ext)]
|
ts := filename[len(prefix) : len(filename)-len(ext)]
|
||||||
return time.Parse(timeNameFormat, ts)
|
return time.Parse(timeNameFormat, ts)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func SetActualConsistencyLevel(ctx context.Context, acl commonpb.ConsistencyLevel) {
|
||||||
|
if ctx != nil {
|
||||||
|
v := ctx.Value(AccessKey{})
|
||||||
|
info, ok := v.(info.AccessInfo)
|
||||||
|
if ok && info != nil {
|
||||||
|
info.SetActualConsistencyLevel(acl)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
@ -16,6 +16,7 @@ import (
|
|||||||
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
|
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
|
||||||
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
|
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
|
||||||
"github.com/milvus-io/milvus/internal/parser/planparserv2"
|
"github.com/milvus-io/milvus/internal/parser/planparserv2"
|
||||||
|
"github.com/milvus-io/milvus/internal/proxy/accesslog"
|
||||||
"github.com/milvus-io/milvus/internal/types"
|
"github.com/milvus-io/milvus/internal/types"
|
||||||
"github.com/milvus-io/milvus/internal/util/exprutil"
|
"github.com/milvus-io/milvus/internal/util/exprutil"
|
||||||
"github.com/milvus-io/milvus/internal/util/reduce"
|
"github.com/milvus-io/milvus/internal/util/reduce"
|
||||||
@ -525,6 +526,9 @@ func (t *queryTask) PreExecute(ctx context.Context) error {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// update actual consistency level
|
||||||
|
accesslog.SetActualConsistencyLevel(ctx, consistencyLevel)
|
||||||
|
|
||||||
// use collection schema updated timestamp if it's greater than calculate guarantee timestamp
|
// use collection schema updated timestamp if it's greater than calculate guarantee timestamp
|
||||||
// this make query view updated happens before new read request happens
|
// this make query view updated happens before new read request happens
|
||||||
// see also schema change design
|
// see also schema change design
|
||||||
|
|||||||
@ -18,6 +18,7 @@ import (
|
|||||||
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
|
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
|
||||||
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
|
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
|
||||||
"github.com/milvus-io/milvus/internal/parser/planparserv2"
|
"github.com/milvus-io/milvus/internal/parser/planparserv2"
|
||||||
|
"github.com/milvus-io/milvus/internal/proxy/accesslog"
|
||||||
"github.com/milvus-io/milvus/internal/types"
|
"github.com/milvus-io/milvus/internal/types"
|
||||||
"github.com/milvus-io/milvus/internal/util/exprutil"
|
"github.com/milvus-io/milvus/internal/util/exprutil"
|
||||||
"github.com/milvus-io/milvus/internal/util/function/embedding"
|
"github.com/milvus-io/milvus/internal/util/function/embedding"
|
||||||
@ -241,6 +242,9 @@ func (t *searchTask) PreExecute(ctx context.Context) error {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// update actual consistency level
|
||||||
|
accesslog.SetActualConsistencyLevel(ctx, consistencyLevel)
|
||||||
|
|
||||||
// use collection schema updated timestamp if it's greater than calculate guarantee timestamp
|
// use collection schema updated timestamp if it's greater than calculate guarantee timestamp
|
||||||
// this make query view updated happens before new read request happens
|
// this make query view updated happens before new read request happens
|
||||||
// see also schema change design
|
// see also schema change design
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user