admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: [AddField] Skip missing nullable field in insertCodec (#42724)

Browse Source 
Related to #42723

Previous PR #42684 permit insert msg transformation but insertCodec did
not adapt the same skip logic, whic causes panicking.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia 2025-06-13 19:56:36 +08:00 committed by GitHub
parent 9976e8e297
commit ef8829c5bc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
internal/storage/data_codec.go
View File

@ -24,10 +24,12 @@ import (
"github.com/cockroachdb/errors"
"github.com/samber/lo"
"go.uber.org/zap"
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
"github.com/milvus-io/milvus/internal/json"
"github.com/milvus-io/milvus/pkg/v2/common"
"github.com/milvus-io/milvus/pkg/v2/log"
"github.com/milvus-io/milvus/pkg/v2/proto/etcdpb"
"github.com/milvus-io/milvus/pkg/v2/util/merr"
"github.com/milvus-io/milvus/pkg/v2/util/metautil"
@ -254,6 +256,29 @@ func (insertCodec *InsertCodec) Serialize(partitionID UniqueID, segmentID Unique
}
for _, field := range insertCodec.Schema.Schema.Fields {
// check insert data contain this field
// must be all missing or all exists
allExists := true
allMissing := false
for _, block := range data {
_, ok := block.Data[field.FieldID]
allExists = allExists && ok
allMissing = allMissing || !ok
}
// found missing block
if !allExists {
if !field.GetNullable() {
return nil, errors.Newf("field %d(%s) missing and field not nullable", field.GetFieldID(), field.GetName())
}
// segment must be in same schema
if !allMissing {
return nil, errors.Newf("segment must not be heterogeneous, all blocks must contain all fields or none, abnormal field %d(%s)", field.GetFieldID(), field.GetName())
}
log.Info("Skip field nullable missing field, could be schema change", zap.Int64("fieldId", field.GetFieldID()), zap.String("fieldName", field.GetName()))
continue
}
// encode fields
writer = NewInsertBinlogWriter(field.DataType, insertCodec.Schema.ID, partitionID, segmentID, field.FieldID, field.GetNullable())