From e6dd3e5a57b994aacbb32d14f35f0d2e7e6f0823 Mon Sep 17 00:00:00 2001 From: "cai.zhang" Date: Mon, 6 Jan 2025 18:02:55 +0800 Subject: [PATCH] fix: [2.5]Remove valid expressions from invalid expressions (#38999) issue: #39014 master pr: #38957 master pr: #39012 --------- Signed-off-by: Cai Zhang --- internal/datacoord/server.go | 2 +- tests/go_client/common/utils.go | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/internal/datacoord/server.go b/internal/datacoord/server.go index b5c0ac15dc..ada34adad3 100644 --- a/internal/datacoord/server.go +++ b/internal/datacoord/server.go @@ -213,7 +213,7 @@ func CreateServer(ctx context.Context, factory dependency.Factory, opts ...Optio quitCh: make(chan struct{}), factory: factory, flushCh: make(chan UniqueID, 1024), - notifyIndexChan: make(chan UniqueID), + notifyIndexChan: make(chan UniqueID, 1024), dataNodeCreator: defaultDataNodeCreatorFunc, indexNodeCreator: defaultIndexNodeCreatorFunc, rootCoordClientCreator: defaultRootCoordCreatorFunc, diff --git a/tests/go_client/common/utils.go b/tests/go_client/common/utils.go index 7b671b0b8c..76722bc200 100644 --- a/tests/go_client/common/utils.go +++ b/tests/go_client/common/utils.go @@ -134,8 +134,6 @@ type InvalidExprStruct struct { var InvalidExpressions = []InvalidExprStruct{ {Expr: "id in [0]", ErrNil: true, ErrMsg: "fieldName(id) not found"}, // not exist field but no error {Expr: "int64 in not [0]", ErrNil: false, ErrMsg: "cannot parse expression"}, // wrong term expr keyword - {Expr: "int64 > 10 AND int64 < 100", ErrNil: false, ErrMsg: "cannot parse expression"}, // AND isn't supported - {Expr: "int64 < 10 OR int64 > 100", ErrNil: false, ErrMsg: "cannot parse expression"}, // OR isn't supported {Expr: "int64 < floatVec", ErrNil: false, ErrMsg: "not supported"}, // unsupported compare field {Expr: "floatVec in [0]", ErrNil: false, ErrMsg: "cannot be casted to FloatVector"}, // value and field type mismatch {Expr: fmt.Sprintf("%s == 1", DefaultJSONFieldName), ErrNil: true, ErrMsg: ""}, // hist empty