From e2566c0e9283346996518abf26e75c0aa0811412 Mon Sep 17 00:00:00 2001 From: aoiasd <45024769+aoiasd@users.noreply.github.com> Date: Wed, 25 Jun 2025 13:44:46 +0800 Subject: [PATCH] enhance: bm25 stats local cache use local storage path (#42923) Signed-off-by: aoiasd --- configs/milvus.yaml | 1 - internal/querynodev2/delegator/idf_oracle.go | 2 +- pkg/util/paramtable/component_param.go | 9 --------- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/configs/milvus.yaml b/configs/milvus.yaml index 716815f604..22e942710b 100644 --- a/configs/milvus.yaml +++ b/configs/milvus.yaml @@ -544,7 +544,6 @@ queryNode: size: 10 # the size for worker querynode client pool idfOracle: enableDisk: true - localPath: /var/lib/milvus/bm25_logs writeConcurrency: 4 ip: # TCP/IP address of queryNode. If not specified, use the first unicastable address port: 21123 # TCP port of queryNode diff --git a/internal/querynodev2/delegator/idf_oracle.go b/internal/querynodev2/delegator/idf_oracle.go index 3469a81b70..e49ff5b871 100644 --- a/internal/querynodev2/delegator/idf_oracle.go +++ b/internal/querynodev2/delegator/idf_oracle.go @@ -404,7 +404,7 @@ func (o *idfOracle) syncloop() { func (o *idfOracle) localloop() { pool := conc.NewPool[struct{}](paramtable.Get().QueryNodeCfg.IDFWriteConcurrenct.GetAsInt()) - o.dirPath = path.Join(paramtable.Get().QueryNodeCfg.IDFLocalPath.GetValue(), fmt.Sprintf("%d", o.collectionID)) + o.dirPath = path.Join(paramtable.Get().LocalStorageCfg.Path.GetValue(), "bm25", fmt.Sprintf("%d", o.collectionID)) defer o.wg.Done() for { diff --git a/pkg/util/paramtable/component_param.go b/pkg/util/paramtable/component_param.go index 7a919aa2cb..09031e1e7d 100644 --- a/pkg/util/paramtable/component_param.go +++ b/pkg/util/paramtable/component_param.go @@ -2896,7 +2896,6 @@ type queryNodeConfig struct { // Idf Oracle IDFEnableDisk ParamItem `refreshable:"true"` - IDFLocalPath ParamItem `refreshable:"true"` IDFWriteConcurrenct ParamItem `refreshable:"true"` // partial search PartialResultRequiredDataRatio ParamItem `refreshable:"true"` @@ -2911,14 +2910,6 @@ func (p *queryNodeConfig) init(base *BaseTable) { } p.IDFEnableDisk.Init(base.mgr) - p.IDFLocalPath = ParamItem{ - Key: "queryNode.idfOracle.localPath", - Version: "2.6.0", - Export: true, - DefaultValue: "/var/lib/milvus/bm25_logs", - } - p.IDFLocalPath.Init(base.mgr) - p.IDFWriteConcurrenct = ParamItem{ Key: "queryNode.idfOracle.writeConcurrency", Version: "2.6.0",