admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix wrong bool param in the getDistribution method (#21463)

Browse Source 
Signed-off-by: SimFG <bang.fu@zilliz.com>
This commit is contained in:
SimFG 2022-12-30 14:15:31 +08:00 committed by GitHub
parent daa4492e95
commit df6ccfa104
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
internal/querycoordv2/dist/dist_handler.go vendored
View File

@ -68,8 +68,8 @@ func (dh *distHandler) start(ctx context.Context) {
logger.Info("close dist handelr")
return
case <-ticker.C:
dh.getDistribution(ctx, func(isSuccess bool) {
if !isSuccess {
dh.getDistribution(ctx, func(isFail bool) {
if isFail {
failures++
node := dh.nodeManager.Get(dh.nodeID)
if node != nil {
@ -207,7 +207,7 @@ func (dh *distHandler) updateLeaderView(resp *querypb.GetDataDistributionRespons
dh.dist.LeaderViewManager.Update(resp.GetNodeID(), updates...)
}
func (dh *distHandler) getDistribution(ctx context.Context, fn func(isSuccess bool)) {
func (dh *distHandler) getDistribution(ctx context.Context, fn func(isFail bool)) {
dh.mu.Lock()
defer dh.mu.Unlock()
cctx, cancel := context.WithTimeout(ctx, distReqTimeout)
@ -218,15 +218,15 @@ func (dh *distHandler) getDistribution(ctx context.Context, fn func(isSuccess bo
})
cancel()
isSuccess := err != nil || resp.GetStatus().GetErrorCode() != commonpb.ErrorCode_Success
if isSuccess {
isFail := err != nil || resp.GetStatus().GetErrorCode() != commonpb.ErrorCode_Success
if isFail {
dh.logFailureInfo(resp, err)
} else {
dh.handleDistResp(resp)
}
if fn != nil {
fn(isSuccess)
fn(isFail)
}
}