From dda70aa81b7aa41bbc51f89c4d6d83c3b11cc3ec Mon Sep 17 00:00:00 2001 From: XuanYang-cn Date: Thu, 27 Jun 2024 19:36:06 +0800 Subject: [PATCH] fix: LegacyVersionWithoutRPCWatch default value to 2.4.1 (#34184) See also: #31933 --------- Signed-off-by: yangxuan --- configs/milvus.yaml | 2 +- pkg/util/paramtable/component_param.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configs/milvus.yaml b/configs/milvus.yaml index a16eb1f52b..f51990b9a0 100644 --- a/configs/milvus.yaml +++ b/configs/milvus.yaml @@ -420,7 +420,7 @@ dataCoord: channel: watchTimeoutInterval: 300 # Timeout on watching channels (in seconds). Datanode tickler update watch progress will reset timeout timer. balanceWithRpc: true # Whether to enable balance with RPC, default to use etcd watch - legacyVersionWithoutRPCWatch: 2.4.0 # Datanodes <= this version are considered as legacy nodes, which doesn't have rpc based watch(). This is only used during rolling upgrade where legacy nodes won't get new channels + legacyVersionWithoutRPCWatch: 2.4.1 # Datanodes <= this version are considered as legacy nodes, which doesn't have rpc based watch(). This is only used during rolling upgrade where legacy nodes won't get new channels balanceSilentDuration: 300 # The duration after which the channel manager start background channel balancing balanceInterval: 360 # The interval with which the channel manager check dml channel balance status checkInterval: 1 # The interval in seconds with which the channel manager advances channel states diff --git a/pkg/util/paramtable/component_param.go b/pkg/util/paramtable/component_param.go index 90ee8c5a5c..55a90224e0 100644 --- a/pkg/util/paramtable/component_param.go +++ b/pkg/util/paramtable/component_param.go @@ -2959,8 +2959,8 @@ func (p *dataCoordConfig) init(base *BaseTable) { p.LegacyVersionWithoutRPCWatch = ParamItem{ Key: "dataCoord.channel.legacyVersionWithoutRPCWatch", - Version: "2.4.0", - DefaultValue: "2.4.0", + Version: "2.4.1", + DefaultValue: "2.4.1", Doc: "Datanodes <= this version are considered as legacy nodes, which doesn't have rpc based watch(). This is only used during rolling upgrade where legacy nodes won't get new channels", Export: true, }