From dc058eaf61441ceb43710cecf76c253a764f2ab9 Mon Sep 17 00:00:00 2001 From: aoiasd <45024769+aoiasd@users.noreply.github.com> Date: Tue, 14 May 2024 10:47:32 +0800 Subject: [PATCH] fix: should init access logger before init server (#32976) relate: https://github.com/milvus-io/milvus/issues/32968 Signed-off-by: aoiasd --- internal/distributed/proxy/service.go | 1 + internal/proxy/proxy.go | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/distributed/proxy/service.go b/internal/distributed/proxy/service.go index 3dd50215c7..bb902bc328 100644 --- a/internal/distributed/proxy/service.go +++ b/internal/distributed/proxy/service.go @@ -465,6 +465,7 @@ func (s *Server) init() error { zap.String("externalAddress", Params.GetAddress()), ) + accesslog.InitAccessLogger(paramtable.Get()) serviceName := fmt.Sprintf("Proxy ip: %s, port: %d", Params.IP, Params.Port.GetAsInt()) log.Debug("init Proxy's tracer done", zap.String("service name", serviceName)) diff --git a/internal/proxy/proxy.go b/internal/proxy/proxy.go index 8bd24331fe..22d3dfbb9b 100644 --- a/internal/proxy/proxy.go +++ b/internal/proxy/proxy.go @@ -35,7 +35,6 @@ import ( "github.com/milvus-io/milvus-proto/go-api/v2/milvuspb" "github.com/milvus-io/milvus/internal/allocator" "github.com/milvus-io/milvus/internal/proto/internalpb" - "github.com/milvus-io/milvus/internal/proxy/accesslog" "github.com/milvus-io/milvus/internal/proxy/connection" "github.com/milvus-io/milvus/internal/types" "github.com/milvus-io/milvus/internal/util/dependency" @@ -222,7 +221,6 @@ func (node *Proxy) Init() error { node.factory.Init(Params) - accesslog.InitAccessLogger(Params) log.Debug("init access log for Proxy done") err := node.initRateCollector()