From d9a151e9e40490c749e1c3fca1795d82bda4a935 Mon Sep 17 00:00:00 2001 From: nico <109071306+NicoYuan1986@users.noreply.github.com> Date: Tue, 10 Dec 2024 18:46:42 +0800 Subject: [PATCH] test: update test cases (#38330) Signed-off-by: nico --- .../milvus_client/test_milvus_client_delete.py | 2 +- tests/python_client/testcases/test_delete.py | 10 ++++++---- tests/python_client/testcases/test_partition_key.py | 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/tests/python_client/milvus_client/test_milvus_client_delete.py b/tests/python_client/milvus_client/test_milvus_client_delete.py index e4139949a8..6159668155 100644 --- a/tests/python_client/milvus_client/test_milvus_client_delete.py +++ b/tests/python_client/milvus_client/test_milvus_client_delete.py @@ -121,7 +121,7 @@ class TestMilvusClientDeleteInvalid(TestcaseBase): client_w.delete(client, collection_name, check_task=CheckTasks.err_res, check_items={"err_code": 999, - "err_msg": "filter or ids cannot be empty"}) + "err_msg": "The type of expr must be string ,but is given."}) class TestMilvusClientDeleteValid(TestcaseBase): diff --git a/tests/python_client/testcases/test_delete.py b/tests/python_client/testcases/test_delete.py index 7580914d1a..70c6d2dbb9 100644 --- a/tests/python_client/testcases/test_delete.py +++ b/tests/python_client/testcases/test_delete.py @@ -108,7 +108,7 @@ class TestDeleteParams(TestcaseBase): """ # init collection with tmp_nb default data collection_w = self.init_collection_general(prefix, nb=tmp_nb, insert_data=True)[0] - error = {ct.err_code: 999, ct.err_msg: "cannot be None"} + error = {ct.err_code: 999, ct.err_msg: "Illegal str variables: {'filter': None}, expect non-empty str"} collection_w.delete(expr=None, check_task=CheckTasks.err_res, check_items=error) @pytest.mark.tags(CaseLabel.L2) @@ -121,7 +121,8 @@ class TestDeleteParams(TestcaseBase): """ # init collection with tmp_nb default data collection_w = self.init_collection_general(prefix, nb=tmp_nb, insert_data=True)[0] - error = {ct.err_code: 999, ct.err_msg: f"value {expr} is illegal"} + error = {ct.err_code: 999, ct.err_msg: "Illegal str variables: {'filter': %s}, expect non-empty str" + % str(expr)} collection_w.delete(expr, check_task=CheckTasks.err_res, check_items=error) @pytest.mark.tags(CaseLabel.L2) @@ -311,7 +312,8 @@ class TestDeleteParams(TestcaseBase): collection_w = self.init_collection_general(prefix, nb=tmp_nb, insert_data=True)[0] error = {ct.err_code: 0, - ct.err_msg: f"partition_name value {partition_name} is illegal"} + ct.err_msg: "Illegal nullable str variables: {'partition_name': %s}, " + "expect None or non-empty str" % str(partition_name)} collection_w.delete(tmp_expr, partition_name=partition_name, check_task=CheckTasks.err_res, check_items=error) @@ -2152,7 +2154,7 @@ class TestDeleteComplexExpr(TestcaseBase): collection_w = self.init_collection_general(prefix, True)[0] # delete - error = {ct.err_code: 1, ct.err_msg: "cannot be empty"} + error = {ct.err_code: 1, ct.err_msg: "Illegal str variables: {'filter': ''}, expect non-empty str"} collection_w.delete(expr="", check_task=CheckTasks.err_res, check_items=error) @pytest.mark.tags(CaseLabel.L2) diff --git a/tests/python_client/testcases/test_partition_key.py b/tests/python_client/testcases/test_partition_key.py index b16cc16755..31d6f75d2b 100644 --- a/tests/python_client/testcases/test_partition_key.py +++ b/tests/python_client/testcases/test_partition_key.py @@ -485,7 +485,7 @@ class TestPartitionKeyInvalidParams(TestcaseBase): float_vec_values = gen_vectors(nb, ct.default_dim) data = [pk_values, int64_values, string_values, float_vec_values] - err_msg = "expect string input" + err_msg = "field (varchar) expects string input" collection_w.insert(data, check_task=CheckTasks.err_res, check_items={"err_code": 2, "err_msg": err_msg})