From d822edb9a8bb18dfd67d8ee0ed38715e97c85d5a Mon Sep 17 00:00:00 2001 From: sthuang <167743503+shaoting-huang@users.noreply.github.com> Date: Tue, 3 Dec 2024 23:42:39 +0800 Subject: [PATCH] enhance: add list aliases privilege into public role (#38176) related issue: https://github.com/milvus-io/milvus/issues/37031 Signed-off-by: shaoting-huang --- internal/rootcoord/root_coord.go | 1 + internal/rootcoord/root_coord_test.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/internal/rootcoord/root_coord.go b/internal/rootcoord/root_coord.go index 13bff93517..ed07f88a8c 100644 --- a/internal/rootcoord/root_coord.go +++ b/internal/rootcoord/root_coord.go @@ -590,6 +590,7 @@ func (c *Core) initPublicRolePrivilege() error { // grant privileges for the public role globalPrivileges := []string{ commonpb.ObjectPrivilege_PrivilegeDescribeCollection.String(), + commonpb.ObjectPrivilege_PrivilegeListAliases.String(), } collectionPrivileges := []string{ commonpb.ObjectPrivilege_PrivilegeIndexDetail.String(), diff --git a/internal/rootcoord/root_coord_test.go b/internal/rootcoord/root_coord_test.go index c9a803f642..b8915e5dea 100644 --- a/internal/rootcoord/root_coord_test.go +++ b/internal/rootcoord/root_coord_test.go @@ -1977,7 +1977,7 @@ func TestCore_InitRBAC(t *testing.T) { meta := mockrootcoord.NewIMetaTable(t) c := newTestCore(withHealthyCode(), withMeta(meta)) meta.EXPECT().CreateRole(mock.Anything, mock.Anything, mock.Anything).Return(nil).Twice() - meta.EXPECT().OperatePrivilege(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil).Twice() + meta.EXPECT().OperatePrivilege(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil).Times(3) Params.Save(Params.RoleCfg.Enabled.Key, "false") Params.Save(Params.ProxyCfg.EnablePublicPrivilege.Key, "true")