From d76c744646dc826e92218a8d27370462467e1cfd Mon Sep 17 00:00:00 2001 From: wei liu Date: Wed, 8 Nov 2023 02:22:26 +0800 Subject: [PATCH] Fix proxy not healthy before graceful stop (#28255) Signed-off-by: Wei Liu --- internal/distributed/proxy/service.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/internal/distributed/proxy/service.go b/internal/distributed/proxy/service.go index 94a0aab373..8c4c3879ee 100644 --- a/internal/distributed/proxy/service.go +++ b/internal/distributed/proxy/service.go @@ -639,8 +639,6 @@ func (s *Server) start() error { func (s *Server) Stop() error { Params := ¶mtable.Get().ProxyGrpcServerCfg log.Debug("Proxy stop", zap.String("internal address", Params.GetInternalAddress()), zap.String("external address", Params.GetInternalAddress())) - s.proxy.UpdateStateCode(commonpb.StateCode_Abnormal) - var err error if s.etcdCli != nil { defer s.etcdCli.Close() @@ -669,7 +667,7 @@ func (s *Server) Stop() error { s.wg.Wait() - err = s.proxy.Stop() + err := s.proxy.Stop() if err != nil { return err }