admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-07 01:28:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Fix concurrent map (#39775)

Browse Source 
issue: https://github.com/milvus-io/milvus/issues/39778

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
This commit is contained in:
yihao.dai 2025-02-22 09:51:54 +08:00 committed by GitHub
parent dd1347d041
commit d72d2281ca
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/util/typeutil/map.go
View File

@ -114,7 +114,7 @@ func (m *ConcurrentMap[K, V]) Len() int {
} }
func (m *ConcurrentMap[K, V]) Values() []V { func (m *ConcurrentMap[K, V]) Values() []V {
ret := make([]V, m.Len()) ret := make([]V, 0, m.Len())
m.inner.Range(func(key, value any) bool { m.inner.Range(func(key, value any) bool {
ret = append(ret, value.(V)) ret = append(ret, value.(V))
return true return true
@ -123,7 +123,7 @@ func (m *ConcurrentMap[K, V]) Values() []V {
} }
func (m *ConcurrentMap[K, V]) Keys() []K { func (m *ConcurrentMap[K, V]) Keys() []K {
ret := make([]K, m.Len()) ret := make([]K, 0, m.Len())
m.inner.Range(func(key, value any) bool { m.inner.Range(func(key, value any) bool {
ret = append(ret, key.(K)) ret = append(ret, key.(K))
return true return true

3
pkg/util/typeutil/map_test.go
View File

@ -75,6 +75,9 @@ func (suite *MapUtilSuite) TestConcurrentMap() {
currMap.GetOrInsert(200, "v-200") currMap.GetOrInsert(200, "v-200")
currMap.GetOrInsert(300, "v-300") currMap.GetOrInsert(300, "v-300")
suite.ElementsMatch([]int64{100, 200, 300}, currMap.Keys())
suite.ElementsMatch([]string{"v-100", "v-200", "v-300"}, currMap.Values())
var exist bool var exist bool
v, exist = currMap.Get(100) v, exist = currMap.Get(100)
suite.Equal("v-100", v) suite.Equal("v-100", v)