From d4a1e94f322e4bafaa1d32ea4fb269d215b1525b Mon Sep 17 00:00:00 2001 From: Ten Thousand Leaves <69466447+soothing-rain@users.noreply.github.com> Date: Wed, 6 Jul 2022 18:10:21 +0800 Subject: [PATCH] Fix flush failure caused by empty stale segments (#18097) /bug issue: #18096 Signed-off-by: Yuchen Gao --- internal/datacoord/server.go | 3 ++- internal/datanode/data_node.go | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/datacoord/server.go b/internal/datacoord/server.go index 058c5f7fcb..333191900c 100644 --- a/internal/datacoord/server.go +++ b/internal/datacoord/server.go @@ -641,7 +641,8 @@ func (s *Server) getStaleSegmentsInfo(ch string) []*SegmentInfo { return isSegmentHealthy(info) && info.GetInsertChannel() == ch && !info.lastFlushTime.IsZero() && - time.Since(info.lastFlushTime).Minutes() >= segmentTimedFlushDuration + time.Since(info.lastFlushTime).Minutes() >= segmentTimedFlushDuration && + info.GetNumOfRows() != 0 }) } diff --git a/internal/datanode/data_node.go b/internal/datanode/data_node.go index f626752871..683b0b7a4d 100644 --- a/internal/datanode/data_node.go +++ b/internal/datanode/data_node.go @@ -621,8 +621,7 @@ func (node *DataNode) FlushSegments(ctx context.Context, req *datapb.FlushSegmen log.Info("flow graph flushSegment tasks triggered", zap.Bool("flushed", flushed), zap.Int64("collection ID", req.GetCollectionID()), - zap.Int64s("segments", segmentIDs), - zap.Int64s("mark segments", req.GetMarkSegmentIDs())) + zap.Int64s("segments", segmentIDs)) return flushedSeg, noErr }