From d47372eb9c8c8816ee1667aa7689f564faf191cd Mon Sep 17 00:00:00 2001 From: Gao Date: Wed, 25 Dec 2024 19:02:56 +0800 Subject: [PATCH] fix: report error when hints not supported (#38730) issue: #38705 pr: #38717 --------- Signed-off-by: chasingegg --- internal/core/src/query/PlanProto.cpp | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/internal/core/src/query/PlanProto.cpp b/internal/core/src/query/PlanProto.cpp index 72597258b0..aa1892ef23 100644 --- a/internal/core/src/query/PlanProto.cpp +++ b/internal/core/src/query/PlanProto.cpp @@ -55,12 +55,26 @@ ProtoParser::PlanNodeFromProto(const planpb::PlanNode& plan_node_proto) { query_info_proto.materialized_view_involved(); // currently, iterative filter does not support range search if (!search_info.search_params_.contains(RADIUS)) { - search_info.iterative_filter_execution = - (query_info_proto.hints() == ITERATIVE_FILTER); + if (query_info_proto.hints() != "") { + if (query_info_proto.hints() == ITERATIVE_FILTER) { + search_info.iterative_filter_execution = true; + } else { + // check if hints is valid + PanicInfo(ConfigInvalid, + "hints: {} not supported", + query_info_proto.hints()); + } + } if (!search_info.iterative_filter_execution && search_info.search_params_.contains(HINTS)) { - search_info.iterative_filter_execution = - (search_info.search_params_[HINTS] == ITERATIVE_FILTER); + if (search_info.search_params_[HINTS] == ITERATIVE_FILTER) { + search_info.iterative_filter_execution = true; + } else { + // check if hints is valid + PanicInfo(ConfigInvalid, + "hints: {} not supported", + search_info.search_params_[HINTS]); + } } }