From cf883b114eee6af32c244653a016c5c4ec3bf95d Mon Sep 17 00:00:00 2001 From: foxspy Date: Wed, 13 Nov 2024 16:36:27 +0800 Subject: [PATCH] enhance: update knowhere version (#37510) issue: #36925 Signed-off-by: xianliang.li --- internal/core/thirdparty/knowhere/CMakeLists.txt | 2 +- internal/util/indexparamcheck/float_vector_base_checker_test.go | 2 +- internal/util/indexparamcheck/hnsw_checker_test.go | 2 +- internal/util/vecindexmgr/vector_index_mgr_test.go | 2 +- pkg/go.mod | 2 +- pkg/go.sum | 2 ++ 6 files changed, 7 insertions(+), 5 deletions(-) diff --git a/internal/core/thirdparty/knowhere/CMakeLists.txt b/internal/core/thirdparty/knowhere/CMakeLists.txt index 48f079faa1..1fb371906f 100644 --- a/internal/core/thirdparty/knowhere/CMakeLists.txt +++ b/internal/core/thirdparty/knowhere/CMakeLists.txt @@ -14,7 +14,7 @@ # Update KNOWHERE_VERSION for the first occurrence milvus_add_pkg_config("knowhere") set_property(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY INCLUDE_DIRECTORIES "") -set( KNOWHERE_VERSION e67abe7 ) +set( KNOWHERE_VERSION 5935c1f ) set( GIT_REPOSITORY "https://github.com/zilliztech/knowhere.git") message(STATUS "Knowhere repo: ${GIT_REPOSITORY}") message(STATUS "Knowhere version: ${KNOWHERE_VERSION}") diff --git a/internal/util/indexparamcheck/float_vector_base_checker_test.go b/internal/util/indexparamcheck/float_vector_base_checker_test.go index 7a1bf3c6d2..7306db92b0 100644 --- a/internal/util/indexparamcheck/float_vector_base_checker_test.go +++ b/internal/util/indexparamcheck/float_vector_base_checker_test.go @@ -63,7 +63,7 @@ func Test_floatVectorBaseChecker_CheckValidDataType(t *testing.T) { }, { dType: schemapb.DataType_BinaryVector, - errIsNil: true, + errIsNil: false, }, } diff --git a/internal/util/indexparamcheck/hnsw_checker_test.go b/internal/util/indexparamcheck/hnsw_checker_test.go index 0ed41375ad..fbb33dc3b0 100644 --- a/internal/util/indexparamcheck/hnsw_checker_test.go +++ b/internal/util/indexparamcheck/hnsw_checker_test.go @@ -165,7 +165,7 @@ func Test_hnswChecker_CheckValidDataType(t *testing.T) { }, { dType: schemapb.DataType_BinaryVector, - errIsNil: true, + errIsNil: false, }, } diff --git a/internal/util/vecindexmgr/vector_index_mgr_test.go b/internal/util/vecindexmgr/vector_index_mgr_test.go index d11b4467dd..eca7f52dbe 100644 --- a/internal/util/vecindexmgr/vector_index_mgr_test.go +++ b/internal/util/vecindexmgr/vector_index_mgr_test.go @@ -67,7 +67,7 @@ func Test_VecIndex_DataType_Support(t *testing.T) { schemapb.DataType_Float16Vector, schemapb.DataType_SparseFloatVector, }, - wants: []bool{true, true, true, true, false}, + wants: []bool{true, false, true, true, false}, }, { indexType: "DISKANN", diff --git a/pkg/go.mod b/pkg/go.mod index 417d0277cf..32d84bebb3 100644 --- a/pkg/go.mod +++ b/pkg/go.mod @@ -26,7 +26,7 @@ require ( github.com/shirou/gopsutil/v3 v3.22.9 github.com/sirupsen/logrus v1.9.0 github.com/spaolacci/murmur3 v1.1.0 - github.com/spf13/cast v1.3.0 + github.com/spf13/cast v1.3.1 github.com/streamnative/pulsarctl v0.5.0 github.com/stretchr/testify v1.9.0 github.com/tecbot/gorocksdb v0.0.0-20191217155057-f0fad39f321c diff --git a/pkg/go.sum b/pkg/go.sum index acbde0f955..02ea2123b4 100644 --- a/pkg/go.sum +++ b/pkg/go.sum @@ -657,6 +657,8 @@ github.com/spaolacci/murmur3 v1.1.0/go.mod h1:JwIasOWyU6f++ZhiEuf87xNszmSA2myDM2 github.com/spf13/afero v1.1.2/go.mod h1:j4pytiNVoe2o6bmDsKpLACNPDBIoEAkihy7loJ1B0CQ= github.com/spf13/cast v1.3.0 h1:oget//CVOEoFewqQxwr0Ej5yjygnqGkvggSE/gB35Q8= github.com/spf13/cast v1.3.0/go.mod h1:Qx5cxh0v+4UWYiBimWS+eyWzqEqokIECu5etghLkUJE= +github.com/spf13/cast v1.3.1 h1:nFm6S0SMdyzrzcmThSipiEubIDy8WEXKNZ0UOgiRpng= +github.com/spf13/cast v1.3.1/go.mod h1:Qx5cxh0v+4UWYiBimWS+eyWzqEqokIECu5etghLkUJE= github.com/spf13/cobra v0.0.5/go.mod h1:3K3wKZymM7VvHMDS9+Akkh4K60UwM26emMESw8tLCHU= github.com/spf13/cobra v1.1.3/go.mod h1:pGADOWyqRD/YMrPZigI/zbliZ2wVD/23d+is3pSWzOo= github.com/spf13/cobra v1.6.1 h1:o94oiPyS4KD1mPy2fmcYYHHfCxLqYjJOhGsCHFZtEzA=