From cd2f64d30c5029d194c50698636f47cad7c16fc8 Mon Sep 17 00:00:00 2001 From: Ten Thousand Leaves <69466447+soothing-rain@users.noreply.github.com> Date: Wed, 20 Jul 2022 17:56:30 +0800 Subject: [PATCH] Fix a nil pointer issue (#18343) /kind bug issue: #18270 Signed-off-by: Yuchen Gao --- internal/datacoord/meta.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/datacoord/meta.go b/internal/datacoord/meta.go index b930119cc5..6fa94764eb 100644 --- a/internal/datacoord/meta.go +++ b/internal/datacoord/meta.go @@ -800,11 +800,13 @@ func (m *meta) CompleteMergeCompaction(compactionLogs []*datapb.CompactionSegmen var startPosition, dmlPosition *internalpb.MsgPosition for _, s := range segments { - if dmlPosition == nil || s.GetDmlPosition().Timestamp < dmlPosition.Timestamp { + if dmlPosition == nil || + s.GetDmlPosition() != nil && s.GetDmlPosition().GetTimestamp() < dmlPosition.GetTimestamp() { dmlPosition = s.GetDmlPosition() } - if startPosition == nil || s.GetStartPosition().Timestamp < startPosition.Timestamp { + if startPosition == nil || + s.GetStartPosition() != nil && s.GetStartPosition().GetTimestamp() < startPosition.GetTimestamp() { startPosition = s.GetStartPosition() } }