admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-07 01:28:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Set compacted segments' level to level one (#29190)

Browse Source 
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
This commit is contained in:
XuanYang-cn 2023-12-14 18:46:40 +08:00 committed by GitHub
parent 13beb5ccc0
commit cc727ace61
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/datacoord/meta.go
View File

@ -1041,6 +1041,7 @@ func (m *meta) PrepareCompleteCompactionMutation(plan *datapb.CompactionPlan,
CreatedByCompaction: true, CreatedByCompaction: true,
CompactionFrom: compactionFrom, CompactionFrom: compactionFrom,
LastExpireTime: plan.GetStartTime(), LastExpireTime: plan.GetStartTime(),
Level: datapb.SegmentLevel_L1,
} }
segment := NewSegmentInfo(segmentInfo) segment := NewSegmentInfo(segmentInfo)
metricMutation.addNewSeg(segment.GetState(), segment.GetLevel(), segment.GetNumOfRows()) metricMutation.addNewSeg(segment.GetState(), segment.GetLevel(), segment.GetNumOfRows())
@ -1048,6 +1049,7 @@ func (m *meta) PrepareCompleteCompactionMutation(plan *datapb.CompactionPlan,
zap.Int64("collectionID", segment.GetCollectionID()), zap.Int64("collectionID", segment.GetCollectionID()),
zap.Int64("partitionID", segment.GetPartitionID()), zap.Int64("partitionID", segment.GetPartitionID()),
zap.Int64("new segment ID", segment.GetID()), zap.Int64("new segment ID", segment.GetID()),
zap.String("new segment level", segment.GetLevel().String()),
zap.Int64("new segment num of rows", segment.GetNumOfRows()), zap.Int64("new segment num of rows", segment.GetNumOfRows()),
zap.Any("compacted from", segment.GetCompactionFrom())) zap.Any("compacted from", segment.GetCompactionFrom()))

3
internal/datacoord/meta_test.go
View File

@ -730,7 +730,8 @@ func TestMeta_PrepareCompleteCompactionMutation(t *testing.T) {
assert.NoError(t, err) assert.NoError(t, err)
assert.NotNil(t, afterCompact) assert.NotNil(t, afterCompact)
assert.NotNil(t, newSegment) assert.NotNil(t, newSegment)
assert.Equal(t, 3, len(metricMutation.stateChange[datapb.SegmentLevel_Legacy.String()])) assert.Equal(t, 2, len(metricMutation.stateChange[datapb.SegmentLevel_Legacy.String()]))
assert.Equal(t, 1, len(metricMutation.stateChange[datapb.SegmentLevel_L1.String()]))
assert.Equal(t, int64(0), metricMutation.rowCountChange) assert.Equal(t, int64(0), metricMutation.rowCountChange)
assert.Equal(t, int64(2), metricMutation.rowCountAccChange) assert.Equal(t, int64(2), metricMutation.rowCountAccChange)